From: Wolfram Sang <wsa@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>,
krzysztof.kozlowski+dt@linaro.org
Cc: gregory.clement@bootlin.com, andi.shyti@kernel.org,
robh+dt@kernel.org, conor+dt@kernel.org,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: i2c: mv64xxx: add bus-reset-gpios property
Date: Fri, 27 Oct 2023 11:09:58 +0200 [thread overview]
Message-ID: <ZTt+ZgNe5Y35E/C2@shikoro> (raw)
In-Reply-To: <20231027033104.1348921-2-chris.packham@alliedtelesis.co.nz>
[-- Attachment #1: Type: text/plain, Size: 2032 bytes --]
On Fri, Oct 27, 2023 at 04:31:03PM +1300, Chris Packham wrote:
> Add bus-reset-gpios and bus-reset-duration-us properties to the
> marvell,mv64xxx-i2c binding. These can be used to describe hardware
> where a common reset GPIO is connected to all downstream devices on and
> I2C bus. This reset will be asserted then released before the downstream
> devices on the bus are probed.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Krzysztof, are you fine with this change?
> ---
>
> Notes:
> Changes in v5:
> - Rename reset-gpios and reset-duration-us to bus-reset-gpios and
> bus-reset-duration-us as requested by Wolfram
> Changes in v4:
> - Add r-by from Krzysztof
> Changes in v3:
> - Rename reset-delay-us to reset-duration-us to better reflect its
> purpose
> - Add default: for reset-duration-us
> - Add description: for reset-gpios
> Changes in v2:
> - Update commit message
> - Add reset-delay-us property
>
> .../devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> index 461d1c9ee3f7..b165d1c4f0b1 100644
> --- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml
> @@ -70,6 +70,16 @@ properties:
> resets:
> maxItems: 1
>
> + bus-reset-gpios:
> + description:
> + GPIO pin providing a common reset for all downstream devices. This GPIO
> + will be asserted then released before the downstream devices are probed.
> + maxItems: 1
> +
> + bus-reset-duration-us:
> + description: Reset duration in us.
> + default: 1
> +
> dmas:
> items:
> - description: RX DMA Channel
> --
> 2.42.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-10-27 9:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 3:31 [PATCH v5 0/2] i2c: mv64xxx: bus-reset-gpios Chris Packham
2023-10-27 3:31 ` [PATCH v5 1/2] dt-bindings: i2c: mv64xxx: add bus-reset-gpios property Chris Packham
2023-10-27 9:09 ` Wolfram Sang [this message]
2023-10-27 11:25 ` Krzysztof Kozlowski
2023-10-27 19:22 ` Rob Herring
2023-10-28 7:51 ` Krzysztof Kozlowski
2023-10-27 3:31 ` [PATCH v5 2/2] i2c: mv64xxx: add an optional " Chris Packham
2023-10-27 8:48 ` Andi Shyti
2023-10-27 11:27 ` Krzysztof Kozlowski
2023-10-27 11:37 ` Krzysztof Kozlowski
2023-10-27 12:55 ` Andi Shyti
2023-10-29 21:02 ` Chris Packham
2023-10-27 15:10 ` Mark Brown
2023-10-29 20:48 ` Chris Packham
2023-10-31 6:01 ` Krzysztof Kozlowski
2023-10-31 19:59 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTt+ZgNe5Y35E/C2@shikoro \
--to=wsa@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.