From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Yang Jihong <yangjihong1@huawei.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf evsel: Rename evsel__increase_rlimit to rlimit__increase_nofile
Date: Fri, 27 Oct 2023 10:35:55 -0300 [thread overview]
Message-ID: <ZTu8u3bgNCOhTx8U@kernel.org> (raw)
In-Reply-To: <3458c302-8c43-51e5-f45b-c18657fa7015@huawei.com>
Em Fri, Oct 27, 2023 at 10:43:32AM +0800, Yang Jihong escreveu:
> Sorry, only rename helper and no function change.
> I didn't consider the scenario that might affect test python.
> I've submitted a fix that can be used if needed:
> https://lore.kernel.org/lkml/20231027023028.1106441-1-yangjihong1@huawei.com/
> Also, can we consider identifying this problem at the stage of compiling the
> perf tool?
Yes, I have:
$ alias m='rm -rf ~/libexec/perf-core/ ; make -k CORESIGHT=1 O=/tmp/build/$(basename $PWD) -C tools/perf install-bin && perf test python'
And use the 'm' alias to build perf.
I also run 'perf test' before sending patches upstream, in addition to:
make -C tools/perf build-test
I encourage everybody to do the same.
Additionally I run a long list of container tests on dozens of distros,
but those should really be running on some CI system :-\
- Arnaldo
next prev parent reply other threads:[~2023-10-27 13:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 3:31 [PATCH] perf evsel: Rename evsel__increase_rlimit to rlimit__increase_nofile Yang Jihong
2023-10-26 17:11 ` Namhyung Kim
2023-10-26 19:47 ` Arnaldo Carvalho de Melo
2023-10-26 22:08 ` Namhyung Kim
2023-10-27 2:43 ` Yang Jihong
2023-10-27 13:35 ` Arnaldo Carvalho de Melo [this message]
2023-10-27 13:33 ` [PATCH 1/1] perf python: Fix binding linkage due to rename and move of evsel__increase_rlimit() Arnaldo Carvalho de Melo
2023-10-30 18:59 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTu8u3bgNCOhTx8U@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yangjihong1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.