From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:907:d043:b0:9d0:bf65:29fa with SMTP id vb3csp330798ejc; Fri, 27 Oct 2023 09:38:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwJJdgMbnESKQQRhg84SnkmBPL8hRLk56ISU3qGdMVRmPb3ovDpr1XF3gJyIfp5anXEbWx X-Received: by 2002:a1f:294b:0:b0:49c:37a1:2358 with SMTP id p72-20020a1f294b000000b0049c37a12358mr3505632vkp.14.1698424720714; Fri, 27 Oct 2023 09:38:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698424720; cv=none; d=google.com; s=arc-20160816; b=jDtTSCNRbCudWX49WQYf0s2TvCabOW9hOoDWU0FrZmv1UM8fhJyrhN26zcPRW8D3Ev ocW3a7moKxvvVBBxh9W2SFluq5cZGADWF+8VKg37+wj4lRK7KFswCQx5EZvV60gUmfgU d220trDPQ2M1yZXz+f/2iKMiLxECyeP18uMsBXJv5EI/6WdMXgIFcoieSe2pKmz5y7RQ Bkuo7YEgOy9mHm8QxFTzSz3hmFM9SEi+w+lTXHvtWSnfRD1X7YqM7ILk36JdP7rnfRG8 Tf7w5DCnuaZudMMMeW0pldj9Xcbu0yGzLyqxTtyp448D64DNDh2Y5B/xm6CYdW/8Wcfp l3XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:user-agent :in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:dkim-signature; bh=1VRcJ5h2CnF28186q/caluBI0qALfY6P/RoKVRjF8sI=; fh=EjLZc6xI5S3B/HizvibtYCMhtqRCsEG4ZG6CBeVjKe8=; b=QNq1nqP0O+sYlkIvwKAVI1X5wewFShGBFwcnzMfzu4obaiQvMYbrvo4O6htEM9/kHF 2ClThRePsUrQHd/Me8laJKLyN8XETLNi0hBMjQ8PwoWjVUojTNemgbeWg9CQohIhg5Tj EHhEVIjv/Kq2aOgfH5HiuIjZQC3vCHSPcKccs5XAKkJlZRp5Y+jA8R8eaamji/kBUJUz f3aU/CpBMII+0CTcswwUatSaW11HPGS8zmz7JwEoluq//RfC+I6k4zw8Nflv0OnJQ/Il kkITrGQ1Wsa1cFy5q7D437mC6yog831A8kSY7TDh+4NY4OKTpsD4vxUmLLVWyPuhetba cp1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QWAAO6R6; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id jp14-20020ad45f8e000000b0065efe331bebsi989353qvb.364.2023.10.27.09.38.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Oct 2023 09:38:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QWAAO6R6; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qwPqt-0002WD-HH; Fri, 27 Oct 2023 12:38:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwPqr-0002Vm-VP for qemu-arm@nongnu.org; Fri, 27 Oct 2023 12:38:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwPqq-0005OL-AO for qemu-arm@nongnu.org; Fri, 27 Oct 2023 12:38:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698424703; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=1VRcJ5h2CnF28186q/caluBI0qALfY6P/RoKVRjF8sI=; b=QWAAO6R6rhjiNLfncJ90KwkCl1A+xOQAftJ0ikmkLI4mmTO3d8crLLY5fdcaLNjvH0Lcob IHg1KK6NOk5oA1CkFjubl9ani4xIifpbTuPfyGY7ziGKes4pPe3ATjcQ/+Rw3T9lyyh/8f 49P9oAB7Tf+LGUEmJ1MEOrt3czOy50I= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-594-NZ56rxFHOt-tDeKLIRVSFw-1; Fri, 27 Oct 2023 12:38:19 -0400 X-MC-Unique: NZ56rxFHOt-tDeKLIRVSFw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 12125185A780; Fri, 27 Oct 2023 16:38:19 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8AE6A1121320; Fri, 27 Oct 2023 16:38:16 +0000 (UTC) Date: Fri, 27 Oct 2023 17:38:14 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Andrea Bolognani Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Peter Maydell , "Dr. David Alan Gilbert" , Eric Blake , BALATON Zoltan , Gerd Hoffmann , "Michael S. Tsirkin" , qemu-arm@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Markus Armbruster , Thomas Huth , Paolo Bonzini Subject: Re: [PATCH v6 09/23] ui/console: allow to override the default VC Message-ID: References: <20231025190818.3278423-1-marcandre.lureau@redhat.com> <20231025190818.3278423-10-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: mbN/BPix6mox On Fri, Oct 27, 2023 at 05:53:19AM -0700, Andrea Bolognani wrote: > On Wed, Oct 25, 2023 at 11:08:03PM +0400, marcandre.lureau@redhat.com wrote: > > If a display is backed by a specialized VC, allow to override the > > default "vc:80Cx24C". For that, set the dpy.type just before creating > > the default serial/parallel/monitor. > > > > As suggested by Paolo, if the display doesn't implement a VC (get_vc() > > returns NULL), use a fallback that will use a muxed console on stdio. > > > > This changes the behaviour of "qemu -display none", to create a muxed > > serial/monitor by default. > > Have you verified that this doesn't break libvirt? We use '-display > none' for every single VM we run. IIUC we're ok as this logic appears to be skipped when -nodefaults is set. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|