Re: [PATCH 01/11] accel/ivpu: Update FW API

[Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>]

Hi

On Fri, Oct 27, 2023 at 08:37:39AM -0600, Jeffrey Hugo wrote:
> On 10/25/2023 3:43 AM, Stanislaw Gruszka wrote:
> > From: Krystian Pradzynski <krystian.pradzynski@linux.intel.com>
> > 
> > Bump boot API to 4.20
> > Bump JSM API to 3.15
> > 
> > Signed-off-by: Krystian Pradzynski <krystian.pradzynski@linux.intel.com>
> > Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> > Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> > ---
<snip>
> >   /*
> > @@ -89,6 +98,14 @@ enum VPU_BOOT_L2_CACHE_CFG_TYPE {
> >   	VPU_BOOT_L2_CACHE_CFG_NUM = 2
> >   };
> > +/** VPU MCA ECC signalling mode. By default, no signalling is used */
> 
> This does not look like valid kernel-doc.  Maybe you wanted "/*" instead?
> 
> > +enum VPU_BOOT_MCA_ECC_SIGNAL_TYPE {
> > +	VPU_BOOT_MCA_ECC_NONE = 0,
> > +	VPU_BOOT_MCA_ECC_CORR = 1,
> > +	VPU_BOOT_MCA_ECC_FATAL = 2,
> > +	VPU_BOOT_MCA_ECC_BOTH = 3
> 
> Personal preference, but having the "=" and the interget values all line up
> vetrically would make this a bit more plesant to look at.

This file came from FW and I'm reluctant to make any changes here, even
formatting. I'll ask if in the future we can get some improvements of
formatting done by scripts or if FW can change their files.

Regards
Stanislaw