From: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: Karol Wachowski <karol.wachowski@linux.intel.com>,
Oded Gabbay <ogabbay@kernel.org>,
Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 07/11] accel/ivpu: Introduce ivpu_ipc_send_receive_active()
Date: Sat, 28 Oct 2023 10:36:19 +0200 [thread overview]
Message-ID: <ZTzIA3+kVl9n/Emj@linux.intel.com> (raw)
In-Reply-To: <bdd18dc1-fb4c-2058-b242-5e311266de5b@quicinc.com>
On Fri, Oct 27, 2023 at 08:49:21AM -0600, Jeffrey Hugo wrote:
> On 10/25/2023 3:43 AM, Stanislaw Gruszka wrote:
> > From: Karol Wachowski <karol.wachowski@linux.intel.com>
> >
> > Split ivpu_ipc_send_receive() implementation to have a version
> > that does not call pm_runtime_resume_and_get(). That implementation
> > can be invoked when device is up and runtime resume is prohibited
> > (for example at the end of boot sequence).
>
> There doesn't seem to be a user for this, which would make the new function
> dead code. Assuming that this new function gets used later in the series,
> it would be clearer to combine this change with that one.
It is used in patch 10. I would prefer not to merge those, since the changes
are not that related. I would reorder this patch just before patch 10 and
add note it's used there.
Regards
Stanislaw
next prev parent reply other threads:[~2023-10-28 8:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 9:43 [PATCH 00/11] accel/ivpu: Update to -next 2023-10-25 Stanislaw Gruszka
2023-10-25 9:43 ` [PATCH 01/11] accel/ivpu: Update FW API Stanislaw Gruszka
[not found] ` <c83b4b50-fb25-6888-deb3-0a1e6a27165d@quicinc.com>
2023-10-28 7:59 ` Stanislaw Gruszka
2023-10-30 14:34 ` Jeffrey Hugo
2023-10-25 9:43 ` [PATCH 02/11] accel/ivpu: Remove unneeded drm_driver dectaration Stanislaw Gruszka
2023-10-25 9:43 ` [PATCH 03/11] accel/ivpu: Add dvfs_mode file to debugfs Stanislaw Gruszka
2023-10-25 9:43 ` [PATCH 04/11] accel/ivpu: Remove reset from power up sequence Stanislaw Gruszka
2023-10-25 9:43 ` [PATCH 05/11] accel/ivpu: Add support for VPU_JOB_FLAGS_NULL_SUBMISSION_MASK Stanislaw Gruszka
2023-10-25 9:43 ` [PATCH 06/11] accel/ivpu: Change test_mode module param to bitmask Stanislaw Gruszka
[not found] ` <e53dabb3-e8ec-b033-60f0-462f6e225e51@quicinc.com>
2023-10-28 8:18 ` Stanislaw Gruszka
2023-10-30 14:05 ` Jeffrey Hugo
2023-10-30 15:07 ` Stanislaw Gruszka
2023-10-25 9:43 ` [PATCH 07/11] accel/ivpu: Introduce ivpu_ipc_send_receive_active() Stanislaw Gruszka
[not found] ` <bdd18dc1-fb4c-2058-b242-5e311266de5b@quicinc.com>
2023-10-28 8:36 ` Stanislaw Gruszka [this message]
2023-10-25 9:43 ` [PATCH 08/11] accel/ivpu: Pass D0i3 residency time to the VPU firmware Stanislaw Gruszka
2023-10-25 9:43 ` [PATCH 09/11] accel/ivpu/40xx: Capture D0i3 entry host and device timestamps Stanislaw Gruszka
2023-10-25 9:43 ` [PATCH 10/11] accel/ivpu: Add support for delayed D0i3 entry message Stanislaw Gruszka
[not found] ` <f45d777c-03eb-fb6b-fa3a-6c19f56e9d17@quicinc.com>
2023-10-28 9:38 ` Stanislaw Gruszka
2023-10-25 9:43 ` [PATCH 11/11] accel/ivpu: Wait for VPU to enter idle state after " Stanislaw Gruszka
[not found] ` <74227a8f-f89f-ed3d-1d39-ad771801c172@quicinc.com>
2023-10-28 8:22 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTzIA3+kVl9n/Emj@linux.intel.com \
--to=stanislaw.gruszka@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=karol.wachowski@linux.intel.com \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.