From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D80D4C4332F for ; Thu, 9 Nov 2023 19:22:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234622AbjKITWI (ORCPT ); Thu, 9 Nov 2023 14:22:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbjKITWH (ORCPT ); Thu, 9 Nov 2023 14:22:07 -0500 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A77B3C11 for ; Thu, 9 Nov 2023 11:22:05 -0800 (PST) Received: from [78.30.43.141] (port=43810 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1AbJ-00G4gK-Ep; Thu, 09 Nov 2023 20:22:03 +0100 Date: Thu, 9 Nov 2023 20:22:00 +0100 From: Pablo Neira Ayuso To: Thomas Haller Cc: NetFilter Subject: Re: [PATCH nft 1/3] parser: don't mark "string" as const Message-ID: References: <20231109190032.669575-1-thaller@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231109190032.669575-1-thaller@redhat.com> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Nov 09, 2023 at 07:59:47PM +0100, Thomas Haller wrote: > The "string" field is allocated, and the bison actions are expected to > take/free them. It's not const, and it should not be freed with free_const(). This ifname_expr_alloc() function does not modify the 'name' argument, this is really const.