From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH] drm/xe: Drop EXECLIST_CONTROL from error state dump
Date: Thu, 9 Nov 2023 15:27:47 -0500 [thread overview]
Message-ID: <ZU1Aw5m2Xd0KSemc@intel.com> (raw)
In-Reply-To: <20231109194606.1835284-2-matthew.d.roper@intel.com>
On Thu, Nov 09, 2023 at 11:46:07AM -0800, Matt Roper wrote:
> EXECLIST_CONTROL ($enginebase + 0x550) is a write-only register; we
> shouldn't be trying to read or report it as part of the device error
> state.
>
> Bspec: 45910, 60335
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/xe/xe_hw_engine.c | 4 ----
> drivers/gpu/drm/xe/xe_hw_engine_types.h | 2 --
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_hw_engine.c b/drivers/gpu/drm/xe/xe_hw_engine.c
> index b5b084590888..e831e63c5e48 100644
> --- a/drivers/gpu/drm/xe/xe_hw_engine.c
> +++ b/drivers/gpu/drm/xe/xe_hw_engine.c
> @@ -704,8 +704,6 @@ xe_hw_engine_snapshot_capture(struct xe_hw_engine *hwe)
> snapshot->reg.ring_execlist_sq_contents_hi =
> hw_engine_mmio_read32(hwe,
> RING_EXECLIST_SQ_CONTENTS_HI(0));
> - snapshot->reg.ring_execlist_control =
> - hw_engine_mmio_read32(hwe, RING_EXECLIST_CONTROL(0));
> snapshot->reg.ring_start = hw_engine_mmio_read32(hwe, RING_START(0));
> snapshot->reg.ring_head =
> hw_engine_mmio_read32(hwe, RING_HEAD(0)) & HEAD_ADDR;
> @@ -765,8 +763,6 @@ void xe_hw_engine_snapshot_print(struct xe_hw_engine_snapshot *snapshot,
> snapshot->reg.ring_execlist_sq_contents_lo);
> drm_printf(p, "\tRING_EXECLIST_SQ_CONTENTS_HI: 0x%08x\n",
> snapshot->reg.ring_execlist_sq_contents_hi);
> - drm_printf(p, "\tRING_EXECLIST_CONTROL: 0x%08x\n",
> - snapshot->reg.ring_execlist_control);
> drm_printf(p, "\tRING_START: 0x%08x\n", snapshot->reg.ring_start);
> drm_printf(p, "\tRING_HEAD: 0x%08x\n", snapshot->reg.ring_head);
> drm_printf(p, "\tRING_TAIL: 0x%08x\n", snapshot->reg.ring_tail);
> diff --git a/drivers/gpu/drm/xe/xe_hw_engine_types.h b/drivers/gpu/drm/xe/xe_hw_engine_types.h
> index 5d4ee2904240..39908dec042a 100644
> --- a/drivers/gpu/drm/xe/xe_hw_engine_types.h
> +++ b/drivers/gpu/drm/xe/xe_hw_engine_types.h
> @@ -183,8 +183,6 @@ struct xe_hw_engine_snapshot {
> u32 ring_execlist_sq_contents_lo;
> /** @ring_execlist_sq_contents_hi: RING_EXECLIST_SQ_CONTENTS + 4 */
> u32 ring_execlist_sq_contents_hi;
> - /** @ring_execlist_control: RING_EXECLIST_CONTROL */
> - u32 ring_execlist_control;
> /** @ring_start: RING_START */
> u32 ring_start;
> /** @ring_head: RING_HEAD */
> --
> 2.41.0
>
next prev parent reply other threads:[~2023-11-09 20:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 19:46 [Intel-xe] [PATCH] drm/xe: Drop EXECLIST_CONTROL from error state dump Matt Roper
2023-11-09 20:27 ` Rodrigo Vivi [this message]
2023-11-09 21:41 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
2023-11-09 21:41 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-11-09 21:42 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-11-09 21:52 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-11-09 21:52 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-11-09 21:53 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-11-09 22:18 ` [Intel-xe] ✓ CI.BAT: " Patchwork
2023-11-09 23:03 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZU1Aw5m2Xd0KSemc@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.