From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Robert Marko <robert.marko@sartura.hr>
Cc: andi.shyti@kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
wsa@kernel.org, codrin.ciubotariu@microchip.com,
stable@vger.kernel.org
Subject: Re: [PATCH] Revert "i2c: pxa: move to generic GPIO recovery"
Date: Fri, 10 Nov 2023 09:44:08 +0000 [thread overview]
Message-ID: <ZU37aJfDpcixU2OZ@shell.armlinux.org.uk> (raw)
In-Reply-To: <20231110093039.190076-1-robert.marko@sartura.hr>
On Fri, Nov 10, 2023 at 10:30:11AM +0100, Robert Marko wrote:
> This reverts commit 0b01392c18b9993a584f36ace1d61118772ad0ca.
>
> Conversion of PXA to generic I2C recovery, makes the I2C bus completely
> lock up if recovery pinctrl is present in the DT and I2C recovery is
> enabled.
>
> So, until the generic I2C recovery can also work with PXA lets revert
> to have working I2C and I2C recovery again.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> Cc: stable@vger.kernel.org # 5.11+
My feels were that this should not have been converted to the generic
recovery as pointed out at the time, so thanks for confirming that it
broke as a result of that conversion, it did indeed break.
Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-11-10 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 9:30 [PATCH] Revert "i2c: pxa: move to generic GPIO recovery" Robert Marko
2023-11-10 9:44 ` Russell King (Oracle) [this message]
2023-11-10 11:30 ` Andi Shyti
2023-11-10 15:03 ` Linus Walleij
2023-11-13 1:53 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZU37aJfDpcixU2OZ@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andi.shyti@kernel.org \
--cc=codrin.ciubotariu@microchip.com \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=stable@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.