Re: [PATCH v6 1/4] perf check: introduce check subcommand

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Fri, Nov 10, 2023 at 11:27:42AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Sat, Oct 21, 2023 at 08:35:23PM +0530, Aditya Gupta escreveu:
> > Acked-by: Namhyung Kim <namhyung@kernel.org>
> > Signed-off-by: Aditya Gupta <adityag@linux.ibm.com>
 
> Right after applying this first patch:
 
> [acme@quaco perf-tools-next]$ m
> make: Entering directory '/home/acme/git/perf-tools-next/tools/perf'
> builtin-check.c:53:56: error: expected ‘}’ before ‘;’ token
>    53 |         FEATURE_SUPPORT("bpf_skeletons", HAVE_BPF_SKEL);
>       |                                                        ^
> builtin-check.c:29:47: note: to match this ‘{’
>    29 | struct feature_support supported_features[] = {
>       |                                               ^
> make[3]: *** [/home/acme/git/perf-tools-next/tools/build/Makefile.build:106: /tmp/build/perf-tools-next/builtin-check.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [Makefile.perf:669: /tmp/build/perf-tools-next/perf-in.o] Error 2
> make[1]: *** [Makefile.perf:242: sub-make] Error 2
> make: *** [Makefile:113: install-bin] Error 2
> make: Leaving directory '/home/acme/git/perf-tools-next/tools/perf'

It was a simple error, please be more careful next time.

I'm testing the rest of the patchset now.

- Arnaldo

diff --git a/tools/perf/builtin-check.c b/tools/perf/builtin-check.c
index 1183983e4352798d..1502804780507b5d 100644
--- a/tools/perf/builtin-check.c
+++ b/tools/perf/builtin-check.c
@@ -50,7 +50,7 @@ struct feature_support supported_features[] = {
 	FEATURE_SUPPORT("zstd", HAVE_ZSTD_SUPPORT),
 	FEATURE_SUPPORT("libpfm4", HAVE_LIBPFM),
 	FEATURE_SUPPORT("libtraceevent", HAVE_LIBTRACEEVENT),
-	FEATURE_SUPPORT("bpf_skeletons", HAVE_BPF_SKEL);
+	FEATURE_SUPPORT("bpf_skeletons", HAVE_BPF_SKEL),
 
 	/* this should remain at end, to know the array end */
 	FEATURE_SUPPORT(NULL, _)