From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Mon, 30 Oct 2023 15:07:30 -0700 Subject: [PATCH v13 12/35] KVM: Prepare for handling only shared mappings in mmu_notifier events In-Reply-To: <077cec97-7920-4d20-8bd3-fe07ab8bcc29@redhat.com> References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-13-seanjc@google.com> <077cec97-7920-4d20-8bd3-fe07ab8bcc29@redhat.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Oct 30, 2023, Paolo Bonzini wrote: > On 10/27/23 20:21, Sean Christopherson wrote: > > @@ -635,6 +635,13 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hva_range(struct kvm *kvm, > > * the second or later invocation of the handler). > > */ > > gfn_range.arg = range->arg; > > + > > + /* > > + * HVA-based notifications aren't relevant to private > > + * mappings as they don't have a userspace mapping. > > It's confusing who "they" is. Maybe > > * HVA-based notifications provide a userspace address, > * and as such are only relevant for shared mappings. Works for me. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11255199BE for ; Mon, 30 Oct 2023 22:07:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="x0D2CKMd" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-1cc1ddb34ccso24871885ad.1 for ; Mon, 30 Oct 2023 15:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698703652; x=1699308452; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EkAABuzKmGyzNibmrxwxoleV2c1qCswFjV4kStA9p5Y=; b=x0D2CKMdVRDjCdVvyLRB1IomNC9NwMSr5OaofYjtbwiOC66AhAp9iaBBftCY8GEYA0 cSgnyj/gfI2rVhcyyzTiIWR5nCNfmNxi1jBReoNzcNpmb6MH1JDeAT3vkwoOwRRQTyqV xR6lcjNqbmx8coNVRspTNHlP47sl+6DFexI6a3QuOa1p1iIQceZgmjjsNYojGTM0lsoP rUoxuvZMg49xnVYGHiDHq/tLUKtC5O595eXY78dRDGOtF5/SJRkp22usrYw93XI+FNcS cxY/d1EA6Bn0Y+uRt8cp5LoQ3bhju+/YrnmfV54BRNCD675Z7/vQVbRcQCaFpZKDCYxP 51sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698703652; x=1699308452; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EkAABuzKmGyzNibmrxwxoleV2c1qCswFjV4kStA9p5Y=; b=REMFtWIMN3HZD2HGn6Vne0gp1oPdnZrJaeJYtoA/RlZb+1EqwfQnxuXujVNqkaKVnK JY2zJy5F2rOsO8D5+rH3JiS92dLhx/7CRwz7JRtbRA4Wts+eawO9GSafsY9hZ9m7gblX yeVAYI5dDDwZU3jCSMtZSCJDFey79k8y1Yz9EiRJiUE3niEy0Dkuda3Mj47bTDu8GBdF OaqfEl/ArVRO6FQBKxgjsI8+B6crNhn1nFVVen79d2ryQtVm9d4TxMMqV5dVRe1Un5KF uau5Y67NBkotv6B4TC1Yi+FeILdMvhLKMS66Me+N6IA3Cpwh2UGW2HCkBes4r85ijiQy Ui8w== X-Gm-Message-State: AOJu0YzEP3l2oELlfpX7RR6qz/27bDIgU8eeLyL3QXVpwzG6EHOkAI0H wt8EW7Fu1L9c8zFtoevonn2vjqpygO8= X-Google-Smtp-Source: AGHT+IHfmttfYISWufdVkZGI1GGv3oPE0CaVU/9uw2yWegmaBLqLOedbYI1/usu4SKmN8TEK3NCdArCTZyE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:ed45:b0:1cc:533e:f52b with SMTP id y5-20020a170902ed4500b001cc533ef52bmr49726plb.4.1698703652255; Mon, 30 Oct 2023 15:07:32 -0700 (PDT) Date: Mon, 30 Oct 2023 15:07:30 -0700 In-Reply-To: <077cec97-7920-4d20-8bd3-fe07ab8bcc29@redhat.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-13-seanjc@google.com> <077cec97-7920-4d20-8bd3-fe07ab8bcc29@redhat.com> Message-ID: Subject: Re: [PATCH v13 12/35] KVM: Prepare for handling only shared mappings in mmu_notifier events From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" On Mon, Oct 30, 2023, Paolo Bonzini wrote: > On 10/27/23 20:21, Sean Christopherson wrote: > > @@ -635,6 +635,13 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hva_range(struct kvm *kvm, > > * the second or later invocation of the handler). > > */ > > gfn_range.arg = range->arg; > > + > > + /* > > + * HVA-based notifications aren't relevant to private > > + * mappings as they don't have a userspace mapping. > > It's confusing who "they" is. Maybe > > * HVA-based notifications provide a userspace address, > * and as such are only relevant for shared mappings. Works for me. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBF8FC4332F for ; Mon, 30 Oct 2023 22:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=cHGFGjq9uCLryCkQGFkXdEebCUdzq3k1XZFnwYqokcE=; b=twsl1BGHy7Itf5NUFP8n6arwNl hvPmvBr1xnaMLTwHp3KgNkF1aSd0KusjxIX0u3eokAzAr1zeDa9dPO2zBtklx+U7px41B+5aZlRck IFexeagjysq0asgb73WhrkS5Fg+yBz1t6kWcECHUe6MGQbtMwaXsZJ6bwQvKygySVd8cvCSdqDz03 9ElVoDd2fxQxbgNqeI5c9DoLxZlwjHIkNdFFeCloPr5mRgHv0oEyz22ssgRccvmcbCuA3RjM7CUMu SVmK5hepFkvr161vSAafR9dKRWyuFK86lK8MzfavKm1OZJZIEsXHx8ugtEu+QstLwD1DZncF7w8Ww LqUkecGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qxaQ4-004766-1U; Mon, 30 Oct 2023 22:07:36 +0000 Received: from mail-pl1-x64a.google.com ([2607:f8b0:4864:20::64a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qxaQ1-00473y-2v for linux-riscv@lists.infradead.org; Mon, 30 Oct 2023 22:07:35 +0000 Received: by mail-pl1-x64a.google.com with SMTP id d9443c01a7336-1cc3ad55c75so13204045ad.0 for ; Mon, 30 Oct 2023 15:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698703652; x=1699308452; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EkAABuzKmGyzNibmrxwxoleV2c1qCswFjV4kStA9p5Y=; b=eqIz1wwoXEHCdg7Dgxz64uSBBbe5ZZxBKeQal6iYXBh0CdnLXtn1/2n+UvoEcXxSuD R2EUklqoPtKObxla6fmyFct7CS7Ra6mWlG4jwhBBUs+xQPBgoXoSfJWLyilrWN9utZzo cWNQRDntkpV3QqyqoDZ1DZRIdZdWghJv28+h0L6CbSdjrVHFJk6r5mpMfYIybjlAxBhg Ht931b0yVkTxyh5Vm5j7GmsRdY6my2zictkaKnRP9MT0HpZEFE/rhuGY+KD9oaFxS9EF tnoGmRt2SOH/XVqyezI389Wmnz+QWbRqttbvyuQcnuj1of5EHif24mDW7uMyXWxcmmL6 FrDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698703652; x=1699308452; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EkAABuzKmGyzNibmrxwxoleV2c1qCswFjV4kStA9p5Y=; b=nJbZoqjtEGjZH4UDDwtWZoe+ToMNmzfKixn9QY0Px+4jotSjV+zTzEwNlEFMHhzeAh du057ZHWJR/5nVM8DW+V14kWcK9zcOVML2QtxY6+6RwHyX8J3BG9MCv1HOjIdErW+zz1 lYH38ecDhpN7fB2D1usi24u0M/veQSAV3KEV6NhDJGxL7WSHVJn9JBfhBAMU4AA6stEm sxyffdsV3J1NMV1jgDWQ5CLy33ey3X3qcIL9OIhZR0joiZiOXPBMJ5ydOVifL94smbEo tccNXQX1YqsunDOYpG00Rgobc32gQwdm3yVx6OD+7IasrhI7+105C5EDLEItL4qXr4Gr F49w== X-Gm-Message-State: AOJu0Yzmhcev1MdO6TygQRyXaAMPmhW9+28vZ9wjwa/pwFXJj9pPQlfb CQJSsI52pShQfA84SxoO4LvgmllGNNs= X-Google-Smtp-Source: AGHT+IHfmttfYISWufdVkZGI1GGv3oPE0CaVU/9uw2yWegmaBLqLOedbYI1/usu4SKmN8TEK3NCdArCTZyE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:ed45:b0:1cc:533e:f52b with SMTP id y5-20020a170902ed4500b001cc533ef52bmr49726plb.4.1698703652255; Mon, 30 Oct 2023 15:07:32 -0700 (PDT) Date: Mon, 30 Oct 2023 15:07:30 -0700 In-Reply-To: <077cec97-7920-4d20-8bd3-fe07ab8bcc29@redhat.com> Mime-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-13-seanjc@google.com> <077cec97-7920-4d20-8bd3-fe07ab8bcc29@redhat.com> Message-ID: Subject: Re: [PATCH v13 12/35] KVM: Prepare for handling only shared mappings in mmu_notifier events From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231030_150733_943979_6F10E70D X-CRM114-Status: GOOD ( 10.47 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Oct 30, 2023, Paolo Bonzini wrote: > On 10/27/23 20:21, Sean Christopherson wrote: > > @@ -635,6 +635,13 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hva_range(struct kvm *kvm, > > * the second or later invocation of the handler). > > */ > > gfn_range.arg = range->arg; > > + > > + /* > > + * HVA-based notifications aren't relevant to private > > + * mappings as they don't have a userspace mapping. > > It's confusing who "they" is. Maybe > > * HVA-based notifications provide a userspace address, > * and as such are only relevant for shared mappings. Works for me. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 083C1C4167B for ; Mon, 30 Oct 2023 22:08:29 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=hxk+/HDz; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SK6pz44Kzz3cYV for ; Tue, 31 Oct 2023 09:08:27 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=hxk+/HDz; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::64a; helo=mail-pl1-x64a.google.com; envelope-from=3jclazqykdkczlhuqjnvvnsl.jvtspubewwj-klcspzaz.vgshiz.vyn@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-pl1-x64a.google.com (mail-pl1-x64a.google.com [IPv6:2607:f8b0:4864:20::64a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SK6nz2nvgz2yG9 for ; Tue, 31 Oct 2023 09:07:35 +1100 (AEDT) Received: by mail-pl1-x64a.google.com with SMTP id d9443c01a7336-1cc3ad55c75so13204005ad.0 for ; Mon, 30 Oct 2023 15:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698703652; x=1699308452; darn=lists.ozlabs.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EkAABuzKmGyzNibmrxwxoleV2c1qCswFjV4kStA9p5Y=; b=hxk+/HDzwAhc8PlY7dsWj9wtWOBQY9H/nOVf3ewbjVqS9tcNbDtsz2C0j5L3Znaxo0 pLpOLx3d20PdCOHIdGJM+ui8UiyRWR9EoEYRkCKFLWgI2ZJlTKcZQyMfoRjQ0SqHJPd0 8mViVqnuy/cFTUDddsIN8zO8pM9+t9xxq46YTFkBc5QZgE+cpi78eAxipLJNVA1xJcxb 2xvXJyFUJcdki2ft22wfUdlkULETKA+Bc7H7cCo/FUeDvBIc3WPBD4sbwfHUkFMkK/iJ STyvLWJq9DK5QoEm8Aq/fbe6MrYZopY+m96Y+nIearNGutPzs9cN8vNBMDE+KxTks5QT io9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698703652; x=1699308452; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EkAABuzKmGyzNibmrxwxoleV2c1qCswFjV4kStA9p5Y=; b=FknL9trDj6wm6DgWxMxszqY/G5QhnBWIudq8Wy+GCUkKmRkSDDQKEbXF6rPXk+tpaB L3v4ykgxmqv+Mm9tXGJZlPP/Y9/P64yst7R2afZ/jNkpfB/+1sRJqzLC1BEpgKaNHkgP xrFhLllumRWRgQHHCijL8OztfW+N5PfBVV/NnZESUjGue2uH9dzRyiFfDaFX+h0nABLq 7jhidjysvMwE6VYDP8E/9rAx5SErdeCuWRc7ibIG6kps1PQNXLgv53HJnAv4DaBECsRa 2WACsbvAUn+jc0Ho0RcDiQaOELubNLWW3wjvG2ftbYMCPmrnpy73+bjf4MVLEmiJ0lvC ZJMw== X-Gm-Message-State: AOJu0Yxa5AiI2GBF+tMA1qb294Dhke9jjCusFN+rYgrayDZiCaH2qNk6 lzMUAkuTroC2o0g0QStvpnpHdmtQhnE= X-Google-Smtp-Source: AGHT+IHfmttfYISWufdVkZGI1GGv3oPE0CaVU/9uw2yWegmaBLqLOedbYI1/usu4SKmN8TEK3NCdArCTZyE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:ed45:b0:1cc:533e:f52b with SMTP id y5-20020a170902ed4500b001cc533ef52bmr49726plb.4.1698703652255; Mon, 30 Oct 2023 15:07:32 -0700 (PDT) Date: Mon, 30 Oct 2023 15:07:30 -0700 In-Reply-To: <077cec97-7920-4d20-8bd3-fe07ab8bcc29@redhat.com> Mime-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-13-seanjc@google.com> <077cec97-7920-4d20-8bd3-fe07ab8bcc29@redhat.com> Message-ID: Subject: Re: [PATCH v13 12/35] KVM: Prepare for handling only shared mappings in mmu_notifier events From: Sean Christopherson To: Paolo Bonzini Content-Type: text/plain; charset="us-ascii" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chao Peng , linux-riscv@lists.infradead.org, Isaku Yamahata , Marc Zyngier , Huacai Chen , Xiaoyao Li , "Matthew Wilcox \(Oracle\)" , Wang , Fuad Tabba , Yu Zhang , Maciej Szmigiero , Albert Ou , Vlastimil Babka , Michael Roth , Ackerley Tng , Alexander Viro , Paul Walmsley , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Isaku Yamahata , Christian Brauner , Quentin Perret , l inux-mips@vger.kernel.org, Oliver Upton , David Matlack , Jarkko Sakkinen , Palmer Dabbelt , "Kirill A . Shutemov" , kvm-riscv@lists.infradead.org, Anup Patel , linux-fsdevel@vger.kernel.org, Liam Merwick , Andrew Morton , Vishal Annapurve , linuxppc-dev@lists.ozlabs.org, Xu Yilun , Anish Moorthy Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Oct 30, 2023, Paolo Bonzini wrote: > On 10/27/23 20:21, Sean Christopherson wrote: > > @@ -635,6 +635,13 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hva_range(struct kvm *kvm, > > * the second or later invocation of the handler). > > */ > > gfn_range.arg = range->arg; > > + > > + /* > > + * HVA-based notifications aren't relevant to private > > + * mappings as they don't have a userspace mapping. > > It's confusing who "they" is. Maybe > > * HVA-based notifications provide a userspace address, > * and as such are only relevant for shared mappings. Works for me. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C022C4332F for ; Mon, 30 Oct 2023 22:08:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=eus7vqSbf/NBF358N6mA658/zjNHos3HilFSxtquQoM=; b=wzLxFM8e0FtZoZT38wrhxewJbj aLhT66ZOq+egKbOldP0r9npXx+MDNbihvEi+TGwmXCRwBO31ok+B6E4I/quPuEkJJ3CULAKS8eyLp +DoUwkFg0P/clpQWssd3ea0cna8DKSksTQpUx56ALh8OP2PFWk+32HzxmdByV6+qi0OPVDDn0nuIt AUbQ5EyWG5uXL93E/m/4bUMqkQIzm8VYY1SjdsGbPEZBZPs4Q6C9QdcyANVZvtuipXWFaaPq9wz5V 3PAembjqFKrpPiCI8/5sRzzorx6IvxNleCUh35tSXmoQ64z05whZV+lMXse/fW+vtpL8m9EGN3wq/ 0GkfuD0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qxaQ5-00476T-0I; Mon, 30 Oct 2023 22:07:37 +0000 Received: from mail-pl1-x649.google.com ([2607:f8b0:4864:20::649]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qxaQ1-00473w-2n for linux-arm-kernel@lists.infradead.org; Mon, 30 Oct 2023 22:07:35 +0000 Received: by mail-pl1-x649.google.com with SMTP id d9443c01a7336-1cc3ad55c75so13203995ad.0 for ; Mon, 30 Oct 2023 15:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698703652; x=1699308452; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EkAABuzKmGyzNibmrxwxoleV2c1qCswFjV4kStA9p5Y=; b=eqIz1wwoXEHCdg7Dgxz64uSBBbe5ZZxBKeQal6iYXBh0CdnLXtn1/2n+UvoEcXxSuD R2EUklqoPtKObxla6fmyFct7CS7Ra6mWlG4jwhBBUs+xQPBgoXoSfJWLyilrWN9utZzo cWNQRDntkpV3QqyqoDZ1DZRIdZdWghJv28+h0L6CbSdjrVHFJk6r5mpMfYIybjlAxBhg Ht931b0yVkTxyh5Vm5j7GmsRdY6my2zictkaKnRP9MT0HpZEFE/rhuGY+KD9oaFxS9EF tnoGmRt2SOH/XVqyezI389Wmnz+QWbRqttbvyuQcnuj1of5EHif24mDW7uMyXWxcmmL6 FrDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698703652; x=1699308452; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EkAABuzKmGyzNibmrxwxoleV2c1qCswFjV4kStA9p5Y=; b=BViNgEdAmLm38L+uxi/3RRZS0cdAuLQ5PQ5xh+dF7FJvk+ZIfcngmqamMZewKK3kdr LKcXvI+R0eIp9DAmzx83lUFz/hoFIoj3Hcx2A9E2MzMFVA3PPC7TKI9URLXjVGd+v3y8 rzuF3QtXPKoMEfKqe5lA26Gloyqpdn5FJ2fAWpIai0Mot02oIjA2ktoH792FJmMfIuWA UcukkQKygFlB/I61JwczrE/dKFQcISG3zFSxhM8GK3Erd5bslpj4cQgxJaX+nkCDPt54 qR6tyPAoP9QUpDyD3wq8DquC8bX0leYLPz4/OWhgQ1tvSWIvxKuu8gmN1HvxvH7vp3fr JwoQ== X-Gm-Message-State: AOJu0YxV48eRIwQm6myeu0l7zg5pWPDrHY2pF0VEhHpe/9Q7zCliNI61 6ywaMJJjlzKnNeIPYV0usLKQbD5asdk= X-Google-Smtp-Source: AGHT+IHfmttfYISWufdVkZGI1GGv3oPE0CaVU/9uw2yWegmaBLqLOedbYI1/usu4SKmN8TEK3NCdArCTZyE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:ed45:b0:1cc:533e:f52b with SMTP id y5-20020a170902ed4500b001cc533ef52bmr49726plb.4.1698703652255; Mon, 30 Oct 2023 15:07:32 -0700 (PDT) Date: Mon, 30 Oct 2023 15:07:30 -0700 In-Reply-To: <077cec97-7920-4d20-8bd3-fe07ab8bcc29@redhat.com> Mime-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-13-seanjc@google.com> <077cec97-7920-4d20-8bd3-fe07ab8bcc29@redhat.com> Message-ID: Subject: Re: [PATCH v13 12/35] KVM: Prepare for handling only shared mappings in mmu_notifier events From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231030_150733_908788_969D1CCB X-CRM114-Status: GOOD ( 11.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 30, 2023, Paolo Bonzini wrote: > On 10/27/23 20:21, Sean Christopherson wrote: > > @@ -635,6 +635,13 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hva_range(struct kvm *kvm, > > * the second or later invocation of the handler). > > */ > > gfn_range.arg = range->arg; > > + > > + /* > > + * HVA-based notifications aren't relevant to private > > + * mappings as they don't have a userspace mapping. > > It's confusing who "they" is. Maybe > > * HVA-based notifications provide a userspace address, > * and as such are only relevant for shared mappings. Works for me. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel