From: Sudeep Holla <sudeep.holla@arm.com>
To: "xinglong.yang" <seanyang230@gmail.com>
Cc: xinglong.yang@cixtech.com, cristian.marussi@arm.com,
Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: arm_scmi:: Add opinion for init fastchannel
Date: Tue, 31 Oct 2023 09:27:48 +0000 [thread overview]
Message-ID: <ZUDIlOBiVT6Aimq7@bogus> (raw)
In-Reply-To: <20231031013601.925009-1-xinglong.yang@cixtech.com>
On Tue, Oct 31, 2023 at 09:36:01AM +0800, xinglong.yang wrote:
> Fastchannel may not be supported by the platform. It is not need to
> init the fastchannel if the fastchannel is not supported.
>
> Signed-off-by: xinglong.yang <xinglong.yang@cixtech.com>
> Change-Id: Id73ab1f37d5a3726243f97beb40c5b2239d65727
> ---
> drivers/firmware/arm_scmi/perf.c | 38 ++++++++++++++++++--------------
> 1 file changed, 21 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
> index ecf5c4de851b..26fa71e2aff8 100644
> --- a/drivers/firmware/arm_scmi/perf.c
> +++ b/drivers/firmware/arm_scmi/perf.c
> @@ -835,7 +839,7 @@ static int scmi_perf_protocol_init(const struct scmi_protocol_handle *ph)
> scmi_perf_describe_levels_get(ph, domain, dom);
>
> if (dom->perf_fastchannels)
If the platform doesn't support fast channels, this must not be set and
any change must not take any effect on your platform. Why are you changing
this then ?
> - scmi_perf_domain_init_fc(ph, domain, &dom->fc_info);
> + scmi_perf_domain_init_fc(ph, domain, dom);
> }
>
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-10-31 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 1:36 [PATCH] firmware: arm_scmi:: Add opinion for init fastchannel xinglong.yang
2023-10-31 8:05 ` Cristian Marussi
2023-11-01 12:23 ` sean yang
2023-10-31 9:27 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUDIlOBiVT6Aimq7@bogus \
--to=sudeep.holla@arm.com \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=seanyang230@gmail.com \
--cc=xinglong.yang@cixtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.