From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBEF8C4332F for ; Wed, 1 Nov 2023 09:32:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4AD5810E685; Wed, 1 Nov 2023 09:32:55 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C16010E684; Wed, 1 Nov 2023 09:32:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698831173; x=1730367173; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BJlnHyxLxxldKBwcbK7SHbsYAPZoprDqJaMrkG5WMX0=; b=a0NE8X4DNE79QxjHm3J6qHrO0t1eE4++FCdkwuuZ7iG/szX/p/XKjdp3 Y/EU58Yj73b/eFlmNhtak0C3ZfQRre5vKPpoUK5ilpK6lh9798PfGH4gc RVR1w4sGIFns2sI+8OQ6twWsCed3u3HcTPgBTlzoKfefFQyQzhTt9V0nY 5AP9etoURd/rbmwmj7RER5UG1JyM2AWmfjmwjOhNqNnHKXRWLVbFKKshU olwfq/qnHIxdBpjM/TDOx0NlcLpSODxDRwnythAaarWcA/giMYb92iKzF vxjEv+mK3evPg7z3f1eDrxliNLMi3QlJmjIUUfxsyPUJQ6lAPC7js8rS4 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="419582765" X-IronPort-AV: E=Sophos;i="6.03,267,1694761200"; d="scan'208";a="419582765" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 02:32:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="710732316" X-IronPort-AV: E=Sophos;i="6.03,267,1694761200"; d="scan'208";a="710732316" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 02:32:49 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC3) (envelope-from ) id 1qy7ag-0000000APOD-1R7V; Wed, 01 Nov 2023 11:32:46 +0200 Date: Wed, 1 Nov 2023 11:32:46 +0200 From: Andy Shevchenko To: Hans de Goede Message-ID: References: <20231024155739.3861342-1-andriy.shevchenko@linux.intel.com> <20231024155739.3861342-7-andriy.shevchenko@linux.intel.com> <16e533e2-81bb-47ba-9e23-460a626bcad7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16e533e2-81bb-47ba-9e23-460a626bcad7@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Subject: Re: [Intel-gfx] [PATCH v2 6/7] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , Rodrigo Vivi , David Airlie Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Oct 31, 2023 at 10:15:52PM +0100, Hans de Goede wrote: > On 10/31/23 17:07, Hans de Goede wrote: > > On 10/24/23 18:11, Andy Shevchenko wrote: > >> On Tue, Oct 24, 2023 at 06:57:38PM +0300, Andy Shevchenko wrote: ... > > As for the CHT support, I have not added that to my tree yet, I would > > prefer to directly test the correct/fixed patch. > > And I hit the "jackpot" on the first device I tried and the code needed > some fixing to actually work, so here is something to fold into v3 to > fix things: Thanks! But let me first send current v3 as it quite differs to v2 in the sense of how I do instantiate GPIO lookup tables. Meanwhile I will look into the change you sent (and hopefully we can incorporate something in v3 for v4). -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34A79C4332F for ; Wed, 1 Nov 2023 09:32:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B051710E684; Wed, 1 Nov 2023 09:32:54 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C16010E684; Wed, 1 Nov 2023 09:32:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698831173; x=1730367173; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BJlnHyxLxxldKBwcbK7SHbsYAPZoprDqJaMrkG5WMX0=; b=a0NE8X4DNE79QxjHm3J6qHrO0t1eE4++FCdkwuuZ7iG/szX/p/XKjdp3 Y/EU58Yj73b/eFlmNhtak0C3ZfQRre5vKPpoUK5ilpK6lh9798PfGH4gc RVR1w4sGIFns2sI+8OQ6twWsCed3u3HcTPgBTlzoKfefFQyQzhTt9V0nY 5AP9etoURd/rbmwmj7RER5UG1JyM2AWmfjmwjOhNqNnHKXRWLVbFKKshU olwfq/qnHIxdBpjM/TDOx0NlcLpSODxDRwnythAaarWcA/giMYb92iKzF vxjEv+mK3evPg7z3f1eDrxliNLMi3QlJmjIUUfxsyPUJQ6lAPC7js8rS4 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="419582765" X-IronPort-AV: E=Sophos;i="6.03,267,1694761200"; d="scan'208";a="419582765" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 02:32:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="710732316" X-IronPort-AV: E=Sophos;i="6.03,267,1694761200"; d="scan'208";a="710732316" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 02:32:49 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC3) (envelope-from ) id 1qy7ag-0000000APOD-1R7V; Wed, 01 Nov 2023 11:32:46 +0200 Date: Wed, 1 Nov 2023 11:32:46 +0200 From: Andy Shevchenko To: Hans de Goede Subject: Re: [PATCH v2 6/7] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back Message-ID: References: <20231024155739.3861342-1-andriy.shevchenko@linux.intel.com> <20231024155739.3861342-7-andriy.shevchenko@linux.intel.com> <16e533e2-81bb-47ba-9e23-460a626bcad7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16e533e2-81bb-47ba-9e23-460a626bcad7@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tvrtko Ursulin , Jani Nikula , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Oct 31, 2023 at 10:15:52PM +0100, Hans de Goede wrote: > On 10/31/23 17:07, Hans de Goede wrote: > > On 10/24/23 18:11, Andy Shevchenko wrote: > >> On Tue, Oct 24, 2023 at 06:57:38PM +0300, Andy Shevchenko wrote: ... > > As for the CHT support, I have not added that to my tree yet, I would > > prefer to directly test the correct/fixed patch. > > And I hit the "jackpot" on the first device I tried and the code needed > some fixing to actually work, so here is something to fold into v3 to > fix things: Thanks! But let me first send current v3 as it quite differs to v2 in the sense of how I do instantiate GPIO lookup tables. Meanwhile I will look into the change you sent (and hopefully we can incorporate something in v3 for v4). -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E5F3C4167D for ; Wed, 1 Nov 2023 09:33:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230086AbjKAJdB (ORCPT ); Wed, 1 Nov 2023 05:33:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbjKAJc7 (ORCPT ); Wed, 1 Nov 2023 05:32:59 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECA6298 for ; Wed, 1 Nov 2023 02:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698831172; x=1730367172; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BJlnHyxLxxldKBwcbK7SHbsYAPZoprDqJaMrkG5WMX0=; b=jmdk+oO3wVTP5QbHrXqlXoxdFSirsDG1HuwTkdmag3kQQYGY9fb0XPrA tpbZGeZttT3x/+bhgs0VK7b5l9JLTqMpA9EHAbdhiWqrh6mi5Xb2Rr3YS WiIagEUjPIG7u8JNShqxiU3EHgfSHHUzgNktbYUCx4xv4i5/zaaaHc3DI SnQXjEvX+zvsr0WaMg2Z/hahV6lHi5fDvQjtwMefHAH59V7/jaLSHZgDg Bl+f2I97bw3r7M/rLIe09IylEQOtR2FkMgNJI4G5EbIoccPg0kozJEIYr Q2TP2Qd0wTaYLr2q9IUQrXVsEavW9EOwVtd5CSPsRc98x/fvm9H393OZC g==; X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="419582763" X-IronPort-AV: E=Sophos;i="6.03,267,1694761200"; d="scan'208";a="419582763" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 02:32:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="710732316" X-IronPort-AV: E=Sophos;i="6.03,267,1694761200"; d="scan'208";a="710732316" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 02:32:49 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC3) (envelope-from ) id 1qy7ag-0000000APOD-1R7V; Wed, 01 Nov 2023 11:32:46 +0200 Date: Wed, 1 Nov 2023 11:32:46 +0200 From: Andy Shevchenko To: Hans de Goede Cc: Jani Nikula , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter Subject: Re: [PATCH v2 6/7] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back Message-ID: References: <20231024155739.3861342-1-andriy.shevchenko@linux.intel.com> <20231024155739.3861342-7-andriy.shevchenko@linux.intel.com> <16e533e2-81bb-47ba-9e23-460a626bcad7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16e533e2-81bb-47ba-9e23-460a626bcad7@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 31, 2023 at 10:15:52PM +0100, Hans de Goede wrote: > On 10/31/23 17:07, Hans de Goede wrote: > > On 10/24/23 18:11, Andy Shevchenko wrote: > >> On Tue, Oct 24, 2023 at 06:57:38PM +0300, Andy Shevchenko wrote: ... > > As for the CHT support, I have not added that to my tree yet, I would > > prefer to directly test the correct/fixed patch. > > And I hit the "jackpot" on the first device I tried and the code needed > some fixing to actually work, so here is something to fold into v3 to > fix things: Thanks! But let me first send current v3 as it quite differs to v2 in the sense of how I do instantiate GPIO lookup tables. Meanwhile I will look into the change you sent (and hopefully we can incorporate something in v3 for v4). -- With Best Regards, Andy Shevchenko