From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Chen Ni <nichen@iscas.ac.cn>,
lee@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: intel-lpss: Fix IRQ check
Date: Wed, 1 Nov 2023 11:38:28 +0200 [thread overview]
Message-ID: <ZUIclOuVocLUUk7_@smile.fi.intel.com> (raw)
In-Reply-To: <20231101070310.GF17433@black.fi.intel.com>
On Wed, Nov 01, 2023 at 09:03:10AM +0200, Mika Westerberg wrote:
> On Wed, Nov 01, 2023 at 06:26:43AM +0000, Chen Ni wrote:
> > platform_get_irq() returns a negative error code to indicating an
> > error. So in intel_lpss_probe() the unset / erroneous IRQ should be
> > returned as is.
> >
> > Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
> There is no need for Fixes tag here.
I said that already in v1 :-)
...
> > - if (!info || !info->mem || info->irq <= 0)
> > + if (!info || !info->mem)
>
> This check (info->irq <= 0) covers both "invalid" interrupt numbers
> (that's the negative errno and 0 as no interrupt) so I don't see how
> this change makes it any better and the changelog does not clarify it
> either.
It makes sense. The IRQ here may not be 0. We should actually fix
the PCI code to guarantee that (platform_get_irq() guarantees that
in platform driver).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-01 9:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 6:26 [PATCH v2] mfd: intel-lpss: Fix IRQ check Chen Ni
2023-11-01 7:03 ` Mika Westerberg
2023-11-01 9:38 ` Andy Shevchenko [this message]
2023-11-01 9:42 ` Andy Shevchenko
2023-11-01 10:47 ` Mika Westerberg
2023-11-02 12:38 ` Andy Shevchenko
2023-11-03 6:41 ` Mika Westerberg
2023-11-03 14:58 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUIclOuVocLUUk7_@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.