From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH 1/3] acpi: property: Let args be NULL in __acpi_node_get_property_reference
Date: Wed, 1 Nov 2023 11:52:46 +0200 [thread overview]
Message-ID: <ZUIf7iyxVRdpgg94@smile.fi.intel.com> (raw)
In-Reply-To: <20231101090737.1148303-2-sakari.ailus@linux.intel.com>
On Wed, Nov 01, 2023 at 11:07:35AM +0200, Sakari Ailus wrote:
> fwnode_get_property_reference() may not be called with args argument NULL
> on ACPI, OF already supports this. Add the missing NULL checks and
> document this.
>
> The purpose is to be able to count the references.
...
> + * @args: Location to store the returned reference with optional arguments (may
> + * be NULL)
I would wrap it as
* @args: Location to store the returned reference with optional arguments
* (may be NULL)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-01 9:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 9:07 [PATCH 0/3] Make fwnode_property_get_reference_args accept NULL args Sakari Ailus
2023-11-01 9:07 ` [PATCH 1/3] acpi: property: Let args be NULL in __acpi_node_get_property_reference Sakari Ailus
2023-11-01 9:52 ` Andy Shevchenko [this message]
2023-11-01 9:07 ` [PATCH 2/3] software node: Let args be NULL in software_node_get_reference_args Sakari Ailus
2023-11-01 9:07 ` [PATCH 3/3] device property: fwnode_property_get_reference allows NULL args now Sakari Ailus
2023-11-01 9:51 ` [PATCH 0/3] Make fwnode_property_get_reference_args accept NULL args Andy Shevchenko
2023-11-01 10:05 ` Sakari Ailus
2023-11-02 12:59 ` Andy Shevchenko
2023-11-01 10:11 ` Sakari Ailus
2023-11-01 18:01 ` Rafael J. Wysocki
2023-11-01 20:28 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUIf7iyxVRdpgg94@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.