From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Thu, 2 Nov 2023 07:41:30 -0700 Subject: [PATCH v13 12/35] KVM: Prepare for handling only shared mappings in mmu_notifier events In-Reply-To: References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-13-seanjc@google.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Nov 02, 2023, Fuad Tabba wrote: > Hi, > > On Fri, Oct 27, 2023 at 7:22?PM Sean Christopherson wrote: > > > > Add flags to "struct kvm_gfn_range" to let notifier events target only > > shared and only private mappings, and write up the existing mmu_notifier > > events to be shared-only (private memory is never associated with a > > userspace virtual address, i.e. can't be reached via mmu_notifiers). > > > > Add two flags so that KVM can handle the three possibilities (shared, > > private, and shared+private) without needing something like a tri-state > > enum. > > > > Link: https://lore.kernel.org/all/ZJX0hk+KpQP0KUyB at google.com > > Signed-off-by: Sean Christopherson > > --- > > include/linux/kvm_host.h | 2 ++ > > virt/kvm/kvm_main.c | 7 +++++++ > > 2 files changed, 9 insertions(+) > > > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > index 96aa930536b1..89c1a991a3b8 100644 > > --- a/include/linux/kvm_host.h > > +++ b/include/linux/kvm_host.h > > @@ -263,6 +263,8 @@ struct kvm_gfn_range { > > gfn_t start; > > gfn_t end; > > union kvm_mmu_notifier_arg arg; > > + bool only_private; > > + bool only_shared; > > If these flags aren't used in this patch series, should this patch be > moved to the other series? If *both* TDX and SNP need this patch, then I think it's probably worth applying it now to make their lives easier. But if only one needs the support, then I completely agree this should be punted to whichever series needs it (this also came up in v11, but we didn't force the issue). Mike, Isaku? > Also, if shared+private is a possibility, doesn't the prefix "only_" > confuse things a bit? I.e., what is shared+private, is it when both > are 0 or when both are 1? I assume it's the former (both are 0), but > it might be clearer. Heh, I was hoping that "only_private && only_shared" would be obviously nonsensical. The only alternative I can think would be to add an enum, e.g. enum { PROCESS_PRIVATE_AND_SHARED, PROCESS_ONLY_PRIVATE, PROCESS_ONLY_SHARED, }; because every other way of expressing the flags either results in more confusion or an unsafe default. I.e. I want zapping only private or only shared to require the caller to explicitly set a non-zero value, which is how I ended up with "only_{private,shared}" as opposed to "process_{private,shared}". From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B76342D611 for ; Thu, 2 Nov 2023 14:41:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tRZssyH7" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-5b1ff96d5b9so14872617b3.1 for ; Thu, 02 Nov 2023 07:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698936092; x=1699540892; darn=lists.linux.dev; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=xhBeRDHIuw2MhHJCiZzpmIP+VopsidfcOzvL++iqJMc=; b=tRZssyH7do9XHOpSodvAE2DfXNI8tn2/mEIpe9kl+1xrkIKsXIW+hi/VbKCPvusFdN 7Yey6o2GoueYpNZ9mnD2ZLl/OGrnhYSC5AoW83fXjxh6LboUr4vfz2MfMr7lYgerWLxk uhfIaTbVVoi9bz8xOcJTFeWGNZtku8R92TvdESjai0v+gWVTzzWYVJ1dAX3KaMKX5anl O7Tsj/Gjpl4Gbr2bLZdbSWEkZ9BZGKNwLeBEr7qGEdiNP/ZR9eKJFuHJzy9hBZtepuAX NfuTVL/hIJuwkkuisezHG/Zw75sDoF2TG/cCeqCtm5ess21WgZDbjmWWsh/9nYos4KX2 t43w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698936092; x=1699540892; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xhBeRDHIuw2MhHJCiZzpmIP+VopsidfcOzvL++iqJMc=; b=MWCSdDv/q+eitKkgFycNnh0pGzDaYMjAyQqS0Euypy5yC5eV0Z4iZyQsQV+aHobS28 Dlz2zLJCcilFiaDK5A6D/gyYPr+JM54x7EMjeQsFLo5O4KrmwxdPOR/DyppZ3hrgNrpx TD5Wt12UmrtLRo43j+oRsfJByZRfuAUrpqIQhpNMd12X7c62tvoQNGnCO5cNqopqFLse iLpe8HVboAzMf8XgQFIHPWAIKJgwmkBnHTH3fBvCHPu5T/b5ospf3DIm5GEHvZ2AnRY8 e2hJcnRbmk+ZtgcmfxzukbXi4EWt1HMgSNkJ9bz3Vd5V62073PITOGN649U+1V2vKVv0 Z5gA== X-Gm-Message-State: AOJu0YynFydMX/MsJD7zJ3OPh5pK8JpOUzWRrSHrRiPOFDap/K9iQBZW dOcUMOsvgdJICjxNCWbWy5Cbki1S8lQ= X-Google-Smtp-Source: AGHT+IGookYXrYm1A+ma3WZO34BPnkwMLXQzWy+6HX4P/l5wwOteWAD0NK2vYdNE8zwnCUE9EMm+eRT161A= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:2fce:0:b0:d9a:f3dc:7d19 with SMTP id v197-20020a252fce000000b00d9af3dc7d19mr331431ybv.11.1698936092597; Thu, 02 Nov 2023 07:41:32 -0700 (PDT) Date: Thu, 2 Nov 2023 07:41:30 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-13-seanjc@google.com> Message-ID: Subject: Re: [PATCH v13 12/35] KVM: Prepare for handling only shared mappings in mmu_notifier events From: Sean Christopherson To: Fuad Tabba Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thu, Nov 02, 2023, Fuad Tabba wrote: > Hi, >=20 > On Fri, Oct 27, 2023 at 7:22=E2=80=AFPM Sean Christopherson wrote: > > > > Add flags to "struct kvm_gfn_range" to let notifier events target only > > shared and only private mappings, and write up the existing mmu_notifie= r > > events to be shared-only (private memory is never associated with a > > userspace virtual address, i.e. can't be reached via mmu_notifiers). > > > > Add two flags so that KVM can handle the three possibilities (shared, > > private, and shared+private) without needing something like a tri-state > > enum. > > > > Link: https://lore.kernel.org/all/ZJX0hk+KpQP0KUyB@google.com > > Signed-off-by: Sean Christopherson > > --- > > include/linux/kvm_host.h | 2 ++ > > virt/kvm/kvm_main.c | 7 +++++++ > > 2 files changed, 9 insertions(+) > > > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > index 96aa930536b1..89c1a991a3b8 100644 > > --- a/include/linux/kvm_host.h > > +++ b/include/linux/kvm_host.h > > @@ -263,6 +263,8 @@ struct kvm_gfn_range { > > gfn_t start; > > gfn_t end; > > union kvm_mmu_notifier_arg arg; > > + bool only_private; > > + bool only_shared; >=20 > If these flags aren't used in this patch series, should this patch be > moved to the other series? If *both* TDX and SNP need this patch, then I think it's probably worth app= lying it now to make their lives easier. But if only one needs the support, then= I completely agree this should be punted to whichever series needs it (this a= lso came up in v11, but we didn't force the issue). Mike, Isaku? > Also, if shared+private is a possibility, doesn't the prefix "only_" > confuse things a bit? I.e., what is shared+private, is it when both > are 0 or when both are 1? I assume it's the former (both are 0), but > it might be clearer. Heh, I was hoping that "only_private && only_shared" would be obviously non= sensical. The only alternative I can think would be to add an enum, e.g. enum { PROCESS_PRIVATE_AND_SHARED, PROCESS_ONLY_PRIVATE, PROCESS_ONLY_SHARED, }; because every other way of expressing the flags either results in more conf= usion or an unsafe default. I.e. I want zapping only private or only shared to r= equire the caller to explicitly set a non-zero value, which is how I ended up with "only_{private,shared}" as opposed to "process_{private,shared}". From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DD9EC4332F for ; Thu, 2 Nov 2023 14:41:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=UIAKUOfaJ1JD7hWvHoS4yTSb3SPHaYEh3UbhQnAt4bA=; b=TwKwmPrSA17CoJpf+aHD86p4LI YNVgVwQUxoQ8qtqcVVTWcdHfyWKPLJYlZ/nAO0RDo+ZJL+hEKiPgk9+fLbpzpwxu1EkGvl87QE8SY z9AcV8xiHmiFE5sGGvw9H1oFVE18CRQ3QYzvfod+SraO5K7iHHhSzJWzZzXWe3jtYfpN3kOkxQo/G wBPmuh1hJ7krYL8F+J3Tk5bIvsKXqJQggw5yJiFLHHAE34CFeSh7Z2ShWVWVQZM2S6I1ZlIhA7j+B 6vUOd62YN/SKeDUSTo+YxdMVjihnmy98uiPk3gxPZ69MZJcxzFTkz8mJ3Ea1l0r5+7rQhJKSM5qRA v1E6I/tQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qyYtC-009fRR-1g; Thu, 02 Nov 2023 14:41:42 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qyYt9-009fPJ-14 for linux-riscv@lists.infradead.org; Thu, 02 Nov 2023 14:41:40 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5b02ed0f886so15048087b3.0 for ; Thu, 02 Nov 2023 07:41:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698936092; x=1699540892; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=xhBeRDHIuw2MhHJCiZzpmIP+VopsidfcOzvL++iqJMc=; b=jHDLGgEyradEzctPSItz/0aLd8njbLRToFgJmy8T2NDoDKVLV3JrhUlAQpmM9A0jMV A3evLxYNyfbBI+mRFA0Ame2lwY7J5UnjRm56w7kfhxyuhyYSEGdj6FyCo0Nw0C5aPlIZ FRVnmrco3yCb7Gj0UQ9hKKu5v5+znAFhjGlLyN8HsM4OqsVUDP0mNEOjOM48xkID6MNV 9qkRxAkoYfqTG7AU1/tyM+A81Ada7IQ/1eg+FrJJIHsPoDIFkWL7hDOZ4INUlWjX4s7a VIcOJzTLC3gDAKPr//LZLPKeUgCTjE5Y7HYNObxSVNykn738/UCel/8DBDe7DsDJyXXr +odQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698936092; x=1699540892; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xhBeRDHIuw2MhHJCiZzpmIP+VopsidfcOzvL++iqJMc=; b=np5t3RUjknLdoi7k7wUPRebcrxzc3UNYkfbbGaOp1wAk/fdG2Ly/NmNfYItwRJuf/K V4m6uSwQG1HTwN5iVxPnHrOa6Xe540htPAo9ai4zReincX4W2dENLP/U3jGfI9xEj8Q8 DF3GFqRb7ZkaXSStoAjDyHzXfhgI2ZQwgAQ1psg5aSsz9slktMZbI0V1gATwzf+wMfSN QbJJ8KG3b6ZIpL64wQq/JgBqqIaVPIyJcK7JDDeraFy1WsWuxVVWubSt8HITxleuATHR uOHl6xHYeC3JJ2mCewUP9gf+ID+aEK6jaORlTBnGRldlfFlN9pVZKoi+7VFwte/Teh4S uz7A== X-Gm-Message-State: AOJu0YwG9wijjyFT8Lkf6ETvCu0MGQ2ux05nAqZQdz7AyYkeMpaO17Bs u6vc6yVn02Z/oEiQSBu0ay1f1XvSYkk= X-Google-Smtp-Source: AGHT+IGookYXrYm1A+ma3WZO34BPnkwMLXQzWy+6HX4P/l5wwOteWAD0NK2vYdNE8zwnCUE9EMm+eRT161A= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:2fce:0:b0:d9a:f3dc:7d19 with SMTP id v197-20020a252fce000000b00d9af3dc7d19mr331431ybv.11.1698936092597; Thu, 02 Nov 2023 07:41:32 -0700 (PDT) Date: Thu, 2 Nov 2023 07:41:30 -0700 In-Reply-To: Mime-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-13-seanjc@google.com> Message-ID: Subject: Re: [PATCH v13 12/35] KVM: Prepare for handling only shared mappings in mmu_notifier events From: Sean Christopherson To: Fuad Tabba Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231102_074139_369599_41298B61 X-CRM114-Status: GOOD ( 24.90 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBOb3YgMDIsIDIwMjMsIEZ1YWQgVGFiYmEgd3JvdGU6Cj4gSGksCj4gCj4gT24gRnJp LCBPY3QgMjcsIDIwMjMgYXQgNzoyMuKAr1BNIFNlYW4gQ2hyaXN0b3BoZXJzb24gPHNlYW5qY0Bn b29nbGUuY29tPiB3cm90ZToKPiA+Cj4gPiBBZGQgZmxhZ3MgdG8gInN0cnVjdCBrdm1fZ2ZuX3Jh bmdlIiB0byBsZXQgbm90aWZpZXIgZXZlbnRzIHRhcmdldCBvbmx5Cj4gPiBzaGFyZWQgYW5kIG9u bHkgcHJpdmF0ZSBtYXBwaW5ncywgYW5kIHdyaXRlIHVwIHRoZSBleGlzdGluZyBtbXVfbm90aWZp ZXIKPiA+IGV2ZW50cyB0byBiZSBzaGFyZWQtb25seSAocHJpdmF0ZSBtZW1vcnkgaXMgbmV2ZXIg YXNzb2NpYXRlZCB3aXRoIGEKPiA+IHVzZXJzcGFjZSB2aXJ0dWFsIGFkZHJlc3MsIGkuZS4gY2Fu J3QgYmUgcmVhY2hlZCB2aWEgbW11X25vdGlmaWVycykuCj4gPgo+ID4gQWRkIHR3byBmbGFncyBz byB0aGF0IEtWTSBjYW4gaGFuZGxlIHRoZSB0aHJlZSBwb3NzaWJpbGl0aWVzIChzaGFyZWQsCj4g PiBwcml2YXRlLCBhbmQgc2hhcmVkK3ByaXZhdGUpIHdpdGhvdXQgbmVlZGluZyBzb21ldGhpbmcg bGlrZSBhIHRyaS1zdGF0ZQo+ID4gZW51bS4KPiA+Cj4gPiBMaW5rOiBodHRwczovL2xvcmUua2Vy bmVsLm9yZy9hbGwvWkpYMGhrK0twUVAwS1V5QkBnb29nbGUuY29tCj4gPiBTaWduZWQtb2ZmLWJ5 OiBTZWFuIENocmlzdG9waGVyc29uIDxzZWFuamNAZ29vZ2xlLmNvbT4KPiA+IC0tLQo+ID4gIGlu Y2x1ZGUvbGludXgva3ZtX2hvc3QuaCB8IDIgKysKPiA+ICB2aXJ0L2t2bS9rdm1fbWFpbi5jICAg ICAgfCA3ICsrKysrKysKPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKQo+ID4K PiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2t2bV9ob3N0LmggYi9pbmNsdWRlL2xpbnV4 L2t2bV9ob3N0LmgKPiA+IGluZGV4IDk2YWE5MzA1MzZiMS4uODljMWE5OTFhM2I4IDEwMDY0NAo+ ID4gLS0tIGEvaW5jbHVkZS9saW51eC9rdm1faG9zdC5oCj4gPiArKysgYi9pbmNsdWRlL2xpbnV4 L2t2bV9ob3N0LmgKPiA+IEBAIC0yNjMsNiArMjYzLDggQEAgc3RydWN0IGt2bV9nZm5fcmFuZ2Ug ewo+ID4gICAgICAgICBnZm5fdCBzdGFydDsKPiA+ICAgICAgICAgZ2ZuX3QgZW5kOwo+ID4gICAg ICAgICB1bmlvbiBrdm1fbW11X25vdGlmaWVyX2FyZyBhcmc7Cj4gPiArICAgICAgIGJvb2wgb25s eV9wcml2YXRlOwo+ID4gKyAgICAgICBib29sIG9ubHlfc2hhcmVkOwo+IAo+IElmIHRoZXNlIGZs YWdzIGFyZW4ndCB1c2VkIGluIHRoaXMgcGF0Y2ggc2VyaWVzLCBzaG91bGQgdGhpcyBwYXRjaCBi ZQo+IG1vdmVkIHRvIHRoZSBvdGhlciBzZXJpZXM/CgpJZiAqYm90aCogVERYIGFuZCBTTlAgbmVl ZCB0aGlzIHBhdGNoLCB0aGVuIEkgdGhpbmsgaXQncyBwcm9iYWJseSB3b3J0aCBhcHBseWluZwpp dCBub3cgdG8gbWFrZSB0aGVpciBsaXZlcyBlYXNpZXIuICBCdXQgaWYgb25seSBvbmUgbmVlZHMg dGhlIHN1cHBvcnQsIHRoZW4gSQpjb21wbGV0ZWx5IGFncmVlIHRoaXMgc2hvdWxkIGJlIHB1bnRl ZCB0byB3aGljaGV2ZXIgc2VyaWVzIG5lZWRzIGl0ICh0aGlzIGFsc28KY2FtZSB1cCBpbiB2MTEs IGJ1dCB3ZSBkaWRuJ3QgZm9yY2UgdGhlIGlzc3VlKS4KCk1pa2UsIElzYWt1PwoKPiBBbHNvLCBp ZiBzaGFyZWQrcHJpdmF0ZSBpcyBhIHBvc3NpYmlsaXR5LCBkb2Vzbid0IHRoZSBwcmVmaXggIm9u bHlfIgo+IGNvbmZ1c2UgdGhpbmdzIGEgYml0PyBJLmUuLCB3aGF0IGlzIHNoYXJlZCtwcml2YXRl LCBpcyBpdCB3aGVuIGJvdGgKPiBhcmUgMCBvciB3aGVuIGJvdGggYXJlIDE/IEkgYXNzdW1lIGl0 J3MgdGhlIGZvcm1lciAoYm90aCBhcmUgMCksIGJ1dAo+IGl0IG1pZ2h0IGJlIGNsZWFyZXIuCgpI ZWgsIEkgd2FzIGhvcGluZyB0aGF0ICJvbmx5X3ByaXZhdGUgJiYgb25seV9zaGFyZWQiIHdvdWxk IGJlIG9idmlvdXNseSBub25zZW5zaWNhbC4KClRoZSBvbmx5IGFsdGVybmF0aXZlIEkgY2FuIHRo aW5rIHdvdWxkIGJlIHRvIGFkZCBhbiBlbnVtLCBlLmcuCgoJZW51bSB7CgkJUFJPQ0VTU19QUklW QVRFX0FORF9TSEFSRUQsCgkJUFJPQ0VTU19PTkxZX1BSSVZBVEUsCgkJUFJPQ0VTU19PTkxZX1NI QVJFRCwKCX07CgpiZWNhdXNlIGV2ZXJ5IG90aGVyIHdheSBvZiBleHByZXNzaW5nIHRoZSBmbGFn cyBlaXRoZXIgcmVzdWx0cyBpbiBtb3JlIGNvbmZ1c2lvbgpvciBhbiB1bnNhZmUgZGVmYXVsdC4g IEkuZS4gSSB3YW50IHphcHBpbmcgb25seSBwcml2YXRlIG9yIG9ubHkgc2hhcmVkIHRvIHJlcXVp cmUKdGhlIGNhbGxlciB0byBleHBsaWNpdGx5IHNldCBhIG5vbi16ZXJvIHZhbHVlLCB3aGljaCBp cyBob3cgSSBlbmRlZCB1cCB3aXRoCiJvbmx5X3twcml2YXRlLHNoYXJlZH0iIGFzIG9wcG9zZWQg dG8gInByb2Nlc3Nfe3ByaXZhdGUsc2hhcmVkfSIuCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlz Y3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F589C4332F for ; Thu, 2 Nov 2023 14:42:27 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=Hae22E3x; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SLmmx69rBz3dFx for ; Fri, 3 Nov 2023 01:42:25 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=Hae22E3x; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::b4a; helo=mail-yb1-xb4a.google.com; envelope-from=3hlvdzqykdmu3plyunrzzrwp.nzxwty5800n-op6wt343.zawlm3.z2r@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SLmm24CjKz2xdh for ; Fri, 3 Nov 2023 01:41:36 +1100 (AEDT) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-da03ef6fc30so1219684276.0 for ; Thu, 02 Nov 2023 07:41:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698936092; x=1699540892; darn=lists.ozlabs.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=xhBeRDHIuw2MhHJCiZzpmIP+VopsidfcOzvL++iqJMc=; b=Hae22E3xe/CERGdU/kKy3hi2vDlyvkXerTB012gnK8ZqzlBKjr3+xvR82N7W7W3MY5 yVmRchpNFP6sJ33Pq43T7V/PHwAVbgs5Re+gPMkUn9OSRlYLCd5DOPd+jB9GWibl7f1g 5anWBRLe+FX2kb8q/OpKHPCRCBacJAfKG1ezHAkpSVik8pPLLJxgA+pSI9uV7jpvrP4b XPq9Uff5zYx1B4YycsGGwagmIyIYGhtR2nektFGiz8IywUbcKHuVoGvh7BwknQior9vd qq6Ef9oS7eXCfWqn8VZYjBjYJFdKAwWesl2Ogr0mp6StjABjxZxCsk56Wl+hN6HJG/Gs YiPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698936092; x=1699540892; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xhBeRDHIuw2MhHJCiZzpmIP+VopsidfcOzvL++iqJMc=; b=NoJKnnFN7FzcQ18az+MG4LYp7pt/m6K0iEY2UDh8+hOJAXmnLiHL2aSGKnhRtXmVz+ QWzgqLaBQOR5XNFE1WG9/J4mjlpZnyGHShX0TAOYA7WGrc1BA90fUnDCNB7YJ+dfMWLu XW+PCJs0ew7FWfLzySuF9TaOwDIipj2Qeb9S0oeoT86cxBk19cqd6jlcTuGgX6HMcVV4 mEjDTJHLqb3DL8vk3cctUokIlxN1yL4L3gTIvvkkjWE8SB0th+rkK6Cs+u4oSg9JGKj1 dNCvmmnpMEsfOCTkt/XBmfYGYLkDej2j28t8Em8N0OsFrRNrCoRcTFyj1SwtDBaMOTbi H9vw== X-Gm-Message-State: AOJu0YzUxK1SAHRWUroI+1DHADGqC/cMvLJDHJ7uh+Y3dbXA1FHEPCdV EpsimVDy489pyG8Y2RxvaNf+0G1e1CI= X-Google-Smtp-Source: AGHT+IGookYXrYm1A+ma3WZO34BPnkwMLXQzWy+6HX4P/l5wwOteWAD0NK2vYdNE8zwnCUE9EMm+eRT161A= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:2fce:0:b0:d9a:f3dc:7d19 with SMTP id v197-20020a252fce000000b00d9af3dc7d19mr331431ybv.11.1698936092597; Thu, 02 Nov 2023 07:41:32 -0700 (PDT) Date: Thu, 2 Nov 2023 07:41:30 -0700 In-Reply-To: Mime-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-13-seanjc@google.com> Message-ID: Subject: Re: [PATCH v13 12/35] KVM: Prepare for handling only shared mappings in mmu_notifier events From: Sean Christopherson To: Fuad Tabba Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chao Peng , linux-riscv@lists.infradead.org, Isaku Yamahata , Marc Zyngier , Huacai Chen , Xiaoyao Li , "Matthew Wilcox \(Oracle\)" , Wang , Vlastimil Babka , Yu Zhang , Maciej Szmigiero , Albert Ou , Michael Roth , Ackerley Tng , Alexander Viro , Paul Walmsley , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Isaku Yamahata , Christian Brauner , Quentin Perret , Liam Merwick , linux-mips@vger.kernel.org, Oliver Upton , David Matlack , Jarkko Sakkinen , Palmer Dabbelt , "Kirill A . Shutemov" , kvm-riscv@lists.infradead.org, Anup Patel , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Andrew Morton , Vishal Annapurve , linuxppc-dev@lists.ozlabs.org, Xu Yilun , Anish Moorthy Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Nov 02, 2023, Fuad Tabba wrote: > Hi, >=20 > On Fri, Oct 27, 2023 at 7:22=E2=80=AFPM Sean Christopherson wrote: > > > > Add flags to "struct kvm_gfn_range" to let notifier events target only > > shared and only private mappings, and write up the existing mmu_notifie= r > > events to be shared-only (private memory is never associated with a > > userspace virtual address, i.e. can't be reached via mmu_notifiers). > > > > Add two flags so that KVM can handle the three possibilities (shared, > > private, and shared+private) without needing something like a tri-state > > enum. > > > > Link: https://lore.kernel.org/all/ZJX0hk+KpQP0KUyB@google.com > > Signed-off-by: Sean Christopherson > > --- > > include/linux/kvm_host.h | 2 ++ > > virt/kvm/kvm_main.c | 7 +++++++ > > 2 files changed, 9 insertions(+) > > > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > > index 96aa930536b1..89c1a991a3b8 100644 > > --- a/include/linux/kvm_host.h > > +++ b/include/linux/kvm_host.h > > @@ -263,6 +263,8 @@ struct kvm_gfn_range { > > gfn_t start; > > gfn_t end; > > union kvm_mmu_notifier_arg arg; > > + bool only_private; > > + bool only_shared; >=20 > If these flags aren't used in this patch series, should this patch be > moved to the other series? If *both* TDX and SNP need this patch, then I think it's probably worth app= lying it now to make their lives easier. But if only one needs the support, then= I completely agree this should be punted to whichever series needs it (this a= lso came up in v11, but we didn't force the issue). Mike, Isaku? > Also, if shared+private is a possibility, doesn't the prefix "only_" > confuse things a bit? I.e., what is shared+private, is it when both > are 0 or when both are 1? I assume it's the former (both are 0), but > it might be clearer. Heh, I was hoping that "only_private && only_shared" would be obviously non= sensical. The only alternative I can think would be to add an enum, e.g. enum { PROCESS_PRIVATE_AND_SHARED, PROCESS_ONLY_PRIVATE, PROCESS_ONLY_SHARED, }; because every other way of expressing the flags either results in more conf= usion or an unsafe default. I.e. I want zapping only private or only shared to r= equire the caller to explicitly set a non-zero value, which is how I ended up with "only_{private,shared}" as opposed to "process_{private,shared}". From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D52DC4332F for ; Thu, 2 Nov 2023 14:42:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=3P9fpg4+PhBcbdSFmD0iNDyI0aPOLg9VhgwWDUKryvI=; b=gGJP3LUSf1jNIz7VYaIbemxAKq xaMlSI9AcR/DjSH02w1gHVsjNSW8Q/Q77Pqp9RzwyVQNWmruaY1VANGAG/bEsNlQjSGPmINPmfeZO hbdtD9pvfzLMGhtF5xHvJcKaj2dO6Gno35/NJEesJNI+GuyiGZ8G15qo6LsxSFAeb5ZCP8OMa6ol0 SWY4wNbQoIkcZdZMguyb0ZmrRVh0vVGULfUJVnKG9fpTlkX9C3xy99EJujuqQpX7uC453bxYkLipF IXViuojYqwF/b2ED8GI5puv+Z4FFd6e9CxSZWegbbxtynCsUM/zeXWfH6Kk987NpsX1xCaBrhJb9D pcMOs9Wg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qyYtE-009fSK-1F; Thu, 02 Nov 2023 14:41:44 +0000 Received: from mail-yb1-xb49.google.com ([2607:f8b0:4864:20::b49]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qyYtB-009fPC-0m for linux-arm-kernel@lists.infradead.org; Thu, 02 Nov 2023 14:41:42 +0000 Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-da03390793fso1188345276.3 for ; Thu, 02 Nov 2023 07:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698936092; x=1699540892; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=xhBeRDHIuw2MhHJCiZzpmIP+VopsidfcOzvL++iqJMc=; b=jHDLGgEyradEzctPSItz/0aLd8njbLRToFgJmy8T2NDoDKVLV3JrhUlAQpmM9A0jMV A3evLxYNyfbBI+mRFA0Ame2lwY7J5UnjRm56w7kfhxyuhyYSEGdj6FyCo0Nw0C5aPlIZ FRVnmrco3yCb7Gj0UQ9hKKu5v5+znAFhjGlLyN8HsM4OqsVUDP0mNEOjOM48xkID6MNV 9qkRxAkoYfqTG7AU1/tyM+A81Ada7IQ/1eg+FrJJIHsPoDIFkWL7hDOZ4INUlWjX4s7a VIcOJzTLC3gDAKPr//LZLPKeUgCTjE5Y7HYNObxSVNykn738/UCel/8DBDe7DsDJyXXr +odQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698936092; x=1699540892; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=xhBeRDHIuw2MhHJCiZzpmIP+VopsidfcOzvL++iqJMc=; b=lNKBlrIWR9TZCmX+21tXJqPmuy4+A8FuXEOKx21DVlEvluB/xABKQxfRbYll7A2rii gUm6ecB3qaeoogJGe2D6swhpg23joqzZyFFO7Ajg+6AjzoHxIsxk7VYO90Z0LzRmrR2q qkPlQebvELcMaTJW4L3n3UIltTxzKuVfOP+Bcw493Yl3cnKoNvNxXQtvLJckGs/mhlDx EWHdWw3x8wqN6s62Izl6Acn3pyfZW1PJt15uuJvgU0BxQyfv3Xn3tONyy83FW/jyivlo KhJtX+UmhmFq/3m+WDfTLQA6ta3KD+GBQTsKOzaOnaCH6UWi+79+7LwVFN/3gMUAxMrD D0HQ== X-Gm-Message-State: AOJu0YzKjtvnMweGe/SnbyrNVU/JpMJwUKa2Y1k9OsHm1cBTykqCYR2S S/BVclUBadGq89rMHC7zg/HuH/ptyFA= X-Google-Smtp-Source: AGHT+IGookYXrYm1A+ma3WZO34BPnkwMLXQzWy+6HX4P/l5wwOteWAD0NK2vYdNE8zwnCUE9EMm+eRT161A= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:2fce:0:b0:d9a:f3dc:7d19 with SMTP id v197-20020a252fce000000b00d9af3dc7d19mr331431ybv.11.1698936092597; Thu, 02 Nov 2023 07:41:32 -0700 (PDT) Date: Thu, 2 Nov 2023 07:41:30 -0700 In-Reply-To: Mime-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-13-seanjc@google.com> Message-ID: Subject: Re: [PATCH v13 12/35] KVM: Prepare for handling only shared mappings in mmu_notifier events From: Sean Christopherson To: Fuad Tabba Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231102_074141_279206_5581A083 X-CRM114-Status: GOOD ( 26.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBOb3YgMDIsIDIwMjMsIEZ1YWQgVGFiYmEgd3JvdGU6Cj4gSGksCj4gCj4gT24gRnJp LCBPY3QgMjcsIDIwMjMgYXQgNzoyMuKAr1BNIFNlYW4gQ2hyaXN0b3BoZXJzb24gPHNlYW5qY0Bn b29nbGUuY29tPiB3cm90ZToKPiA+Cj4gPiBBZGQgZmxhZ3MgdG8gInN0cnVjdCBrdm1fZ2ZuX3Jh bmdlIiB0byBsZXQgbm90aWZpZXIgZXZlbnRzIHRhcmdldCBvbmx5Cj4gPiBzaGFyZWQgYW5kIG9u bHkgcHJpdmF0ZSBtYXBwaW5ncywgYW5kIHdyaXRlIHVwIHRoZSBleGlzdGluZyBtbXVfbm90aWZp ZXIKPiA+IGV2ZW50cyB0byBiZSBzaGFyZWQtb25seSAocHJpdmF0ZSBtZW1vcnkgaXMgbmV2ZXIg YXNzb2NpYXRlZCB3aXRoIGEKPiA+IHVzZXJzcGFjZSB2aXJ0dWFsIGFkZHJlc3MsIGkuZS4gY2Fu J3QgYmUgcmVhY2hlZCB2aWEgbW11X25vdGlmaWVycykuCj4gPgo+ID4gQWRkIHR3byBmbGFncyBz byB0aGF0IEtWTSBjYW4gaGFuZGxlIHRoZSB0aHJlZSBwb3NzaWJpbGl0aWVzIChzaGFyZWQsCj4g PiBwcml2YXRlLCBhbmQgc2hhcmVkK3ByaXZhdGUpIHdpdGhvdXQgbmVlZGluZyBzb21ldGhpbmcg bGlrZSBhIHRyaS1zdGF0ZQo+ID4gZW51bS4KPiA+Cj4gPiBMaW5rOiBodHRwczovL2xvcmUua2Vy bmVsLm9yZy9hbGwvWkpYMGhrK0twUVAwS1V5QkBnb29nbGUuY29tCj4gPiBTaWduZWQtb2ZmLWJ5 OiBTZWFuIENocmlzdG9waGVyc29uIDxzZWFuamNAZ29vZ2xlLmNvbT4KPiA+IC0tLQo+ID4gIGlu Y2x1ZGUvbGludXgva3ZtX2hvc3QuaCB8IDIgKysKPiA+ICB2aXJ0L2t2bS9rdm1fbWFpbi5jICAg ICAgfCA3ICsrKysrKysKPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKQo+ID4K PiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2t2bV9ob3N0LmggYi9pbmNsdWRlL2xpbnV4 L2t2bV9ob3N0LmgKPiA+IGluZGV4IDk2YWE5MzA1MzZiMS4uODljMWE5OTFhM2I4IDEwMDY0NAo+ ID4gLS0tIGEvaW5jbHVkZS9saW51eC9rdm1faG9zdC5oCj4gPiArKysgYi9pbmNsdWRlL2xpbnV4 L2t2bV9ob3N0LmgKPiA+IEBAIC0yNjMsNiArMjYzLDggQEAgc3RydWN0IGt2bV9nZm5fcmFuZ2Ug ewo+ID4gICAgICAgICBnZm5fdCBzdGFydDsKPiA+ICAgICAgICAgZ2ZuX3QgZW5kOwo+ID4gICAg ICAgICB1bmlvbiBrdm1fbW11X25vdGlmaWVyX2FyZyBhcmc7Cj4gPiArICAgICAgIGJvb2wgb25s eV9wcml2YXRlOwo+ID4gKyAgICAgICBib29sIG9ubHlfc2hhcmVkOwo+IAo+IElmIHRoZXNlIGZs YWdzIGFyZW4ndCB1c2VkIGluIHRoaXMgcGF0Y2ggc2VyaWVzLCBzaG91bGQgdGhpcyBwYXRjaCBi ZQo+IG1vdmVkIHRvIHRoZSBvdGhlciBzZXJpZXM/CgpJZiAqYm90aCogVERYIGFuZCBTTlAgbmVl ZCB0aGlzIHBhdGNoLCB0aGVuIEkgdGhpbmsgaXQncyBwcm9iYWJseSB3b3J0aCBhcHBseWluZwpp dCBub3cgdG8gbWFrZSB0aGVpciBsaXZlcyBlYXNpZXIuICBCdXQgaWYgb25seSBvbmUgbmVlZHMg dGhlIHN1cHBvcnQsIHRoZW4gSQpjb21wbGV0ZWx5IGFncmVlIHRoaXMgc2hvdWxkIGJlIHB1bnRl ZCB0byB3aGljaGV2ZXIgc2VyaWVzIG5lZWRzIGl0ICh0aGlzIGFsc28KY2FtZSB1cCBpbiB2MTEs IGJ1dCB3ZSBkaWRuJ3QgZm9yY2UgdGhlIGlzc3VlKS4KCk1pa2UsIElzYWt1PwoKPiBBbHNvLCBp ZiBzaGFyZWQrcHJpdmF0ZSBpcyBhIHBvc3NpYmlsaXR5LCBkb2Vzbid0IHRoZSBwcmVmaXggIm9u bHlfIgo+IGNvbmZ1c2UgdGhpbmdzIGEgYml0PyBJLmUuLCB3aGF0IGlzIHNoYXJlZCtwcml2YXRl LCBpcyBpdCB3aGVuIGJvdGgKPiBhcmUgMCBvciB3aGVuIGJvdGggYXJlIDE/IEkgYXNzdW1lIGl0 J3MgdGhlIGZvcm1lciAoYm90aCBhcmUgMCksIGJ1dAo+IGl0IG1pZ2h0IGJlIGNsZWFyZXIuCgpI ZWgsIEkgd2FzIGhvcGluZyB0aGF0ICJvbmx5X3ByaXZhdGUgJiYgb25seV9zaGFyZWQiIHdvdWxk IGJlIG9idmlvdXNseSBub25zZW5zaWNhbC4KClRoZSBvbmx5IGFsdGVybmF0aXZlIEkgY2FuIHRo aW5rIHdvdWxkIGJlIHRvIGFkZCBhbiBlbnVtLCBlLmcuCgoJZW51bSB7CgkJUFJPQ0VTU19QUklW QVRFX0FORF9TSEFSRUQsCgkJUFJPQ0VTU19PTkxZX1BSSVZBVEUsCgkJUFJPQ0VTU19PTkxZX1NI QVJFRCwKCX07CgpiZWNhdXNlIGV2ZXJ5IG90aGVyIHdheSBvZiBleHByZXNzaW5nIHRoZSBmbGFn cyBlaXRoZXIgcmVzdWx0cyBpbiBtb3JlIGNvbmZ1c2lvbgpvciBhbiB1bnNhZmUgZGVmYXVsdC4g IEkuZS4gSSB3YW50IHphcHBpbmcgb25seSBwcml2YXRlIG9yIG9ubHkgc2hhcmVkIHRvIHJlcXVp cmUKdGhlIGNhbGxlciB0byBleHBsaWNpdGx5IHNldCBhIG5vbi16ZXJvIHZhbHVlLCB3aGljaCBp cyBob3cgSSBlbmRlZCB1cCB3aXRoCiJvbmx5X3twcml2YXRlLHNoYXJlZH0iIGFzIG9wcG9zZWQg dG8gInByb2Nlc3Nfe3ByaXZhdGUsc2hhcmVkfSIuCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==