From: Kevin Wolf <kwolf@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Markus Armbruster <armbru@redhat.com>,
Luc Michel <luc.michel@amd.com>,
Daniel Henrique Barboza <dbarboza@ventanamicro.com>,
Alistair Francis <alistair.francis@wdc.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Bernhard Beschow <shentey@gmail.com>,
qemu-ppc@nongnu.org,
"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH 2/5] hw/ppc/e500: Declare CPU QOM types using DEFINE_TYPES() macro
Date: Thu, 2 Nov 2023 11:58:44 +0100 [thread overview]
Message-ID: <ZUOA5ErSwvu9xQFi@redhat.com> (raw)
In-Reply-To: <20231030143957.82988-3-philmd@linaro.org>
Am 30.10.2023 um 15:39 hat Philippe Mathieu-Daudé geschrieben:
> When multiple QOM types are registered in the same file,
> it is simpler to use the the DEFINE_TYPES() macro. In
> particular because type array declared with such macro
> are easier to review.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> I'm going to do that for each file I modify, so eventually
> we'll get all converted.
This is probably a standard commit message that you used for every
conversion? Maybe it should be changed here because I only see a single
QOM type in the patch.
Kevin
next prev parent reply other threads:[~2023-11-02 10:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 14:39 [RFC PATCH 0/5] hw/ppc/e500: Pass array of CPUs as array of canonical QOM paths Philippe Mathieu-Daudé
2023-10-30 14:39 ` [PATCH 1/5] qdev: Add qdev_prop_set_array() Philippe Mathieu-Daudé
2023-10-30 14:39 ` [PATCH 2/5] hw/ppc/e500: Declare CPU QOM types using DEFINE_TYPES() macro Philippe Mathieu-Daudé
2023-10-31 21:01 ` Daniel Henrique Barboza
2023-11-02 10:58 ` Kevin Wolf [this message]
2023-10-30 14:39 ` [PATCH 3/5] hw/ppc/e500: QOM-attach CPUs to the machine container Philippe Mathieu-Daudé
2023-10-31 21:01 ` Daniel Henrique Barboza
2023-11-03 7:40 ` Markus Armbruster
2023-11-03 11:09 ` Philippe Mathieu-Daudé
2023-11-03 16:24 ` Markus Armbruster
2023-10-30 14:39 ` [PATCH 4/5] hw/ppc/e500: Inline sysbus_create_simple(E500_SPIN) Philippe Mathieu-Daudé
2023-10-31 21:03 ` Daniel Henrique Barboza
2023-10-30 14:39 ` [RFC PATCH 5/5] hw/ppc/e500: Pass array of CPUs as array of canonical QOM paths Philippe Mathieu-Daudé
2023-10-31 21:16 ` Daniel Henrique Barboza
2023-11-02 7:33 ` Philippe Mathieu-Daudé
2023-11-03 8:03 ` Markus Armbruster
2023-10-31 21:49 ` [RFC PATCH 0/5] " Daniel Henrique Barboza
2023-11-02 7:49 ` Philippe Mathieu-Daudé
2023-11-03 14:45 ` Daniel Henrique Barboza
2023-11-02 7:56 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUOA5ErSwvu9xQFi@redhat.com \
--to=kwolf@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dbarboza@ventanamicro.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=luc.michel@amd.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=shentey@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.