From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEEAEC4332F for ; Thu, 2 Nov 2023 11:14:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229654AbjKBLO6 (ORCPT ); Thu, 2 Nov 2023 07:14:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229728AbjKBLO5 (ORCPT ); Thu, 2 Nov 2023 07:14:57 -0400 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80ADCE7 for ; Thu, 2 Nov 2023 04:14:51 -0700 (PDT) Received: from [78.30.35.151] (port=54810 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qyVev-008aIs-7w; Thu, 02 Nov 2023 12:14:49 +0100 Date: Thu, 2 Nov 2023 12:14:44 +0100 From: Pablo Neira Ayuso To: Thomas Haller Cc: NetFilter , fw@strlen.de Subject: Re: [PATCH nft v2 4/7] build: no recursive make for "files/**/Makefile.am" Message-ID: References: <20231019130057.2719096-1-thaller@redhat.com> <20231019130057.2719096-5-thaller@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231019130057.2719096-5-thaller@redhat.com> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Oct 19, 2023 at 03:00:03PM +0200, Thomas Haller wrote: > diff --git a/Makefile.am b/Makefile.am > index 8b8de7bd141a..83f25dd8574b 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -2,6 +2,8 @@ ACLOCAL_AMFLAGS = -I m4 > > EXTRA_DIST = > > +############################################################################### This marker shows that this Makefile.am is really getting too big. Can we find a middle point? I understand that a single Makefile for something as little as examples/Makefile.am is probably too much. No revert please, something incremental, otherwise this looks like iptables' Makefile. Thanks.