From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Thomas Haller <thaller@redhat.com>
Cc: NetFilter <netfilter-devel@vger.kernel.org>, fw@strlen.de
Subject: Re: [PATCH nft v2 4/7] build: no recursive make for "files/**/Makefile.am"
Date: Thu, 2 Nov 2023 12:30:32 +0100 [thread overview]
Message-ID: <ZUOIWNT3sjmqd8EM@calendula> (raw)
In-Reply-To: <ZUOEpOU96ai+dmT7@calendula>
On Thu, Nov 02, 2023 at 12:14:49PM +0100, Pablo Neira Ayuso wrote:
> On Thu, Oct 19, 2023 at 03:00:03PM +0200, Thomas Haller wrote:
> > diff --git a/Makefile.am b/Makefile.am
> > index 8b8de7bd141a..83f25dd8574b 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -2,6 +2,8 @@ ACLOCAL_AMFLAGS = -I m4
> >
> > EXTRA_DIST =
> >
> > +###############################################################################
>
> This marker shows that this Makefile.am is really getting too big.
>
> Can we find a middle point?
>
> I understand that a single Makefile for something as little as
> examples/Makefile.am is probably too much.
>
> No revert please, something incremental, otherwise this looks like
> iptables' Makefile.
Correction: Actually iptables' Makefiles show a better balance in how
things are split accross Makefiles, with some possibilities to
consolidate things but it looks much better these days.
next prev parent reply other threads:[~2023-11-02 11:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 12:59 [PATCH nft v2 0/7] no recursive make Thomas Haller
2023-10-19 13:00 ` [PATCH nft v2 1/7] gitignore: ignore ".dirstamp" files Thomas Haller
2023-10-19 13:00 ` [PATCH nft v2 2/7] build: no recursive-make for "include/**/Makefile.am" Thomas Haller
2023-10-19 13:00 ` [PATCH nft v2 3/7] build: no recursive make for "py/Makefile.am" Thomas Haller
2023-10-19 13:00 ` [PATCH nft v2 4/7] build: no recursive make for "files/**/Makefile.am" Thomas Haller
2023-11-02 11:14 ` Pablo Neira Ayuso
2023-11-02 11:30 ` Pablo Neira Ayuso [this message]
2023-11-02 14:03 ` Thomas Haller
2023-11-02 16:05 ` Pablo Neira Ayuso
2023-11-02 16:53 ` Thomas Haller
2023-11-03 11:37 ` Sam James
2023-11-03 12:05 ` Pablo Neira Ayuso
2023-11-03 12:21 ` Pablo Neira Ayuso
2023-10-19 13:00 ` [PATCH nft v2 5/7] build: no recursive make for "src/Makefile.am" Thomas Haller
2023-10-19 13:00 ` [PATCH nft v2 6/7] build: no recursive make for "examples/Makefile.am" Thomas Haller
2023-10-19 13:00 ` [PATCH nft v2 7/7] build: no recursive make for "doc/Makefile.am" Thomas Haller
2023-11-02 11:07 ` [PATCH nft v2 0/7] no recursive make Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUOIWNT3sjmqd8EM@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.