From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Joshua Watt <JPEWhacker@gmail.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH v2] classes/image-oci: Map image architecture correctly
Date: Fri, 3 Nov 2023 03:25:49 +0000 [thread overview]
Message-ID: <ZURoPepW3tQ2LZxE@gmail.com> (raw)
In-Reply-To: <20231030190802.1275280-1-JPEWhacker@gmail.com>
merged to master-next
With any luck, I'll complete my release testing and master-next
will become master shortly
Bruce
In message: [meta-virtualization][PATCH v2] classes/image-oci: Map image architecture correctly
on 30/10/2023 Joshua Watt wrote:
> OCI requires that the architecture [1] be a valid GOARCH [2]. To
> correctly perform this mapping, use the go library code from OE core.
>
> [1]: https://github.com/opencontainers/image-spec/blob/main/config.md#properties
> [2]: https://go.dev/doc/install/source#environment
>
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---
> classes/image-oci.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/classes/image-oci.bbclass b/classes/image-oci.bbclass
> index 9ddb88b..0ec5c48 100644
> --- a/classes/image-oci.bbclass
> +++ b/classes/image-oci.bbclass
> @@ -52,7 +52,7 @@ OCI_IMAGE_AUTHOR_EMAIL ?= "${PATCH_GIT_USER_EMAIL}"
> OCI_IMAGE_TAG ?= "latest"
> OCI_IMAGE_RUNTIME_UID ?= ""
>
> -OCI_IMAGE_ARCH ?= "${TARGET_ARCH}"
> +OCI_IMAGE_ARCH ?= "${@oe.go.map_arch(d.getVar('TARGET_ARCH'))}"
> OCI_IMAGE_SUBARCH ?= "${@oci_map_subarch(d.getVar('TARGET_ARCH'), d.getVar('TUNE_FEATURES'), d)}"
>
> OCI_IMAGE_ENTRYPOINT ?= "sh"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8408): https://lists.yoctoproject.org/g/meta-virtualization/message/8408
> Mute This Topic: https://lists.yoctoproject.org/mt/102282594/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
next prev parent reply other threads:[~2023-11-03 3:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 21:26 [meta-virtualization][PATCH] classes/image-oci: Map x86_64 -> amd64 Joshua Watt
2023-10-17 1:35 ` Bruce Ashfield
2023-10-17 13:46 ` Joshua Watt
2023-10-17 14:01 ` Bruce Ashfield
2023-10-30 19:08 ` [meta-virtualization][PATCH v2] classes/image-oci: Map image architecture correctly Joshua Watt
2023-11-03 3:25 ` Bruce Ashfield [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-07 10:37 Ross Burton
2023-11-07 13:00 ` Bruce Ashfield
2023-11-07 14:51 ` Ross Burton
2023-11-07 15:31 ` Bruce Ashfield
2023-11-07 15:33 ` Joshua Watt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZURoPepW3tQ2LZxE@gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=JPEWhacker@gmail.com \
--cc=meta-virtualization@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.