From: Stephan Gerhold <stephan@gerhold.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Nishanth Menon <nm@ti.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Viresh Kumar <vireshk@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Stephan Gerhold <stephan.gerhold@kernkonzept.com>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 0/3] OPP: Simplify required-opp handling
Date: Fri, 3 Nov 2023 10:24:08 +0100 [thread overview]
Message-ID: <ZUS8OC6tY4sxS5RA@gerhold.net> (raw)
In-Reply-To: <20231103052854.bc7jqaubc5uj6ncj@vireshk-i7>
On Fri, Nov 03, 2023 at 10:58:54AM +0530, Viresh Kumar wrote:
> On 30-10-23, 15:54, Viresh Kumar wrote:
> > I wasn't able to test this locally (despite trying to hack it around) and need
> > help from someone who is `virt_devs` field of `struct dev_pm_opp_config`.
> >
> > Pushed here:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git opp/required-opps
> >
> > V1->V2:
> > - Support opp-level 0, drop vote i.e..
> > - Fix OPP pointer while calling dev_pm_opp_set_opp() recursively.
> > - Minor checks and fixes.
> > - Add Reviewed-by from Ulf.
>
> Stephan, Ulf,
>
> Any feedback on this before I merge it ?
>
Sorry for the delay. I tested this successfully on the MSM8909 board on
Wednesday (with the single genpd, and without opp-level 0 there), but
until now didn't find time to test it on the MSM8916 board with the
multiple genpds and the opp-level 0.
The opp-level 0 works fine now, thanks for fixing that!
The warning in _link_required_opps() when using the parent genpd setup
[1] is still present though. Given that this setup is an existing
feature in the genpd core I would appreciate if we try to find a
solution before merging this patch set. It's kind of a regression
otherwise since the warning isn't present without this patch set.
Maybe someone else is already actively using such a setup.
Thanks!
Stephan
[1]: https://lore.kernel.org/linux-pm/ZTkciw5AwufxQYnB@gerhold.net/
next prev parent reply other threads:[~2023-11-03 9:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 10:24 [PATCH V2 0/3] OPP: Simplify required-opp handling Viresh Kumar
2023-10-30 10:24 ` [PATCH V2 1/3] OPP: Level zero is valid Viresh Kumar
2023-10-30 18:47 ` Konrad Dybcio
2023-10-31 5:26 ` Viresh Kumar
2023-10-31 10:07 ` Konrad Dybcio
2023-11-06 15:41 ` Ulf Hansson
2023-10-30 10:24 ` [PATCH V2 2/3] OPP: Use _set_opp_level() for single genpd case Viresh Kumar
2023-10-30 10:24 ` [PATCH V2 3/3] OPP: Call dev_pm_opp_set_opp() for required OPPs Viresh Kumar
2023-11-03 5:28 ` [PATCH V2 0/3] OPP: Simplify required-opp handling Viresh Kumar
2023-11-03 9:20 ` Ulf Hansson
2023-11-03 9:24 ` Stephan Gerhold [this message]
2023-11-03 9:27 ` Viresh Kumar
2023-11-16 10:43 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUS8OC6tY4sxS5RA@gerhold.net \
--to=stephan@gerhold.net \
--cc=konrad.dybcio@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=stephan.gerhold@kernkonzept.com \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.