From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netfilter-devel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D2C66C4332F
	for <netfilter-devel@archiver.kernel.org>; Fri,  3 Nov 2023 11:30:36 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230090AbjKCLah (ORCPT
        <rfc822;netfilter-devel@archiver.kernel.org>);
        Fri, 3 Nov 2023 07:30:37 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42712 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229960AbjKCLaf (ORCPT
        <rfc822;netfilter-devel@vger.kernel.org>);
        Fri, 3 Nov 2023 07:30:35 -0400
Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCB511BC
        for <netfilter-devel@vger.kernel.org>; Fri,  3 Nov 2023 04:30:26 -0700 (PDT)
Received: from [78.30.35.151] (port=58642 helo=gnumonks.org)
        by ganesha.gnumonks.org with esmtpsa  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
        (Exim 4.94.2)
        (envelope-from <pablo@gnumonks.org>)
        id 1qysNY-00Ecel-8K; Fri, 03 Nov 2023 12:30:25 +0100
Date:   Fri, 3 Nov 2023 12:30:19 +0100
From:   Pablo Neira Ayuso <pablo@netfilter.org>
To:     Thomas Haller <thaller@redhat.com>
Cc:     NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nft 1/6] gitignore: ignore build artifacts from top level
 file
Message-ID: <ZUTZy09Y+FyQjA6e@calendula>
References: <20231103111102.2801624-1-thaller@redhat.com>
 <20231103111102.2801624-2-thaller@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231103111102.2801624-2-thaller@redhat.com>
Precedence: bulk
List-ID: <netfilter-devel.vger.kernel.org>
X-Mailing-List: netfilter-devel@vger.kernel.org

On Fri, Nov 03, 2023 at 12:05:43PM +0100, Thomas Haller wrote:
> I don't think that having multiple .gitignore files for a small project
> like nftables is best. Anyway. The build artifacts like "*.o" will not
> only be found under "src/". Move those patterns.
> 
> Signed-off-by: Thomas Haller <thaller@redhat.com>
> ---
>  .gitignore     | 7 ++++++-
>  src/.gitignore | 5 -----
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/.gitignore b/.gitignore
> index a62e31f31c6b..51429020ceb6 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,6 +1,11 @@
> -# Generated by autoconf/configure/automake
> +# Generated by autoconf/configure/automake/make
>  *.m4
> +*.la
> +*.lo
> +*.o
> +.deps/
>  .dirstamp
> +.libs/
>  Makefile
>  Makefile.in
>  stamp-h1
> diff --git a/src/.gitignore b/src/.gitignore
> index 2d907425cbb0..f34105c6cda4 100644
> --- a/src/.gitignore
> +++ b/src/.gitignore
> @@ -1,8 +1,3 @@
> -*.la
> -*.lo
> -*.o
> -.deps/
> -.libs/

Please, move things where they used to be.

>  nft
>  parser_bison.c
>  parser_bison.h
> -- 
> 2.41.0
>