From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC81C4332F for ; Fri, 3 Nov 2023 16:47:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbjKCQrI (ORCPT ); Fri, 3 Nov 2023 12:47:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230148AbjKCQrI (ORCPT ); Fri, 3 Nov 2023 12:47:08 -0400 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AEA3FB for ; Fri, 3 Nov 2023 09:47:04 -0700 (PDT) Received: from [78.30.35.151] (port=35928 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qyxK0-00FuHp-F8; Fri, 03 Nov 2023 17:47:02 +0100 Date: Fri, 3 Nov 2023 17:46:59 +0100 From: Pablo Neira Ayuso To: Thomas Haller Cc: NetFilter Subject: Re: [PATCH nft v3 2/2] json: drop warning on stderr for missing json() hook in stmt_print_json() Message-ID: References: <20231103162937.3352069-1-thaller@redhat.com> <20231103162937.3352069-3-thaller@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231103162937.3352069-3-thaller@redhat.com> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Fri, Nov 03, 2023 at 05:25:14PM +0100, Thomas Haller wrote: > diff --git a/src/statement.c b/src/statement.c > index f5176e6d87f9..d52b01b9099a 100644 > --- a/src/statement.c > +++ b/src/statement.c > @@ -141,6 +141,7 @@ static const struct stmt_ops chain_stmt_ops = { > .type = STMT_CHAIN, > .name = "chain", > .print = chain_stmt_print, > + .json = NULL, /* BUG: must be implemented! */ This is a bit starting the house from the roof. Better fix this first, so this ugly patch does not need to be applied.