From: Dave Chinner <david@fromorbit.com>
To: "Holger Hoffstätte" <holger@applied-asynchrony.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: XFS_DEBUG got enabled by default in 6.6
Date: Mon, 6 Nov 2023 09:40:07 +1100 [thread overview]
Message-ID: <ZUgZxy9d+ICGLWUK@dread.disaster.area> (raw)
In-Reply-To: <308d32cc-4451-ad70-53bc-b41275023e45@applied-asynchrony.com>
On Sun, Nov 05, 2023 at 07:03:55PM +0100, Holger Hoffstätte wrote:
> Hello,
>
> I recently updated to 6.6 and was surprised to see that XFS_DEBUG suddenly
> got enabled by default.
It should not be enabled by default - XFS_ONLINE_SCRUB defaults to
"n" and so XFS_ONLINE_SCRUB_STATS should not be enabled nor should
it be selecting XFS_DEBUG. So to see this, you have to turn on
XFS_ONLINE_SCRUB first....
> This was apparently caused by commit d7a74cad8f45
> ("xfs: track usage statistics of online fsck") and a followup fix.
> Was that intentional? From the description of XFS_DEBUG I gather it should
> be disabled for regular use, so this was a bit surprising to see.
> Maybe that "default y" setting should be removed.
No, it's just wrong....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2023-11-05 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 18:03 XFS_DEBUG got enabled by default in 6.6 Holger Hoffstätte
2023-11-05 18:28 ` Anthony Iliopoulos
2023-11-05 22:40 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUgZxy9d+ICGLWUK@dread.disaster.area \
--to=david@fromorbit.com \
--cc=holger@applied-asynchrony.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.