From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Mon, 6 Nov 2023 08:04:17 -0800 Subject: [PATCH 27/34] KVM: selftests: Introduce VM "shape" to allow tests to specify the VM type In-Reply-To: References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-28-pbonzini@redhat.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Nov 06, 2023, Fuad Tabba wrote: > On Sun, Nov 5, 2023 at 4:34?PM Paolo Bonzini wrote: > > > > From: Sean Christopherson > > > > Add a "vm_shape" structure to encapsulate the selftests-defined "mode", > > along with the KVM-defined "type" for use when creating a new VM. "mode" > > tracks physical and virtual address properties, as well as the preferred > > backing memory type, while "type" corresponds to the VM type. > > > > Taking the VM type will allow adding tests for KVM_CREATE_GUEST_MEMFD, > > a.k.a. guest private memory, without needing an entirely separate set of > > helpers. Guest private memory is effectively usable only by confidential > > VM types, and it's expected that x86 will double down and require unique > > VM types for TDX and SNP guests. > > > > Signed-off-by: Sean Christopherson > > Message-Id: <20231027182217.3615211-30-seanjc@google.com> > > Signed-off-by: Paolo Bonzini > > --- > > nit: as in a prior selftest commit messages, references in the commit > message to guest _private_ memory. Should these be changed to just > guest memory? Hmm, no, "private" is mostly appropriate here. At this point in time, only x86 supports KVM_CREATE_GUEST_MEMFD, and x86 only supports it for private memory. And the purpose of letting x86 selftests specify KVM_X86_SW_PROTECTED_VM, i.e. the reason this patch exists, is purely to get private memory. Maybe tweak the second paragraph to this? Taking the VM type will allow adding tests for KVM_CREATE_GUEST_MEMFD without needing an entirely separate set of helpers. At this time, guest_memfd is effectively usable only by confidential VM types in the form of guest private memory, and it's expected that x86 will double down and require unique VM types for TDX and SNP guests. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68E9629401 for ; Mon, 6 Nov 2023 16:04:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hXv6FZ6w" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-5a9012ab0adso64335467b3.1 for ; Mon, 06 Nov 2023 08:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699286659; x=1699891459; darn=lists.linux.dev; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=vBcfSXW+7b0RYZr/CwodaGuIC1t2rSK8z82L7NdJqdg=; b=hXv6FZ6w8ZG2YeweyxC8SjGB6Iyoh82NIqqLvrFvOpAN/7TgByY4mwcaKYDnQ3troC OcYzzISJjwOKtn/2Nj2EFa5OtYR4zi1PBakKB7NeummU+MEuRnqtsdhWqCWHMjKG6V6x AXockVY+8TMUhJDMBFoPWC8cg1m0sdGAF0qJtpHcgtKNSyP0dq5+wkRyrObqAiuriDAm dBwcGvvvsgQjKXVBBJ8TMwQF/qlvoYPBOmAW17SxiIICHPnD7jbjHobM7poejlio/lq1 m+DUB54fGoMB5ULLrwndsAFyYr3LnIX2kA7Q4FJVSBxtvdkD5XWDP60OxOHEjTevk2u5 XT1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699286659; x=1699891459; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vBcfSXW+7b0RYZr/CwodaGuIC1t2rSK8z82L7NdJqdg=; b=b5KjtxPHp5ca8SKqo1Lnoh6aT3JjUQh3/D9IxAo88wk3H6BySmmJ9NUBNn2kjGNaH5 WqVVIjxAssgvfJ1ppOm6eez3bss/ycAEBlw8T7Lf2uTwAJPetcJAZdsd0ZhKUiCIFboZ HB4SPGhayA0W+xZnxsIGbwGpO/Wj52jCuuzxzgMLVfnofi4tUjaLHelZ5ny/PT+InCie EHGdmjg8ocGNjlhYdBbIwIxY9+0nTx5g5q2fjbqZS4swo/kP6XAckKe4XFeS2pd+FAg6 4AkbGCv7ILtvoUMDrIQgDDX+yTPtTJjBaqbdhfFfk7BG/EOl0QcsRMFfWiBA3Y9AO5Bs HfHA== X-Gm-Message-State: AOJu0YzkbFI6kayHRpLrwCsV+4WvRsMOypyWUsYTknlvyb330xFK1fIP ypaDsFH5El4H9sx7mEDpdKPF3cbPIqQ= X-Google-Smtp-Source: AGHT+IG4M/eznhqFxpL/eWUumIXP2aANvxiOg95OzhM2lh4aiDVuodrpXWON7UbLhWxQPiRYqqCoKKt9NcE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:830d:0:b0:5a8:6162:b69 with SMTP id t13-20020a81830d000000b005a861620b69mr214046ywf.3.1699286659321; Mon, 06 Nov 2023 08:04:19 -0800 (PST) Date: Mon, 6 Nov 2023 08:04:17 -0800 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-28-pbonzini@redhat.com> Message-ID: Subject: Re: [PATCH 27/34] KVM: selftests: Introduce VM "shape" to allow tests to specify the VM type From: Sean Christopherson To: Fuad Tabba Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Mon, Nov 06, 2023, Fuad Tabba wrote: > On Sun, Nov 5, 2023 at 4:34=E2=80=AFPM Paolo Bonzini wrote: > > > > From: Sean Christopherson > > > > Add a "vm_shape" structure to encapsulate the selftests-defined "mode", > > along with the KVM-defined "type" for use when creating a new VM. "mod= e" > > tracks physical and virtual address properties, as well as the preferre= d > > backing memory type, while "type" corresponds to the VM type. > > > > Taking the VM type will allow adding tests for KVM_CREATE_GUEST_MEMFD, > > a.k.a. guest private memory, without needing an entirely separate set o= f > > helpers. Guest private memory is effectively usable only by confidenti= al > > VM types, and it's expected that x86 will double down and require uniqu= e > > VM types for TDX and SNP guests. > > > > Signed-off-by: Sean Christopherson > > Message-Id: <20231027182217.3615211-30-seanjc@google.com> > > Signed-off-by: Paolo Bonzini > > --- >=20 > nit: as in a prior selftest commit messages, references in the commit > message to guest _private_ memory. Should these be changed to just > guest memory? Hmm, no, "private" is mostly appropriate here. At this point in time, only= x86 supports KVM_CREATE_GUEST_MEMFD, and x86 only supports it for private memor= y. And the purpose of letting x86 selftests specify KVM_X86_SW_PROTECTED_VM, i= .e. the reason this patch exists, is purely to get private memory. Maybe tweak the second paragraph to this? Taking the VM type will allow adding tests for KVM_CREATE_GUEST_MEMFD without needing an entirely separate set of helpers. At this time, guest_memfd is effectively usable only by confidential VM types in the form of guest private memory, and it's expected that x86 will double down and require unique VM types for TDX and SNP guests. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DECD2C4167D for ; Mon, 6 Nov 2023 16:04:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=RLs/o9i7T1wHgNGuaGhh1J98xHnrP8uEsOZqH9TMZNY=; b=MVIuo2E0WfpGRTR3liHi2NIWiv KQ2EWRpnJvYJl1TWpv4A5NyQexW38AJL2xJj+eNvwGwJVOo0K+3ZRiJRT9d6XQ8+3tEOcLQiG9QTF J3iCwYWDINkUJWbHcaoX4GjjtvoNrKoNyGKrRLzvJ3tDv30mwpjcyC1oH1CeVA7gNL/cJyd3QPmtG edGV9UwUWFKn2FrTxI0eelnoJ27e9LUVKL1XUrWqyNxabWBJwDIdTZS3W9+9L1mQN4tYMuvvRkk5t hn/DbBDPfZ1u3vne2uPP3Lw5vXxzmLSwQWQvuNajy3unLycvD9T7Lr9ED0lUsfmEeBEp0nE76DBbI M5B+yV6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r025O-00H4Gd-2E; Mon, 06 Nov 2023 16:04:22 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r025M-00H4F8-2h for linux-riscv@lists.infradead.org; Mon, 06 Nov 2023 16:04:22 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-5afa86b8d66so64245387b3.3 for ; Mon, 06 Nov 2023 08:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699286659; x=1699891459; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=vBcfSXW+7b0RYZr/CwodaGuIC1t2rSK8z82L7NdJqdg=; b=tlBdXjZWfmc8YSzY2r2SDhRhTwISgiO2ReFzM7f5Ugg3eh8fXAbFhLjo6FB5f9Qvx5 pxgb33fFTQsxNlO0JmghKz2xk4pcYBFAwSjU45l4VeZmK7RVu3eeC45cUzERwtjgyBw9 WnlzZwSLg9YhcAdeJH8t8a2gQsXraJMuQ6CNcXfmrnsV9gGzPMCJ2vAG+x/TAaUXIjF8 BVuPSOTj4qP1dMg2jFLg1td0y1NaW/BKIIZOWNKwro5h/WzOyydlX7vyoc6SJupdZS5M 4Sv0k9S8pySYF071nNUxa8csWId9xUqlggtjVxFV9PkXi5uAY3+faO5OPEvxBPp4Vves 5Awg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699286659; x=1699891459; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vBcfSXW+7b0RYZr/CwodaGuIC1t2rSK8z82L7NdJqdg=; b=f15gkv4TsC9aKF9uaLsAYcfMN31akuQrP04uEz5EplgzA7sAzAPbfxKHIWBOROUyWl 4wqbrMITflcbyopBumgwZ8LE6CSGY5vGOqr9svQl8KQt9vVWQfkgVM8BQ8GwDy3lhpVR PKDt1JVrgeSYqvAluHxDqV0O0tw2OUswmVlT3Cjdgv0g07OZPfuvjjtTuoF9ZAxStYiL wNT8bxAJbRiYfhjQHaFmhIdHKC+xm9DGnaSm2EeWVb2kIxvJYGxxhsi05wf6TG5JEiDv YzluhnvJbOeuriX+ov5qaXhd7tJSj32MbaCqBTEH/phK5vc4fgAKAAVw5B5u0Q2bCrTL MoAw== X-Gm-Message-State: AOJu0Yy6tNkHP/GZQixnEmOM2G+dF7ibRjaH7rGTjEguLRQ5NTYojvMz ldR/U3qqyTGyu2OcpTeQLoFsnmbyFTo= X-Google-Smtp-Source: AGHT+IG4M/eznhqFxpL/eWUumIXP2aANvxiOg95OzhM2lh4aiDVuodrpXWON7UbLhWxQPiRYqqCoKKt9NcE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:830d:0:b0:5a8:6162:b69 with SMTP id t13-20020a81830d000000b005a861620b69mr214046ywf.3.1699286659321; Mon, 06 Nov 2023 08:04:19 -0800 (PST) Date: Mon, 6 Nov 2023 08:04:17 -0800 In-Reply-To: Mime-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-28-pbonzini@redhat.com> Message-ID: Subject: Re: [PATCH 27/34] KVM: selftests: Introduce VM "shape" to allow tests to specify the VM type From: Sean Christopherson To: Fuad Tabba Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231106_080420_874485_FEE6AB9D X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBOb3YgMDYsIDIwMjMsIEZ1YWQgVGFiYmEgd3JvdGU6Cj4gT24gU3VuLCBOb3YgNSwg MjAyMyBhdCA0OjM04oCvUE0gUGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT4gd3Jv dGU6Cj4gPgo+ID4gRnJvbTogU2VhbiBDaHJpc3RvcGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+ Cj4gPgo+ID4gQWRkIGEgInZtX3NoYXBlIiBzdHJ1Y3R1cmUgdG8gZW5jYXBzdWxhdGUgdGhlIHNl bGZ0ZXN0cy1kZWZpbmVkICJtb2RlIiwKPiA+IGFsb25nIHdpdGggdGhlIEtWTS1kZWZpbmVkICJ0 eXBlIiBmb3IgdXNlIHdoZW4gY3JlYXRpbmcgYSBuZXcgVk0uICAibW9kZSIKPiA+IHRyYWNrcyBw aHlzaWNhbCBhbmQgdmlydHVhbCBhZGRyZXNzIHByb3BlcnRpZXMsIGFzIHdlbGwgYXMgdGhlIHBy ZWZlcnJlZAo+ID4gYmFja2luZyBtZW1vcnkgdHlwZSwgd2hpbGUgInR5cGUiIGNvcnJlc3BvbmRz IHRvIHRoZSBWTSB0eXBlLgo+ID4KPiA+IFRha2luZyB0aGUgVk0gdHlwZSB3aWxsIGFsbG93IGFk ZGluZyB0ZXN0cyBmb3IgS1ZNX0NSRUFURV9HVUVTVF9NRU1GRCwKPiA+IGEuay5hLiBndWVzdCBw cml2YXRlIG1lbW9yeSwgd2l0aG91dCBuZWVkaW5nIGFuIGVudGlyZWx5IHNlcGFyYXRlIHNldCBv Zgo+ID4gaGVscGVycy4gIEd1ZXN0IHByaXZhdGUgbWVtb3J5IGlzIGVmZmVjdGl2ZWx5IHVzYWJs ZSBvbmx5IGJ5IGNvbmZpZGVudGlhbAo+ID4gVk0gdHlwZXMsIGFuZCBpdCdzIGV4cGVjdGVkIHRo YXQgeDg2IHdpbGwgZG91YmxlIGRvd24gYW5kIHJlcXVpcmUgdW5pcXVlCj4gPiBWTSB0eXBlcyBm b3IgVERYIGFuZCBTTlAgZ3Vlc3RzLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IFNlYW4gQ2hyaXN0 b3BoZXJzb24gPHNlYW5qY0Bnb29nbGUuY29tPgo+ID4gTWVzc2FnZS1JZDogPDIwMjMxMDI3MTgy MjE3LjM2MTUyMTEtMzAtc2VhbmpjQGdvb2dsZS5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBQYW9s byBCb256aW5pIDxwYm9uemluaUByZWRoYXQuY29tPgo+ID4gLS0tCj4gCj4gbml0OiBhcyBpbiBh IHByaW9yIHNlbGZ0ZXN0IGNvbW1pdCBtZXNzYWdlcywgcmVmZXJlbmNlcyBpbiB0aGUgY29tbWl0 Cj4gbWVzc2FnZSB0byBndWVzdCBfcHJpdmF0ZV8gbWVtb3J5LiBTaG91bGQgdGhlc2UgYmUgY2hh bmdlZCB0byBqdXN0Cj4gZ3Vlc3QgbWVtb3J5PwoKSG1tLCBubywgInByaXZhdGUiIGlzIG1vc3Rs eSBhcHByb3ByaWF0ZSBoZXJlLiAgQXQgdGhpcyBwb2ludCBpbiB0aW1lLCBvbmx5IHg4NgpzdXBw b3J0cyBLVk1fQ1JFQVRFX0dVRVNUX01FTUZELCBhbmQgeDg2IG9ubHkgc3VwcG9ydHMgaXQgZm9y IHByaXZhdGUgbWVtb3J5LgpBbmQgdGhlIHB1cnBvc2Ugb2YgbGV0dGluZyB4ODYgc2VsZnRlc3Rz IHNwZWNpZnkgS1ZNX1g4Nl9TV19QUk9URUNURURfVk0sIGkuZS4KdGhlIHJlYXNvbiB0aGlzIHBh dGNoIGV4aXN0cywgaXMgcHVyZWx5IHRvIGdldCBwcml2YXRlIG1lbW9yeS4KCk1heWJlIHR3ZWFr IHRoZSBzZWNvbmQgcGFyYWdyYXBoIHRvIHRoaXM/CgpUYWtpbmcgdGhlIFZNIHR5cGUgd2lsbCBh bGxvdyBhZGRpbmcgdGVzdHMgZm9yIEtWTV9DUkVBVEVfR1VFU1RfTUVNRkQKd2l0aG91dCBuZWVk aW5nIGFuIGVudGlyZWx5IHNlcGFyYXRlIHNldCBvZiBoZWxwZXJzLiAgQXQgdGhpcyB0aW1lLApn dWVzdF9tZW1mZCBpcyBlZmZlY3RpdmVseSB1c2FibGUgb25seSBieSBjb25maWRlbnRpYWwgVk0g dHlwZXMgaW4gdGhlCmZvcm0gb2YgZ3Vlc3QgcHJpdmF0ZSBtZW1vcnksIGFuZCBpdCdzIGV4cGVj dGVkIHRoYXQgeDg2IHdpbGwgZG91YmxlIGRvd24KYW5kIHJlcXVpcmUgdW5pcXVlIFZNIHR5cGVz IGZvciBURFggYW5kIFNOUCBndWVzdHMuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22639C4332F for ; Mon, 6 Nov 2023 16:05:13 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=oEmvQq09; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SPGQb522dz3cVm for ; Tue, 7 Nov 2023 03:05:11 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=oEmvQq09; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::1149; helo=mail-yw1-x1149.google.com; envelope-from=3gw5jzqykdpqoawjfyckkcha.ykihejqtlly-zarheopo.kvhwxo.knc@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SPGPg3hzQz2yNf for ; Tue, 7 Nov 2023 03:04:21 +1100 (AEDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5a9012ab0adso64335487b3.1 for ; Mon, 06 Nov 2023 08:04:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699286659; x=1699891459; darn=lists.ozlabs.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=vBcfSXW+7b0RYZr/CwodaGuIC1t2rSK8z82L7NdJqdg=; b=oEmvQq09lW20bFQB/kfj09X92ChYHaZOUz0dtL6McCByNl0eGHczKbMay0bqbQUjmT QUD3W/n+mYobvuVGrldejRFqL5rJ8Iz5NnUzaQnPJhWlq2nJAl3iE5mK4oZ3YTM8AOdb mBX4kkoCSPYwu76mCNGuZ5gKGv+HRDofv6GRyULV/4hed7BMEuhXIkiEsdo3Bha0MdeT tn6cPfI20j0mP12X4/w6HufiMjcgfPNbIauylZQALbLO9cS9ba/7qgaIkQWEO9sjJtSC HRxmrQBSlTtWnxd9YwLF8fJPplZUgUhZCOz76AHQub6Lt3sWm1te14IAJYNRa8hr/cnY WbqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699286659; x=1699891459; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vBcfSXW+7b0RYZr/CwodaGuIC1t2rSK8z82L7NdJqdg=; b=YowLxjUOmch826opycUPWf9bZMYcRuz0sicILPyra+NkPtY6P1jtjsQdPJdWd7gr9y CPcxHWmxRszBErZ0/AN/vHb9oXN1R0Lz38d+ZXu/vntgY0Dg0RIZnhWn8Xtt46DH0kR3 tJ25CFiZM3OXxRDUY8+Q3eT7e+ZLO/OQi/WU+PpXndsZZvv6Dwrr5YBnX6nEAoI9WDku O0bPTUO4R/vwzC0e2d5NVQ80s0diSyp7koGFS7r7fh/KVCQzL8S3B5MPcu1YfWBPr2sj Owb9XfVsz37P5AgfCwsGXORuNPcqju+3Ju2JpBgJpdX/HPlgHuPPM7teJlh7wEuEv54Y O+iQ== X-Gm-Message-State: AOJu0YxKrO047denI1Rsch/OkdXZYUmWu7E40rx6zen/v/H19kmbdXsC /EzfL8XkZx2lCe9mVOuKW9eefpy56ng= X-Google-Smtp-Source: AGHT+IG4M/eznhqFxpL/eWUumIXP2aANvxiOg95OzhM2lh4aiDVuodrpXWON7UbLhWxQPiRYqqCoKKt9NcE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:830d:0:b0:5a8:6162:b69 with SMTP id t13-20020a81830d000000b005a861620b69mr214046ywf.3.1699286659321; Mon, 06 Nov 2023 08:04:19 -0800 (PST) Date: Mon, 6 Nov 2023 08:04:17 -0800 In-Reply-To: Mime-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-28-pbonzini@redhat.com> Message-ID: Subject: Re: [PATCH 27/34] KVM: selftests: Introduce VM "shape" to allow tests to specify the VM type From: Sean Christopherson To: Fuad Tabba Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chao Peng , linux-riscv@lists.infradead.org, Isaku Yamahata , Marc Zyngier , Huacai Chen , Xiaoyao Li , "Matthew Wilcox \(Oracle\)" , Wang , Vlastimil Babka , Yu Zhang , Maciej Szmigiero , Albert Ou , Michael Roth , Ackerley Tng , Alexander Viro , Paul Walmsley , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Isaku Yamahata , Christian Brauner , Quentin Perret , Liam Merwick , linux-mips@vger.kernel.org, Oliver Upton , David Matlack , Jarkko Sakkinen , Palmer Dabbelt , "Kirill A. Shutemov" , kvm-riscv@lists.infradead.org, Anup Patel , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Andrew Morton , Vishal Annapurve , linuxppc-dev@lists.ozlabs.org, Xu Yilun , Anish Moorthy Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Nov 06, 2023, Fuad Tabba wrote: > On Sun, Nov 5, 2023 at 4:34=E2=80=AFPM Paolo Bonzini wrote: > > > > From: Sean Christopherson > > > > Add a "vm_shape" structure to encapsulate the selftests-defined "mode", > > along with the KVM-defined "type" for use when creating a new VM. "mod= e" > > tracks physical and virtual address properties, as well as the preferre= d > > backing memory type, while "type" corresponds to the VM type. > > > > Taking the VM type will allow adding tests for KVM_CREATE_GUEST_MEMFD, > > a.k.a. guest private memory, without needing an entirely separate set o= f > > helpers. Guest private memory is effectively usable only by confidenti= al > > VM types, and it's expected that x86 will double down and require uniqu= e > > VM types for TDX and SNP guests. > > > > Signed-off-by: Sean Christopherson > > Message-Id: <20231027182217.3615211-30-seanjc@google.com> > > Signed-off-by: Paolo Bonzini > > --- >=20 > nit: as in a prior selftest commit messages, references in the commit > message to guest _private_ memory. Should these be changed to just > guest memory? Hmm, no, "private" is mostly appropriate here. At this point in time, only= x86 supports KVM_CREATE_GUEST_MEMFD, and x86 only supports it for private memor= y. And the purpose of letting x86 selftests specify KVM_X86_SW_PROTECTED_VM, i= .e. the reason this patch exists, is purely to get private memory. Maybe tweak the second paragraph to this? Taking the VM type will allow adding tests for KVM_CREATE_GUEST_MEMFD without needing an entirely separate set of helpers. At this time, guest_memfd is effectively usable only by confidential VM types in the form of guest private memory, and it's expected that x86 will double down and require unique VM types for TDX and SNP guests. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 063FEC4332F for ; Mon, 6 Nov 2023 16:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=JBx3Le7vpMDUa7McG80ZcTQu2Oo387xd9EQOfsNU8e0=; b=02hBRzNOdF+AAUyyI7uG4+Y3+5 qovvQ5Z3rTa+ln35B9TNA9xFpaz8Jot1s30p4w28SPh6Lmgbq7QB0Ss7L+W9HfJLQm0tPQpfkT7+2 I0cGifW5jnkXHrov1vGuPWLo5s2pKnuM7hPMiWVKAELQ4dEk6SSpHVxy8VwCMgUvqrecGtFawlFFn J5UYtKsmZTC6qPGfxWl9jRa6buWYqYf+OGK3VZqUMiPj38p1Kzrz7F8yZ4KoLoN2oOWZP3zGFPdNj H98aFAC4vYEWPFhc6ModLq0K7J7j/NEoaiItAh04r2qTwoL4iGQxWjOy1doq8wIECAKtZZUUAPlfM g5k6TdEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r025R-00H4HX-2E; Mon, 06 Nov 2023 16:04:25 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r025N-00H4F9-0q for linux-arm-kernel@lists.infradead.org; Mon, 06 Nov 2023 16:04:23 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-5afa86b8d66so64245417b3.3 for ; Mon, 06 Nov 2023 08:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699286659; x=1699891459; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=vBcfSXW+7b0RYZr/CwodaGuIC1t2rSK8z82L7NdJqdg=; b=tlBdXjZWfmc8YSzY2r2SDhRhTwISgiO2ReFzM7f5Ugg3eh8fXAbFhLjo6FB5f9Qvx5 pxgb33fFTQsxNlO0JmghKz2xk4pcYBFAwSjU45l4VeZmK7RVu3eeC45cUzERwtjgyBw9 WnlzZwSLg9YhcAdeJH8t8a2gQsXraJMuQ6CNcXfmrnsV9gGzPMCJ2vAG+x/TAaUXIjF8 BVuPSOTj4qP1dMg2jFLg1td0y1NaW/BKIIZOWNKwro5h/WzOyydlX7vyoc6SJupdZS5M 4Sv0k9S8pySYF071nNUxa8csWId9xUqlggtjVxFV9PkXi5uAY3+faO5OPEvxBPp4Vves 5Awg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699286659; x=1699891459; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=vBcfSXW+7b0RYZr/CwodaGuIC1t2rSK8z82L7NdJqdg=; b=cWQOpBGj4JiP+ns8IYXgPlyGXa6/hzOt/hHHtvo2PqbfJk14b2Oex9i7aoEldLCd5t EeCeBJi5lksESaHtXEI+CPGLqIQ9R3R3at9O+aCYzUpkg5OeDk9MSeTg6xzWSwuPXOGQ Sl0flChemXWEUU6a9gVpwQoy2IQ0lBtqD2or+zbG9stMUq23vDsZaI6zvXqxE3Af1bvi y3EkW+MzFqeHUvLVNx78N+ppoePOr63tZqX2BkwYFwoeDuUh+5zsQ6Hb9VqLk3OGt9Mp oKEkhhe4YATXdscwhFmW6VhG2oqF9pj2/+mh5fSGf0SglQYh5Dr5QmslX+mYzZ1cB+MH 8Uvg== X-Gm-Message-State: AOJu0YxLm1pHX7s+K852cl8CpovATOB9lCOXZGsAEWe/8nb+8lj8Zjet jTU1DektpMBCGX9HfpDv3njtY1FPi80= X-Google-Smtp-Source: AGHT+IG4M/eznhqFxpL/eWUumIXP2aANvxiOg95OzhM2lh4aiDVuodrpXWON7UbLhWxQPiRYqqCoKKt9NcE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:830d:0:b0:5a8:6162:b69 with SMTP id t13-20020a81830d000000b005a861620b69mr214046ywf.3.1699286659321; Mon, 06 Nov 2023 08:04:19 -0800 (PST) Date: Mon, 6 Nov 2023 08:04:17 -0800 In-Reply-To: Mime-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-28-pbonzini@redhat.com> Message-ID: Subject: Re: [PATCH 27/34] KVM: selftests: Introduce VM "shape" to allow tests to specify the VM type From: Sean Christopherson To: Fuad Tabba Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231106_080421_298230_37193CDA X-CRM114-Status: GOOD ( 16.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBOb3YgMDYsIDIwMjMsIEZ1YWQgVGFiYmEgd3JvdGU6Cj4gT24gU3VuLCBOb3YgNSwg MjAyMyBhdCA0OjM04oCvUE0gUGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT4gd3Jv dGU6Cj4gPgo+ID4gRnJvbTogU2VhbiBDaHJpc3RvcGhlcnNvbiA8c2VhbmpjQGdvb2dsZS5jb20+ Cj4gPgo+ID4gQWRkIGEgInZtX3NoYXBlIiBzdHJ1Y3R1cmUgdG8gZW5jYXBzdWxhdGUgdGhlIHNl bGZ0ZXN0cy1kZWZpbmVkICJtb2RlIiwKPiA+IGFsb25nIHdpdGggdGhlIEtWTS1kZWZpbmVkICJ0 eXBlIiBmb3IgdXNlIHdoZW4gY3JlYXRpbmcgYSBuZXcgVk0uICAibW9kZSIKPiA+IHRyYWNrcyBw aHlzaWNhbCBhbmQgdmlydHVhbCBhZGRyZXNzIHByb3BlcnRpZXMsIGFzIHdlbGwgYXMgdGhlIHBy ZWZlcnJlZAo+ID4gYmFja2luZyBtZW1vcnkgdHlwZSwgd2hpbGUgInR5cGUiIGNvcnJlc3BvbmRz IHRvIHRoZSBWTSB0eXBlLgo+ID4KPiA+IFRha2luZyB0aGUgVk0gdHlwZSB3aWxsIGFsbG93IGFk ZGluZyB0ZXN0cyBmb3IgS1ZNX0NSRUFURV9HVUVTVF9NRU1GRCwKPiA+IGEuay5hLiBndWVzdCBw cml2YXRlIG1lbW9yeSwgd2l0aG91dCBuZWVkaW5nIGFuIGVudGlyZWx5IHNlcGFyYXRlIHNldCBv Zgo+ID4gaGVscGVycy4gIEd1ZXN0IHByaXZhdGUgbWVtb3J5IGlzIGVmZmVjdGl2ZWx5IHVzYWJs ZSBvbmx5IGJ5IGNvbmZpZGVudGlhbAo+ID4gVk0gdHlwZXMsIGFuZCBpdCdzIGV4cGVjdGVkIHRo YXQgeDg2IHdpbGwgZG91YmxlIGRvd24gYW5kIHJlcXVpcmUgdW5pcXVlCj4gPiBWTSB0eXBlcyBm b3IgVERYIGFuZCBTTlAgZ3Vlc3RzLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IFNlYW4gQ2hyaXN0 b3BoZXJzb24gPHNlYW5qY0Bnb29nbGUuY29tPgo+ID4gTWVzc2FnZS1JZDogPDIwMjMxMDI3MTgy MjE3LjM2MTUyMTEtMzAtc2VhbmpjQGdvb2dsZS5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBQYW9s byBCb256aW5pIDxwYm9uemluaUByZWRoYXQuY29tPgo+ID4gLS0tCj4gCj4gbml0OiBhcyBpbiBh IHByaW9yIHNlbGZ0ZXN0IGNvbW1pdCBtZXNzYWdlcywgcmVmZXJlbmNlcyBpbiB0aGUgY29tbWl0 Cj4gbWVzc2FnZSB0byBndWVzdCBfcHJpdmF0ZV8gbWVtb3J5LiBTaG91bGQgdGhlc2UgYmUgY2hh bmdlZCB0byBqdXN0Cj4gZ3Vlc3QgbWVtb3J5PwoKSG1tLCBubywgInByaXZhdGUiIGlzIG1vc3Rs eSBhcHByb3ByaWF0ZSBoZXJlLiAgQXQgdGhpcyBwb2ludCBpbiB0aW1lLCBvbmx5IHg4NgpzdXBw b3J0cyBLVk1fQ1JFQVRFX0dVRVNUX01FTUZELCBhbmQgeDg2IG9ubHkgc3VwcG9ydHMgaXQgZm9y IHByaXZhdGUgbWVtb3J5LgpBbmQgdGhlIHB1cnBvc2Ugb2YgbGV0dGluZyB4ODYgc2VsZnRlc3Rz IHNwZWNpZnkgS1ZNX1g4Nl9TV19QUk9URUNURURfVk0sIGkuZS4KdGhlIHJlYXNvbiB0aGlzIHBh dGNoIGV4aXN0cywgaXMgcHVyZWx5IHRvIGdldCBwcml2YXRlIG1lbW9yeS4KCk1heWJlIHR3ZWFr IHRoZSBzZWNvbmQgcGFyYWdyYXBoIHRvIHRoaXM/CgpUYWtpbmcgdGhlIFZNIHR5cGUgd2lsbCBh bGxvdyBhZGRpbmcgdGVzdHMgZm9yIEtWTV9DUkVBVEVfR1VFU1RfTUVNRkQKd2l0aG91dCBuZWVk aW5nIGFuIGVudGlyZWx5IHNlcGFyYXRlIHNldCBvZiBoZWxwZXJzLiAgQXQgdGhpcyB0aW1lLApn dWVzdF9tZW1mZCBpcyBlZmZlY3RpdmVseSB1c2FibGUgb25seSBieSBjb25maWRlbnRpYWwgVk0g dHlwZXMgaW4gdGhlCmZvcm0gb2YgZ3Vlc3QgcHJpdmF0ZSBtZW1vcnksIGFuZCBpdCdzIGV4cGVj dGVkIHRoYXQgeDg2IHdpbGwgZG91YmxlIGRvd24KYW5kIHJlcXVpcmUgdW5pcXVlIFZNIHR5cGVz IGZvciBURFggYW5kIFNOUCBndWVzdHMuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==