From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Mon, 6 Nov 2023 08:13:01 -0800 Subject: [PATCH 25/34] KVM: selftests: Add helpers to convert guest memory b/w private and shared In-Reply-To: References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-26-pbonzini@redhat.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Nov 06, 2023, Fuad Tabba wrote: > On Sun, Nov 5, 2023 at 4:34?PM Paolo Bonzini wrote: > > +void vm_guest_mem_fallocate(struct kvm_vm *vm, uint64_t base, uint64_t size, > > + bool punch_hole) > > +{ > > + const int mode = FALLOC_FL_KEEP_SIZE | (punch_hole ? FALLOC_FL_PUNCH_HOLE : 0); > > + struct userspace_mem_region *region; > > + uint64_t end = base + size; > > + uint64_t gpa, len; > > + off_t fd_offset; > > + int ret; > > + > > + for (gpa = base; gpa < end; gpa += len) { > > + uint64_t offset; > > + > > + region = userspace_mem_region_find(vm, gpa, gpa); > > + TEST_ASSERT(region && region->region.flags & KVM_MEM_GUEST_MEMFD, > > + "Private memory region not found for GPA 0x%lx", gpa); > > + > > + offset = (gpa - region->region.guest_phys_addr); > > nit: why the parentheses? I simply forgot to remove them when I changed the function to support spanning multiple memslots, i.e. when the code went from this fd_offset = region->region.gmem_offset + (gpa - region->region.guest_phys_addr); to what you see above. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D7CC29410 for ; Mon, 6 Nov 2023 16:13:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UXCJg3lc" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-5a7cf717bacso63996087b3.1 for ; Mon, 06 Nov 2023 08:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699287183; x=1699891983; darn=lists.linux.dev; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=mmoUoGnC/t23H3IPxV2qsT2AAyd7sUSE5gGiJgJlDX0=; b=UXCJg3lcanXOaYeYVVAmkTmeP0DzJqG5oCkb4fxfBKoiGoIsWD+qTVXwcxunnQxOgP vhCMTPTBSPzQXhlBK+XqKpLrLtAAh8a1oCW3EA6k4M17PhyIkPlaD4Anibzlhql4jtIa JmQXJNAr41LAnzF5OHW8hcnAU/4XCSYyHG+N+tNl6qtk1EWz/SJXwRbl051+/qRjwem+ uNtcjtm53hEUnxTaemR2LDJj34EQGNhutbGJXTUfKhsqJkTegZRVZeb8TA4H+m94WMwM IcqYwGh+jiCAWzGGFQjja0ytcH+o9UG9ZzF3xAxkXOe5mBRS2St4oH6BmDnKeSK1thXp NWxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699287183; x=1699891983; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mmoUoGnC/t23H3IPxV2qsT2AAyd7sUSE5gGiJgJlDX0=; b=bM6pj9Xsw0U/BJzvRaAk19wo8OJ3a58tm+th8pPs0VFron6o9yLS3e0lNfo72Nk2cO WQqDlOX5rUgK1khqVz2ZcMD/N2ZzqZ3k7K1R4XUKhdB7+v0Yb51+JVyIWTZXIKNH4xT8 TYc6VQL6eELmfW0zosSfIQvoctqb0AnqOBQhdq8E2gu8Djw1AG0Md1rpCZkzHIfT91Xx yVPUXvWwe1HOdL/3wJ4DCNNJb43I9elDc/+v2TX7bL3BOViPvjqiQ22GsMegGBFtiN+Z Xrdh3isCyQ0p+DPG5XJPr+PnSSW0nVaL9Sw1130KUg9herqUfSdYoyDge5uTz6ZA1AJi 03Iw== X-Gm-Message-State: AOJu0Yyvi5ZtCCeMa8rknORKk4vDgyFpIb9Rk1P3WRCuaUQ3v/L21R5M 06GYmUgnSHqUIq/lYaHA541NVfvYbPE= X-Google-Smtp-Source: AGHT+IEuz2kxbbqGFRlRrYjmJAAmCd5YL62xYCCumvx9nTcHzja2SicRUTSCOZ5GtJw0RknzXE1Az5YHDFw= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a0d:d5d2:0:b0:5a7:ad67:b4b6 with SMTP id x201-20020a0dd5d2000000b005a7ad67b4b6mr228755ywd.2.1699287183068; Mon, 06 Nov 2023 08:13:03 -0800 (PST) Date: Mon, 6 Nov 2023 08:13:01 -0800 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-26-pbonzini@redhat.com> Message-ID: Subject: Re: [PATCH 25/34] KVM: selftests: Add helpers to convert guest memory b/w private and shared From: Sean Christopherson To: Fuad Tabba Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Mon, Nov 06, 2023, Fuad Tabba wrote: > On Sun, Nov 5, 2023 at 4:34=E2=80=AFPM Paolo Bonzini wrote: > > +void vm_guest_mem_fallocate(struct kvm_vm *vm, uint64_t base, uint64_t= size, > > + bool punch_hole) > > +{ > > + const int mode =3D FALLOC_FL_KEEP_SIZE | (punch_hole ? FALLOC_F= L_PUNCH_HOLE : 0); > > + struct userspace_mem_region *region; > > + uint64_t end =3D base + size; > > + uint64_t gpa, len; > > + off_t fd_offset; > > + int ret; > > + > > + for (gpa =3D base; gpa < end; gpa +=3D len) { > > + uint64_t offset; > > + > > + region =3D userspace_mem_region_find(vm, gpa, gpa); > > + TEST_ASSERT(region && region->region.flags & KVM_MEM_GU= EST_MEMFD, > > + "Private memory region not found for GPA 0x= %lx", gpa); > > + > > + offset =3D (gpa - region->region.guest_phys_addr); >=20 > nit: why the parentheses? I simply forgot to remove them when I changed the function to support spann= ing multiple memslots, i.e. when the code went from this fd_offset =3D region->region.gmem_offset + (gpa - region->region.guest_phys_addr); to what you see above. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F098C4332F for ; Mon, 6 Nov 2023 16:13:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=7lUCNOtonbP/ICUph5uhWmMJXvN4AJHaDTfQcqZH8sg=; b=RGtchK03Y7xlSN0ZaKQ/j7qsxc rwaw0iW2Yd5b8s5irm506v8beLOvF5f1ixd5iwLv7iX3svAD/NRt4qRthFeJ+ye3EXjSIV7n+pv55 NW32J/9PVudMewndQ2l4iXWXIC5ZcOBM4CQNbANVKlH8B340ZAyyhJDW0UK6QdQ804cdHIlj8qpZT r5Uz3oInYMwsluMgqjGn34vtqHwQX787dFfumjM6Cror+WAjG5lLJ0CdlLjqiUwb94PFsGNOTtHBL GGRco9Vd28ZdiICy/940O61cYlr3oA45dYyQZVlLMgKvBH6N+CzQbyNL4CLCEQacOOp84A8qhfnMb r7JsPiMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r02Dr-00H56n-1d; Mon, 06 Nov 2023 16:13:07 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r02Do-00H54Y-2V for linux-riscv@lists.infradead.org; Mon, 06 Nov 2023 16:13:06 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-5a828bdcfbaso63790777b3.2 for ; Mon, 06 Nov 2023 08:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699287183; x=1699891983; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=mmoUoGnC/t23H3IPxV2qsT2AAyd7sUSE5gGiJgJlDX0=; b=T7SSdw8t/0F0Y05zz3uHGQQ+U7sffwSikxNfFNiQOgbx25yz/uV3eNi7YxhUiXSqec ff3odUNEWHWP61g3kYDxZF2I68F7nKx/3dhqzMckk9PmCtBmfxx1wTyDBAdZCDyBDysd n/NcBPSxZAq0Mr7rSxiTZOcdj5V86WDB9m94C24yikgXCzzLV/ImrGLHs5NLwvVZDB6P Jk6k4vxkgJZ/0SuRPk8gC9QOCxfcuQ2yrFiGlNwh4JctYatXdiY1WtGmvuOx4EoNmoyn xoxCgPe0IkkpiMfSW111V9Nk7c2LvswKxaPnjLZ7I0fxi0BVokLAOE7EvPDn6uImTJmz tJjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699287183; x=1699891983; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mmoUoGnC/t23H3IPxV2qsT2AAyd7sUSE5gGiJgJlDX0=; b=f8qkBwVbxC+xnJTnhWxYxx4Edooylcvk8c9terYsNThr8V0JBZpy8Yf7fm/XUTfMtM OUYM9imLt3cj97bPWjfBrWXCUbw0aW2k5JwnSWC7mDt6EFnneYYpTUvKtHwaA9GkmoOw 52hJsluOiSVmAzSYEWpTbxnxgIqxmg5cLrzX01WtE+XB7SNjUAa9bjeRwRb/Qm79XrO3 gS1ewNlrj/OZgU5/TS8H20z8DpBw0JlliJfugPdsiClZ0PqXqLmnWntI2zb+qYuJDkI1 JZbE+3I+070p149/4hijhD6sxyiRdy+KpB3K2MR/tlVdFoA+gHHNEsfc/26wGUXj/ZuA X28A== X-Gm-Message-State: AOJu0YzwYZHOzYyx4qaDJ0qppwCoK+FkYqML3HO2BoDtyuxH0B0PEQxq ZEoQeRemyBG20sBc7cIe4DIWeVV/EQk= X-Google-Smtp-Source: AGHT+IEuz2kxbbqGFRlRrYjmJAAmCd5YL62xYCCumvx9nTcHzja2SicRUTSCOZ5GtJw0RknzXE1Az5YHDFw= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a0d:d5d2:0:b0:5a7:ad67:b4b6 with SMTP id x201-20020a0dd5d2000000b005a7ad67b4b6mr228755ywd.2.1699287183068; Mon, 06 Nov 2023 08:13:03 -0800 (PST) Date: Mon, 6 Nov 2023 08:13:01 -0800 In-Reply-To: Mime-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-26-pbonzini@redhat.com> Message-ID: Subject: Re: [PATCH 25/34] KVM: selftests: Add helpers to convert guest memory b/w private and shared From: Sean Christopherson To: Fuad Tabba Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231106_081304_812317_774023AC X-CRM114-Status: GOOD ( 11.08 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBOb3YgMDYsIDIwMjMsIEZ1YWQgVGFiYmEgd3JvdGU6Cj4gT24gU3VuLCBOb3YgNSwg MjAyMyBhdCA0OjM04oCvUE0gUGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT4gd3Jv dGU6Cj4gPiArdm9pZCB2bV9ndWVzdF9tZW1fZmFsbG9jYXRlKHN0cnVjdCBrdm1fdm0gKnZtLCB1 aW50NjRfdCBiYXNlLCB1aW50NjRfdCBzaXplLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgIGJvb2wgcHVuY2hfaG9sZSkKPiA+ICt7Cj4gPiArICAgICAgIGNvbnN0IGludCBtb2RlID0g RkFMTE9DX0ZMX0tFRVBfU0laRSB8IChwdW5jaF9ob2xlID8gRkFMTE9DX0ZMX1BVTkNIX0hPTEUg OiAwKTsKPiA+ICsgICAgICAgc3RydWN0IHVzZXJzcGFjZV9tZW1fcmVnaW9uICpyZWdpb247Cj4g PiArICAgICAgIHVpbnQ2NF90IGVuZCA9IGJhc2UgKyBzaXplOwo+ID4gKyAgICAgICB1aW50NjRf dCBncGEsIGxlbjsKPiA+ICsgICAgICAgb2ZmX3QgZmRfb2Zmc2V0Owo+ID4gKyAgICAgICBpbnQg cmV0Owo+ID4gKwo+ID4gKyAgICAgICBmb3IgKGdwYSA9IGJhc2U7IGdwYSA8IGVuZDsgZ3BhICs9 IGxlbikgewo+ID4gKyAgICAgICAgICAgICAgIHVpbnQ2NF90IG9mZnNldDsKPiA+ICsKPiA+ICsg ICAgICAgICAgICAgICByZWdpb24gPSB1c2Vyc3BhY2VfbWVtX3JlZ2lvbl9maW5kKHZtLCBncGEs IGdwYSk7Cj4gPiArICAgICAgICAgICAgICAgVEVTVF9BU1NFUlQocmVnaW9uICYmIHJlZ2lvbi0+ cmVnaW9uLmZsYWdzICYgS1ZNX01FTV9HVUVTVF9NRU1GRCwKPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAiUHJpdmF0ZSBtZW1vcnkgcmVnaW9uIG5vdCBmb3VuZCBmb3IgR1BBIDB4JWx4 IiwgZ3BhKTsKPiA+ICsKPiA+ICsgICAgICAgICAgICAgICBvZmZzZXQgPSAoZ3BhIC0gcmVnaW9u LT5yZWdpb24uZ3Vlc3RfcGh5c19hZGRyKTsKPiAKPiBuaXQ6IHdoeSB0aGUgcGFyZW50aGVzZXM/ CgpJIHNpbXBseSBmb3Jnb3QgdG8gcmVtb3ZlIHRoZW0gd2hlbiBJIGNoYW5nZWQgdGhlIGZ1bmN0 aW9uIHRvIHN1cHBvcnQgc3Bhbm5pbmcKbXVsdGlwbGUgbWVtc2xvdHMsIGkuZS4gd2hlbiB0aGUg Y29kZSB3ZW50IGZyb20gdGhpcwoKCWZkX29mZnNldCA9IHJlZ2lvbi0+cmVnaW9uLmdtZW1fb2Zm c2V0ICsKCQkgICAgKGdwYSAtIHJlZ2lvbi0+cmVnaW9uLmd1ZXN0X3BoeXNfYWRkcik7Cgp0byB3 aGF0IHlvdSBzZWUgYWJvdmUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 699E9C4332F for ; Mon, 6 Nov 2023 16:14:02 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=tHAiY/1D; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4SPGcm6v2Xz3cJW for ; Tue, 7 Nov 2023 03:14:00 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=tHAiY/1D; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::114a; helo=mail-yw1-x114a.google.com; envelope-from=3jxbjzqykdayykgtpimuumrk.iusrot03vvi-jk1royzy.u5rghy.uxm@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4SPGbm3tPMz3bZN for ; Tue, 7 Nov 2023 03:13:06 +1100 (AEDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-5a7d261a84bso63745997b3.3 for ; Mon, 06 Nov 2023 08:13:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699287183; x=1699891983; darn=lists.ozlabs.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=mmoUoGnC/t23H3IPxV2qsT2AAyd7sUSE5gGiJgJlDX0=; b=tHAiY/1DHSqo0zro2RMf/hdyBo7g7VYizA8SHi0nOuPrAGeWgAKtTu8yt3j0lj791i yOUyYyzWM0nMLsfjJKuC5cNyNGaTcVvX5PlnOL3RXR6+5hj17iryRI26pjxQFdF9LWVK zfQ57Deune8U+MEslShOHs5vVp3cDRA7aUVKEgk+/GJJyA68sB50i9zdwK5ljWaaBLWF OgoItKyeBI1XdY29zUUrB3NIqWQrDgXDxGv22dStw2WB9A7SbE7u1BQUOU4GSBvuIRSO D5F0XFcCrJ507611EY9QFUSBy3gRwz05uR3US+6B9A9rPI5nZBpEsGvK4M3f77aEX60q LCKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699287183; x=1699891983; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mmoUoGnC/t23H3IPxV2qsT2AAyd7sUSE5gGiJgJlDX0=; b=QBT3GCZpWnaox65Kw+S+AWpLVT7Vja+7JmXLNvUWLbtMQ9zzIv6MOJKEXw0Z9ezt5R Ro4yYY7J0SdMVyeEu017+EjeDV7oish6eWNn8BVzjJxYG6mZOVBxm+8cbQ/sqhU7XKKx /mgeJ1eOTVMb0J0o5UbCmmg8M2fOGLOdPPn0vgr/xZCBKVTzpqIyGWV7MvD5Ngo5WqVQ 9wU8CYSFa9PpRBhWjZDGMRMRH7EXlc89lmuJHp+FFH+XDRuLl0QJSxEU1qOH4KU9g7KW UYNNEP/XCe3IAgeIPMw3RLPC4fgIxoHjn7BQc2fYTB0nA/ycATc1Y94oH95Oe9kkmmfX NMOA== X-Gm-Message-State: AOJu0YxYjezlBi6HMsCtzOCz1knRbmRDM68jqXr0QKFzKuLIQiSBNpb6 BC/KIlep3OkAJywrgcInHuy/RAMD9Z0= X-Google-Smtp-Source: AGHT+IEuz2kxbbqGFRlRrYjmJAAmCd5YL62xYCCumvx9nTcHzja2SicRUTSCOZ5GtJw0RknzXE1Az5YHDFw= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a0d:d5d2:0:b0:5a7:ad67:b4b6 with SMTP id x201-20020a0dd5d2000000b005a7ad67b4b6mr228755ywd.2.1699287183068; Mon, 06 Nov 2023 08:13:03 -0800 (PST) Date: Mon, 6 Nov 2023 08:13:01 -0800 In-Reply-To: Mime-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-26-pbonzini@redhat.com> Message-ID: Subject: Re: [PATCH 25/34] KVM: selftests: Add helpers to convert guest memory b/w private and shared From: Sean Christopherson To: Fuad Tabba Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chao Peng , linux-riscv@lists.infradead.org, Isaku Yamahata , Marc Zyngier , Huacai Chen , Xiaoyao Li , "Matthew Wilcox \(Oracle\)" , Wang , Vlastimil Babka , Yu Zhang , Maciej Szmigiero , Albert Ou , Michael Roth , Ackerley Tng , Alexander Viro , Paul Walmsley , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Isaku Yamahata , Christian Brauner , Quentin Perret , Liam Merwick , linux-mips@vger.kernel.org, Oliver Upton , David Matlack , Jarkko Sakkinen , Palmer Dabbelt , "Kirill A. Shutemov" , kvm-riscv@lists.infradead.org, Anup Patel , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Andrew Morton , Vishal Annapurve , linuxppc-dev@lists.ozlabs.org, Xu Yilun , Anish Moorthy Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Nov 06, 2023, Fuad Tabba wrote: > On Sun, Nov 5, 2023 at 4:34=E2=80=AFPM Paolo Bonzini wrote: > > +void vm_guest_mem_fallocate(struct kvm_vm *vm, uint64_t base, uint64_t= size, > > + bool punch_hole) > > +{ > > + const int mode =3D FALLOC_FL_KEEP_SIZE | (punch_hole ? FALLOC_F= L_PUNCH_HOLE : 0); > > + struct userspace_mem_region *region; > > + uint64_t end =3D base + size; > > + uint64_t gpa, len; > > + off_t fd_offset; > > + int ret; > > + > > + for (gpa =3D base; gpa < end; gpa +=3D len) { > > + uint64_t offset; > > + > > + region =3D userspace_mem_region_find(vm, gpa, gpa); > > + TEST_ASSERT(region && region->region.flags & KVM_MEM_GU= EST_MEMFD, > > + "Private memory region not found for GPA 0x= %lx", gpa); > > + > > + offset =3D (gpa - region->region.guest_phys_addr); >=20 > nit: why the parentheses? I simply forgot to remove them when I changed the function to support spann= ing multiple memslots, i.e. when the code went from this fd_offset =3D region->region.gmem_offset + (gpa - region->region.guest_phys_addr); to what you see above. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1886FC4332F for ; Mon, 6 Nov 2023 16:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Gvq6PRNTzywWquGz+YLxfenMGimQEskjAAmm4F0RMBQ=; b=R5ctL5U5GNscoIM075N/jtHjhW JQmVg4xHelgQp+Y8fJ1L1MUFDm21k5KMFUgToIoHewk/YySJSP6ES/NZvkm5dz1PGt1OK1b4IADUU xV/lQ7lqBIgXB/v+jCVO1NBz4kspiX7mjNsJooiUXRaSaOMtdkAzQI1/8rGLwFW7By40/1tRFOIaK ALlx/NTD/zamDc1zRh4duwacC48cp9R4o6W3ecMjYRGbjW1JIlR2uFJ3VY7Pt2pu04XsEyLS0EaFw F41dBbXkCHjyDV10GmdcwiPUioVPHMZZPCAX/yjsfjHTWLeWIx9A/BYy7ubs68UHzwtPZaRKGtn+9 m30qaWSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r02Ds-00H56z-0Y; Mon, 06 Nov 2023 16:13:08 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r02Do-00H54V-2l for linux-arm-kernel@lists.infradead.org; Mon, 06 Nov 2023 16:13:06 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5a7d261a84bso63745987b3.3 for ; Mon, 06 Nov 2023 08:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699287183; x=1699891983; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=mmoUoGnC/t23H3IPxV2qsT2AAyd7sUSE5gGiJgJlDX0=; b=T7SSdw8t/0F0Y05zz3uHGQQ+U7sffwSikxNfFNiQOgbx25yz/uV3eNi7YxhUiXSqec ff3odUNEWHWP61g3kYDxZF2I68F7nKx/3dhqzMckk9PmCtBmfxx1wTyDBAdZCDyBDysd n/NcBPSxZAq0Mr7rSxiTZOcdj5V86WDB9m94C24yikgXCzzLV/ImrGLHs5NLwvVZDB6P Jk6k4vxkgJZ/0SuRPk8gC9QOCxfcuQ2yrFiGlNwh4JctYatXdiY1WtGmvuOx4EoNmoyn xoxCgPe0IkkpiMfSW111V9Nk7c2LvswKxaPnjLZ7I0fxi0BVokLAOE7EvPDn6uImTJmz tJjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699287183; x=1699891983; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mmoUoGnC/t23H3IPxV2qsT2AAyd7sUSE5gGiJgJlDX0=; b=azRe3yvX4S590ZhcefmIWVMFznTwao2M+QmfnuKH6RxRfHa5s/udD3AUWSgg/DS5ry ZKRpY67a7HGQh/a1zXBdsOB0KvSrVohV8z8JgOb2pXIhAYal8UegK+dZBt47TTAS5aFQ JQp0WxmcxY1McbPbdjBJYxQZ06qV0asXSD+vIVqUsWHH/XKetcA4RfSljj99YwN4tWoH JIHHUC2S0DJ1vMQ6fkCZyBwIMgvgIOY2w9wgjuDVjXVb1Wh1yq9jg5jYW8XpwOtlsxzb Tmf6GjjKcFmdH45JZ/ISMBgHVR6TOUcEDBSoPFNshSIgijb/VJG3eMb9pb1z2fldp0tI J4tA== X-Gm-Message-State: AOJu0YxYsbssCS/3TsSYRcmHINuySaXvXlttadEz/83H4dxb3zscyIFr 5XrOrMnDhh51H06A+EpKo2SJ+M0TuSc= X-Google-Smtp-Source: AGHT+IEuz2kxbbqGFRlRrYjmJAAmCd5YL62xYCCumvx9nTcHzja2SicRUTSCOZ5GtJw0RknzXE1Az5YHDFw= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a0d:d5d2:0:b0:5a7:ad67:b4b6 with SMTP id x201-20020a0dd5d2000000b005a7ad67b4b6mr228755ywd.2.1699287183068; Mon, 06 Nov 2023 08:13:03 -0800 (PST) Date: Mon, 6 Nov 2023 08:13:01 -0800 In-Reply-To: Mime-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-26-pbonzini@redhat.com> Message-ID: Subject: Re: [PATCH 25/34] KVM: selftests: Add helpers to convert guest memory b/w private and shared From: Sean Christopherson To: Fuad Tabba Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231106_081304_891280_59DCE8E0 X-CRM114-Status: GOOD ( 12.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBOb3YgMDYsIDIwMjMsIEZ1YWQgVGFiYmEgd3JvdGU6Cj4gT24gU3VuLCBOb3YgNSwg MjAyMyBhdCA0OjM04oCvUE0gUGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT4gd3Jv dGU6Cj4gPiArdm9pZCB2bV9ndWVzdF9tZW1fZmFsbG9jYXRlKHN0cnVjdCBrdm1fdm0gKnZtLCB1 aW50NjRfdCBiYXNlLCB1aW50NjRfdCBzaXplLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgIGJvb2wgcHVuY2hfaG9sZSkKPiA+ICt7Cj4gPiArICAgICAgIGNvbnN0IGludCBtb2RlID0g RkFMTE9DX0ZMX0tFRVBfU0laRSB8IChwdW5jaF9ob2xlID8gRkFMTE9DX0ZMX1BVTkNIX0hPTEUg OiAwKTsKPiA+ICsgICAgICAgc3RydWN0IHVzZXJzcGFjZV9tZW1fcmVnaW9uICpyZWdpb247Cj4g PiArICAgICAgIHVpbnQ2NF90IGVuZCA9IGJhc2UgKyBzaXplOwo+ID4gKyAgICAgICB1aW50NjRf dCBncGEsIGxlbjsKPiA+ICsgICAgICAgb2ZmX3QgZmRfb2Zmc2V0Owo+ID4gKyAgICAgICBpbnQg cmV0Owo+ID4gKwo+ID4gKyAgICAgICBmb3IgKGdwYSA9IGJhc2U7IGdwYSA8IGVuZDsgZ3BhICs9 IGxlbikgewo+ID4gKyAgICAgICAgICAgICAgIHVpbnQ2NF90IG9mZnNldDsKPiA+ICsKPiA+ICsg ICAgICAgICAgICAgICByZWdpb24gPSB1c2Vyc3BhY2VfbWVtX3JlZ2lvbl9maW5kKHZtLCBncGEs IGdwYSk7Cj4gPiArICAgICAgICAgICAgICAgVEVTVF9BU1NFUlQocmVnaW9uICYmIHJlZ2lvbi0+ cmVnaW9uLmZsYWdzICYgS1ZNX01FTV9HVUVTVF9NRU1GRCwKPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAiUHJpdmF0ZSBtZW1vcnkgcmVnaW9uIG5vdCBmb3VuZCBmb3IgR1BBIDB4JWx4 IiwgZ3BhKTsKPiA+ICsKPiA+ICsgICAgICAgICAgICAgICBvZmZzZXQgPSAoZ3BhIC0gcmVnaW9u LT5yZWdpb24uZ3Vlc3RfcGh5c19hZGRyKTsKPiAKPiBuaXQ6IHdoeSB0aGUgcGFyZW50aGVzZXM/ CgpJIHNpbXBseSBmb3Jnb3QgdG8gcmVtb3ZlIHRoZW0gd2hlbiBJIGNoYW5nZWQgdGhlIGZ1bmN0 aW9uIHRvIHN1cHBvcnQgc3Bhbm5pbmcKbXVsdGlwbGUgbWVtc2xvdHMsIGkuZS4gd2hlbiB0aGUg Y29kZSB3ZW50IGZyb20gdGhpcwoKCWZkX29mZnNldCA9IHJlZ2lvbi0+cmVnaW9uLmdtZW1fb2Zm c2V0ICsKCQkgICAgKGdwYSAtIHJlZ2lvbi0+cmVnaW9uLmd1ZXN0X3BoeXNfYWRkcik7Cgp0byB3 aGF0IHlvdSBzZWUgYWJvdmUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==