Re: [PATCH v3 6/9] x86: kdump: use generic interface to simplify crashkernel reservation code

[Baoquan He <bhe@redhat.com>]

On 11/07/23 at 07:11pm, kernel test robot wrote:
> Hi Baoquan,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on powerpc/next]
> [also build test WARNING on powerpc/fixes v6.6]
> [cannot apply to arm64/for-next/core tip/x86/core linus/master next-20231107]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Baoquan-He/crash_core-c-remove-unnecessary-parameter-of-function/20230914-113546
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
> patch link:    https://lore.kernel.org/r/20230914033142.676708-7-bhe%40redhat.com
> patch subject: [PATCH v3 6/9] x86: kdump: use generic interface to simplify crashkernel reservation code
> config: i386-randconfig-011-20230914 (https://download.01.org/0day-ci/archive/20231107/202311071923.uYbShjYE-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231107/202311071923.uYbShjYE-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311071923.uYbShjYE-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> arch/x86/kernel/setup.c:476:15: warning: no previous prototype for 'crash_low_size_default' [-Wmissing-prototypes]
>      476 | unsigned long crash_low_size_default(void)
>          |               ^~~~~~~~~~~~~~~~~~~~~~

I didn't try the reproducer at above, whereas this should be an report
on an old version of patch. The patch has been updated later and merged
into linus's tree now. Please see below commit

commit 9c08a2a139fe83f217625ee0352ce531b9a666ea
Author: Baoquan He <bhe@redhat.com>
Date:   Thu Sep 14 11:31:39 2023 +0800

    x86: kdump: use generic interface to simplify crashkernel reservation code

> 
> Kconfig warnings: (for reference only)
>    WARNING: unmet direct dependencies detected for VIDEO_OV2640
>    Depends on [n]: MEDIA_SUPPORT [=m] && VIDEO_DEV [=m] && VIDEO_CAMERA_SENSOR [=n]
>    Selected by [m]:
>    - VIDEO_EM28XX_V4L2 [=m] && USB [=m] && MEDIA_SUPPORT [=m] && MEDIA_USB_SUPPORT [=y] && (MEDIA_CAMERA_SUPPORT [=y] || MEDIA_ANALOG_TV_SUPPORT [=n] || MEDIA_DIGITAL_TV_SUPPORT [=n]) && VIDEO_EM28XX [=m] && MEDIA_SUBDRV_AUTOSELECT [=y] && MEDIA_CAMERA_SUPPORT [=y]
>    WARNING: unmet direct dependencies detected for VIDEO_MT9V011
>    Depends on [n]: MEDIA_SUPPORT [=m] && VIDEO_DEV [=m] && VIDEO_CAMERA_SENSOR [=n]
>    Selected by [m]:
>    - VIDEO_EM28XX_V4L2 [=m] && USB [=m] && MEDIA_SUPPORT [=m] && MEDIA_USB_SUPPORT [=y] && (MEDIA_CAMERA_SUPPORT [=y] || MEDIA_ANALOG_TV_SUPPORT [=n] || MEDIA_DIGITAL_TV_SUPPORT [=n]) && VIDEO_EM28XX [=m] && MEDIA_SUBDRV_AUTOSELECT [=y] && MEDIA_CAMERA_SUPPORT [=y]
> 
> 
> vim +/crash_low_size_default +476 arch/x86/kernel/setup.c
> 
>    472	
>    473	/*
>    474	 * --------- Crashkernel reservation ------------------------------
>    475	 */
>  > 476	unsigned long crash_low_size_default(void)
>    477	{
>    478	#ifdef CONFIG_X86_64
>    479		return max(swiotlb_size_or_default() + (8UL << 20), 256UL << 20);
>    480	#else
>    481		return 0;
>    482	#endif
>    483	}
>    484	
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>