From: Patrick Steinhardt <ps@pks.im>
To: Jeff King <peff@peff.net>
Cc: Taylor Blau <me@ttaylorr.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/2] revision: exclude all packed objects with `--unpacked`
Date: Tue, 7 Nov 2023 10:43:06 +0100 [thread overview]
Message-ID: <ZUoGoYpJFvGSll-u@tanuki> (raw)
In-Reply-To: <20231107040235.GD873619@coredump.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]
On Mon, Nov 06, 2023 at 11:02:35PM -0500, Jeff King wrote:
> On Mon, Nov 06, 2023 at 05:56:27PM -0500, Taylor Blau wrote:
>
> > While working on my longer series to enable verbatim pack reuse across
> > multiple packs[^1], I noticed a couple of oddities with the `--unpacked`
> > rev-walk flag.
> >
> > While it does exclude packed commits, it does not exclude (all) packed
> > trees/blobs/annotated tags. This problem exists in the pack-bitmap
> > machinery, too, which will over-count queries like:
> >
> > $ git rev-list --use-bitmap-index --all --unpacked --objects
> >
> > , etc.
> >
> > The fix is relatively straightforward, split across two patches that
> > Peff and I worked on together earlier today.
>
> I'm not sure my review is worth anything, but this looks good to me. ;)
> I do think it might be worth tightening up the docs as Junio suggested,
> but I would be fine to see that as a patch on top.
>
> -Peff
I also read through the patches and agree, this looks good to me.
Thanks!
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-11-07 9:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 22:56 [PATCH 0/2] revision: exclude all packed objects with `--unpacked` Taylor Blau
2023-11-06 22:56 ` [PATCH 1/2] list-objects: drop --unpacked non-commit objects from results Taylor Blau
2023-11-07 2:21 ` Junio C Hamano
2023-11-07 4:02 ` Jeff King
2023-11-06 22:56 ` [PATCH 2/2] pack-bitmap: " Taylor Blau
2023-11-07 2:20 ` Junio C Hamano
2023-11-07 3:52 ` Jeff King
2023-11-07 1:42 ` [PATCH 0/2] revision: exclude all packed objects with `--unpacked` Junio C Hamano
2023-11-07 4:02 ` Jeff King
2023-11-07 9:43 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUoGoYpJFvGSll-u@tanuki \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.