All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Niklas Cassel <nks@flawful.org>
Cc: John Snow <jsnow@redhat.com>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org,
	Damien Le Moal <dlemoal@kernel.org>,
	Michael Tokarev <mjt@tls.msk.ru>,
	Niklas Cassel <niklas.cassel@wdc.com>
Subject: Re: [PATCH] hw/ide/ahci: trigger either error IRQ or regular IRQ, not both
Date: Tue, 7 Nov 2023 17:55:54 +0100	[thread overview]
Message-ID: <ZUpsGhfN2/BLpEoD@redhat.com> (raw)
In-Reply-To: <20231011131220.1992064-1-nks@flawful.org>

Am 11.10.2023 um 15:12 hat Niklas Cassel geschrieben:
> From: Niklas Cassel <niklas.cassel@wdc.com>
> 
> According to AHCI 1.3.1, 5.3.8.1 RegFIS:Entry, if ERR_STAT is set,
> we jump to state ERR:FatalTaskfile, which will raise a TFES IRQ
> unconditionally, regardless if the I bit is set in the FIS or not.
> 
> Thus, we should never raise a normal IRQ after having sent an error
> IRQ.
> 
> NOTE: for QEMU platforms that use SeaBIOS, this patch depends on QEMU
> commit 784155cdcb02 ("seabios: update submodule to git snapshot"), and
> QEMU commit 14f5a7bae4cb ("seabios: update binaries to git snapshot").
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>

Thanks, applied to the block branch.

Kevin



      parent reply	other threads:[~2023-11-07 16:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 13:12 [PATCH] hw/ide/ahci: trigger either error IRQ or regular IRQ, not both Niklas Cassel
2023-10-11 13:26 ` Philippe Mathieu-Daudé
2023-10-11 14:44 ` Michael Tokarev
2023-10-11 14:50   ` Niklas Cassel
2023-10-26  9:08 ` Niklas Cassel
2023-11-07 16:55 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZUpsGhfN2/BLpEoD@redhat.com \
    --to=kwolf@redhat.com \
    --cc=dlemoal@kernel.org \
    --cc=jsnow@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=niklas.cassel@wdc.com \
    --cc=nks@flawful.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.