* [PATCH v3] drm: amd: Resolve Sphinx unexpected indentation warning
@ 2023-11-07 16:28 ` Hunter Chasens
0 siblings, 0 replies; 11+ messages in thread
From: Hunter Chasens @ 2023-11-07 16:28 UTC (permalink / raw)
To: linux-kernel
Cc: linux-doc, Xinhui.Pan, amd-gfx, dri-devel, Hunter Chasens,
alexander.deucher, christian.koenig
Resolves Sphinx unexpected indentation warning when compiling
documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
a literal block to keep vertical formatting of the
example power state list.
Signed-off-by: Hunter Chasens <hunter.chasens18@ncf.edu>
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index 517b9fb4624c..576202bf64f3 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -989,12 +989,13 @@ static ssize_t amdgpu_get_pp_features(struct device *dev,
* Reading back the files will show you the available power levels within
* the power state and the clock information for those levels. If deep sleep is
* applied to a clock, the level will be denoted by a special level 'S:'
- * E.g.,
- * S: 19Mhz *
- * 0: 615Mhz
- * 1: 800Mhz
- * 2: 888Mhz
- * 3: 1000Mhz
+ * E.g., ::
+ *
+ * S: 19Mhz *
+ * 0: 615Mhz
+ * 1: 800Mhz
+ * 2: 888Mhz
+ * 3: 1000Mhz
*
*
* To manually adjust these states, first select manual using
--
2.42.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3] drm: amd: Resolve Sphinx unexpected indentation warning
@ 2023-11-07 16:28 ` Hunter Chasens
0 siblings, 0 replies; 11+ messages in thread
From: Hunter Chasens @ 2023-11-07 16:28 UTC (permalink / raw)
To: linux-kernel
Cc: linux-doc, dri-devel, amd-gfx, daniel, airlied, Xinhui.Pan,
christian.koenig, alexander.deucher, Hunter Chasens
Resolves Sphinx unexpected indentation warning when compiling
documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
a literal block to keep vertical formatting of the
example power state list.
Signed-off-by: Hunter Chasens <hunter.chasens18@ncf.edu>
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index 517b9fb4624c..576202bf64f3 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -989,12 +989,13 @@ static ssize_t amdgpu_get_pp_features(struct device *dev,
* Reading back the files will show you the available power levels within
* the power state and the clock information for those levels. If deep sleep is
* applied to a clock, the level will be denoted by a special level 'S:'
- * E.g.,
- * S: 19Mhz *
- * 0: 615Mhz
- * 1: 800Mhz
- * 2: 888Mhz
- * 3: 1000Mhz
+ * E.g., ::
+ *
+ * S: 19Mhz *
+ * 0: 615Mhz
+ * 1: 800Mhz
+ * 2: 888Mhz
+ * 3: 1000Mhz
*
*
* To manually adjust these states, first select manual using
--
2.42.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v3] drm: amd: Resolve Sphinx unexpected indentation warning
2023-11-07 16:28 ` Hunter Chasens
(?)
@ 2023-11-07 23:57 ` Bagas Sanjaya
-1 siblings, 0 replies; 11+ messages in thread
From: Bagas Sanjaya @ 2023-11-07 23:57 UTC (permalink / raw)
To: Hunter Chasens, Linux Kernel Mailing List
Cc: Lijo Lazar, Linux Documentation, Xinhui.Pan, Linux AMDGPU,
Linux DRI Development, daniel, alexander.deucher, airlied,
christian.koenig
[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]
On Tue, Nov 07, 2023 at 11:28:30AM -0500, Hunter Chasens wrote:
> Resolves Sphinx unexpected indentation warning when compiling
> documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
> a literal block to keep vertical formatting of the
> example power state list.
>
> Signed-off-by: Hunter Chasens <hunter.chasens18@ncf.edu>
Nit: Whenever a reviewer has offered a Reviewed-by: or Acked-by: trailer,
you should include it in the next reroll unless there is substantial changes
in the reroll.
> ---
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 517b9fb4624c..576202bf64f3 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -989,12 +989,13 @@ static ssize_t amdgpu_get_pp_features(struct device *dev,
> * Reading back the files will show you the available power levels within
> * the power state and the clock information for those levels. If deep sleep is
> * applied to a clock, the level will be denoted by a special level 'S:'
> - * E.g.,
> - * S: 19Mhz *
> - * 0: 615Mhz
> - * 1: 800Mhz
> - * 2: 888Mhz
> - * 3: 1000Mhz
> + * E.g., ::
> + *
> + * S: 19Mhz *
> + * 0: 615Mhz
> + * 1: 800Mhz
> + * 2: 888Mhz
> + * 3: 1000Mhz
> *
> *
> * To manually adjust these states, first select manual using
Anyway, LGTM, thanks!
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] drm: amd: Resolve Sphinx unexpected indentation warning
@ 2023-11-07 23:57 ` Bagas Sanjaya
0 siblings, 0 replies; 11+ messages in thread
From: Bagas Sanjaya @ 2023-11-07 23:57 UTC (permalink / raw)
To: Hunter Chasens, Linux Kernel Mailing List
Cc: Lijo Lazar, Linux Documentation, Xinhui.Pan, Linux AMDGPU,
Linux DRI Development, alexander.deucher, christian.koenig
[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]
On Tue, Nov 07, 2023 at 11:28:30AM -0500, Hunter Chasens wrote:
> Resolves Sphinx unexpected indentation warning when compiling
> documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
> a literal block to keep vertical formatting of the
> example power state list.
>
> Signed-off-by: Hunter Chasens <hunter.chasens18@ncf.edu>
Nit: Whenever a reviewer has offered a Reviewed-by: or Acked-by: trailer,
you should include it in the next reroll unless there is substantial changes
in the reroll.
> ---
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 517b9fb4624c..576202bf64f3 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -989,12 +989,13 @@ static ssize_t amdgpu_get_pp_features(struct device *dev,
> * Reading back the files will show you the available power levels within
> * the power state and the clock information for those levels. If deep sleep is
> * applied to a clock, the level will be denoted by a special level 'S:'
> - * E.g.,
> - * S: 19Mhz *
> - * 0: 615Mhz
> - * 1: 800Mhz
> - * 2: 888Mhz
> - * 3: 1000Mhz
> + * E.g., ::
> + *
> + * S: 19Mhz *
> + * 0: 615Mhz
> + * 1: 800Mhz
> + * 2: 888Mhz
> + * 3: 1000Mhz
> *
> *
> * To manually adjust these states, first select manual using
Anyway, LGTM, thanks!
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] drm: amd: Resolve Sphinx unexpected indentation warning
@ 2023-11-07 23:57 ` Bagas Sanjaya
0 siblings, 0 replies; 11+ messages in thread
From: Bagas Sanjaya @ 2023-11-07 23:57 UTC (permalink / raw)
To: Hunter Chasens, Linux Kernel Mailing List
Cc: Linux Documentation, Linux DRI Development, Linux AMDGPU, daniel,
airlied, Xinhui.Pan, christian.koenig, alexander.deucher,
Lijo Lazar
[-- Attachment #1: Type: text/plain, Size: 1623 bytes --]
On Tue, Nov 07, 2023 at 11:28:30AM -0500, Hunter Chasens wrote:
> Resolves Sphinx unexpected indentation warning when compiling
> documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
> a literal block to keep vertical formatting of the
> example power state list.
>
> Signed-off-by: Hunter Chasens <hunter.chasens18@ncf.edu>
Nit: Whenever a reviewer has offered a Reviewed-by: or Acked-by: trailer,
you should include it in the next reroll unless there is substantial changes
in the reroll.
> ---
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 517b9fb4624c..576202bf64f3 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -989,12 +989,13 @@ static ssize_t amdgpu_get_pp_features(struct device *dev,
> * Reading back the files will show you the available power levels within
> * the power state and the clock information for those levels. If deep sleep is
> * applied to a clock, the level will be denoted by a special level 'S:'
> - * E.g.,
> - * S: 19Mhz *
> - * 0: 615Mhz
> - * 1: 800Mhz
> - * 2: 888Mhz
> - * 3: 1000Mhz
> + * E.g., ::
> + *
> + * S: 19Mhz *
> + * 0: 615Mhz
> + * 1: 800Mhz
> + * 2: 888Mhz
> + * 3: 1000Mhz
> *
> *
> * To manually adjust these states, first select manual using
Anyway, LGTM, thanks!
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] drm: amd: Resolve Sphinx unexpected indentation warning
2023-11-07 16:28 ` Hunter Chasens
(?)
@ 2023-11-08 4:07 ` Lazar, Lijo
-1 siblings, 0 replies; 11+ messages in thread
From: Lazar, Lijo @ 2023-11-08 4:07 UTC (permalink / raw)
To: Hunter Chasens, linux-kernel
Cc: linux-doc, Xinhui.Pan, dri-devel, amd-gfx, daniel,
alexander.deucher, airlied, christian.koenig
On 11/7/2023 9:58 PM, Hunter Chasens wrote:
> Resolves Sphinx unexpected indentation warning when compiling
> documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
> a literal block to keep vertical formatting of the
> example power state list.
>
> Signed-off-by: Hunter Chasens <hunter.chasens18@ncf.edu>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Thanks,
Lijo
> ---
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 517b9fb4624c..576202bf64f3 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -989,12 +989,13 @@ static ssize_t amdgpu_get_pp_features(struct device *dev,
> * Reading back the files will show you the available power levels within
> * the power state and the clock information for those levels. If deep sleep is
> * applied to a clock, the level will be denoted by a special level 'S:'
> - * E.g.,
> - * S: 19Mhz *
> - * 0: 615Mhz
> - * 1: 800Mhz
> - * 2: 888Mhz
> - * 3: 1000Mhz
> + * E.g., ::
> + *
> + * S: 19Mhz *
> + * 0: 615Mhz
> + * 1: 800Mhz
> + * 2: 888Mhz
> + * 3: 1000Mhz
> *
> *
> * To manually adjust these states, first select manual using
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] drm: amd: Resolve Sphinx unexpected indentation warning
@ 2023-11-08 4:07 ` Lazar, Lijo
0 siblings, 0 replies; 11+ messages in thread
From: Lazar, Lijo @ 2023-11-08 4:07 UTC (permalink / raw)
To: Hunter Chasens, linux-kernel
Cc: linux-doc, Xinhui.Pan, dri-devel, amd-gfx, alexander.deucher,
christian.koenig
On 11/7/2023 9:58 PM, Hunter Chasens wrote:
> Resolves Sphinx unexpected indentation warning when compiling
> documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
> a literal block to keep vertical formatting of the
> example power state list.
>
> Signed-off-by: Hunter Chasens <hunter.chasens18@ncf.edu>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Thanks,
Lijo
> ---
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 517b9fb4624c..576202bf64f3 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -989,12 +989,13 @@ static ssize_t amdgpu_get_pp_features(struct device *dev,
> * Reading back the files will show you the available power levels within
> * the power state and the clock information for those levels. If deep sleep is
> * applied to a clock, the level will be denoted by a special level 'S:'
> - * E.g.,
> - * S: 19Mhz *
> - * 0: 615Mhz
> - * 1: 800Mhz
> - * 2: 888Mhz
> - * 3: 1000Mhz
> + * E.g., ::
> + *
> + * S: 19Mhz *
> + * 0: 615Mhz
> + * 1: 800Mhz
> + * 2: 888Mhz
> + * 3: 1000Mhz
> *
> *
> * To manually adjust these states, first select manual using
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] drm: amd: Resolve Sphinx unexpected indentation warning
@ 2023-11-08 4:07 ` Lazar, Lijo
0 siblings, 0 replies; 11+ messages in thread
From: Lazar, Lijo @ 2023-11-08 4:07 UTC (permalink / raw)
To: Hunter Chasens, linux-kernel
Cc: linux-doc, Xinhui.Pan, amd-gfx, dri-devel, daniel,
alexander.deucher, airlied, christian.koenig
On 11/7/2023 9:58 PM, Hunter Chasens wrote:
> Resolves Sphinx unexpected indentation warning when compiling
> documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
> a literal block to keep vertical formatting of the
> example power state list.
>
> Signed-off-by: Hunter Chasens <hunter.chasens18@ncf.edu>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Thanks,
Lijo
> ---
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 517b9fb4624c..576202bf64f3 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -989,12 +989,13 @@ static ssize_t amdgpu_get_pp_features(struct device *dev,
> * Reading back the files will show you the available power levels within
> * the power state and the clock information for those levels. If deep sleep is
> * applied to a clock, the level will be denoted by a special level 'S:'
> - * E.g.,
> - * S: 19Mhz *
> - * 0: 615Mhz
> - * 1: 800Mhz
> - * 2: 888Mhz
> - * 3: 1000Mhz
> + * E.g., ::
> + *
> + * S: 19Mhz *
> + * 0: 615Mhz
> + * 1: 800Mhz
> + * 2: 888Mhz
> + * 3: 1000Mhz
> *
> *
> * To manually adjust these states, first select manual using
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] drm: amd: Resolve Sphinx unexpected indentation warning
2023-11-08 4:07 ` Lazar, Lijo
@ 2023-11-08 19:04 ` Alex Deucher
-1 siblings, 0 replies; 11+ messages in thread
From: Alex Deucher @ 2023-11-08 19:04 UTC (permalink / raw)
To: Lazar, Lijo
Cc: linux-doc, Xinhui.Pan, linux-kernel, amd-gfx, dri-devel,
Hunter Chasens, alexander.deucher, christian.koenig
Applied. Thanks!
On Tue, Nov 7, 2023 at 11:17 PM Lazar, Lijo <lijo.lazar@amd.com> wrote:
>
>
>
> On 11/7/2023 9:58 PM, Hunter Chasens wrote:
> > Resolves Sphinx unexpected indentation warning when compiling
> > documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
> > a literal block to keep vertical formatting of the
> > example power state list.
> >
> > Signed-off-by: Hunter Chasens <hunter.chasens18@ncf.edu>
>
> Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
>
> Thanks,
> Lijo
>
> > ---
> > drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 +++++++------
> > 1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> > index 517b9fb4624c..576202bf64f3 100644
> > --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> > +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> > @@ -989,12 +989,13 @@ static ssize_t amdgpu_get_pp_features(struct device *dev,
> > * Reading back the files will show you the available power levels within
> > * the power state and the clock information for those levels. If deep sleep is
> > * applied to a clock, the level will be denoted by a special level 'S:'
> > - * E.g.,
> > - * S: 19Mhz *
> > - * 0: 615Mhz
> > - * 1: 800Mhz
> > - * 2: 888Mhz
> > - * 3: 1000Mhz
> > + * E.g., ::
> > + *
> > + * S: 19Mhz *
> > + * 0: 615Mhz
> > + * 1: 800Mhz
> > + * 2: 888Mhz
> > + * 3: 1000Mhz
> > *
> > *
> > * To manually adjust these states, first select manual using
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3] drm: amd: Resolve Sphinx unexpected indentation warning
@ 2023-11-08 19:04 ` Alex Deucher
0 siblings, 0 replies; 11+ messages in thread
From: Alex Deucher @ 2023-11-08 19:04 UTC (permalink / raw)
To: Lazar, Lijo
Cc: Hunter Chasens, linux-kernel, linux-doc, Xinhui.Pan, dri-devel,
amd-gfx, alexander.deucher, christian.koenig
Applied. Thanks!
On Tue, Nov 7, 2023 at 11:17 PM Lazar, Lijo <lijo.lazar@amd.com> wrote:
>
>
>
> On 11/7/2023 9:58 PM, Hunter Chasens wrote:
> > Resolves Sphinx unexpected indentation warning when compiling
> > documentation (e.g. `make htmldocs`). Replaces tabs with spaces and adds
> > a literal block to keep vertical formatting of the
> > example power state list.
> >
> > Signed-off-by: Hunter Chasens <hunter.chasens18@ncf.edu>
>
> Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
>
> Thanks,
> Lijo
>
> > ---
> > drivers/gpu/drm/amd/pm/amdgpu_pm.c | 13 +++++++------
> > 1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> > index 517b9fb4624c..576202bf64f3 100644
> > --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> > +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> > @@ -989,12 +989,13 @@ static ssize_t amdgpu_get_pp_features(struct device *dev,
> > * Reading back the files will show you the available power levels within
> > * the power state and the clock information for those levels. If deep sleep is
> > * applied to a clock, the level will be denoted by a special level 'S:'
> > - * E.g.,
> > - * S: 19Mhz *
> > - * 0: 615Mhz
> > - * 1: 800Mhz
> > - * 2: 888Mhz
> > - * 3: 1000Mhz
> > + * E.g., ::
> > + *
> > + * S: 19Mhz *
> > + * 0: 615Mhz
> > + * 1: 800Mhz
> > + * 2: 888Mhz
> > + * 3: 1000Mhz
> > *
> > *
> > * To manually adjust these states, first select manual using
^ permalink raw reply [flat|nested] 11+ messages in thread