From: Thierry Reding <treding@nvidia.com>
To: Daniel Mentz <danielmentz@google.com>
Cc: iommu@lists.linux.dev, Frank Rowand <frowand.list@gmail.com>,
Rob Herring <robh@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH] iommu: Fix printk arg in of_iommu_get_resv_regions()
Date: Wed, 8 Nov 2023 14:12:52 +0100 [thread overview]
Message-ID: <ZUuJVD2PpB73Is3Z@orome.fritz.box> (raw)
In-Reply-To: <20231108062226.928985-1-danielmentz@google.com>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
On Tue, Nov 07, 2023 at 10:22:26PM -0800, Daniel Mentz wrote:
> The variable phys is defined as (struct resource *) which aligns with
> the printk format specifier %pr. Taking the address of it results in a
> value of type (struct resource **) which is incompatible with the format
> specifier %pr. Therefore, remove the address of operator (&).
>
> Fixes: a5bf3cfce8cb ("iommu: Implement of_iommu_get_resv_regions()")
> Signed-off-by: Daniel Mentz <danielmentz@google.com>
> ---
> drivers/iommu/of_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Ugh... I don't know why I missed that, because I thought I had tested
that path. In any case, this fix is correct, so:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-11-08 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 6:22 [PATCH] iommu: Fix printk arg in of_iommu_get_resv_regions() Daniel Mentz
2023-11-08 13:12 ` Thierry Reding [this message]
2023-12-01 9:17 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUuJVD2PpB73Is3Z@orome.fritz.box \
--to=treding@nvidia.com \
--cc=danielmentz@google.com \
--cc=frowand.list@gmail.com \
--cc=iommu@lists.linux.dev \
--cc=jroedel@suse.de \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.