Re: [Intel-xe] [PATCH 01/12] drm/xe: Remove shutdown

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Nov 08, 2023 at 01:33:33AM +0100, Michał Winiarski wrote:
> It's not a required callback,

That doesn't seem right. Display should be turned off, all DMA
should be stopped, etc. here.

> and Xe implementation is empty 

That is certainly true.

> - remove
> it.
> 
> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_device.c | 4 ----
>  drivers/gpu/drm/xe/xe_device.h | 1 -
>  drivers/gpu/drm/xe/xe_pci.c    | 6 ------
>  3 files changed, 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 515cdf599fab3..078c92576062a 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -476,10 +476,6 @@ void xe_device_remove(struct xe_device *xe)
>  	xe_irq_shutdown(xe);
>  }
>  
> -void xe_device_shutdown(struct xe_device *xe)
> -{
> -}
> -
>  void xe_device_add_persistent_exec_queues(struct xe_device *xe, struct xe_exec_queue *q)
>  {
>  	mutex_lock(&xe->persistent_engines.lock);
> diff --git a/drivers/gpu/drm/xe/xe_device.h b/drivers/gpu/drm/xe/xe_device.h
> index c4232de40ae08..ee89af6b1ea9c 100644
> --- a/drivers/gpu/drm/xe/xe_device.h
> +++ b/drivers/gpu/drm/xe/xe_device.h
> @@ -39,7 +39,6 @@ struct xe_device *xe_device_create(struct pci_dev *pdev,
>  				   const struct pci_device_id *ent);
>  int xe_device_probe(struct xe_device *xe);
>  void xe_device_remove(struct xe_device *xe);
> -void xe_device_shutdown(struct xe_device *xe);
>  
>  void xe_device_add_persistent_exec_queues(struct xe_device *xe, struct xe_exec_queue *q);
>  void xe_device_remove_persistent_exec_queues(struct xe_device *xe,
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 2fae45b9d88e1..007e272d2758f 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -748,11 +748,6 @@ static int xe_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>  	return err;
>  }
>  
> -static void xe_pci_shutdown(struct pci_dev *pdev)
> -{
> -	xe_device_shutdown(pdev_to_xe_device(pdev));
> -}
> -
>  #ifdef CONFIG_PM_SLEEP
>  static void d3cold_toggle(struct pci_dev *pdev, enum toggle_d3cold toggle)
>  {
> @@ -892,7 +887,6 @@ static struct pci_driver xe_pci_driver = {
>  	.id_table = pciidlist,
>  	.probe = xe_pci_probe,
>  	.remove = xe_pci_remove,
> -	.shutdown = xe_pci_shutdown,
>  #ifdef CONFIG_PM_SLEEP
>  	.driver.pm = &xe_pm_ops,
>  #endif
> -- 
> 2.42.0

-- 
Ville Syrjälä
Intel