From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B18B42231F for ; Thu, 23 Nov 2023 16:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: by smtp.kernel.org (Postfix) with ESMTPSA id C38D2C433CB; Thu, 23 Nov 2023 16:55:33 +0000 (UTC) Date: Thu, 23 Nov 2023 16:55:31 +0000 From: Catalin Marinas To: Huang Shijie Cc: will@kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org, arnd@arndb.de, mark.rutland@arm.com, broonie@kernel.org, keescook@chromium.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, patches@amperecomputing.com Subject: Re: [PATCH v3] arm64: irq: set the correct node for VMAP stack Message-ID: References: <20231118160205.3923-1-shijie@os.amperecomputing.com> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231118160205.3923-1-shijie@os.amperecomputing.com> On Sun, Nov 19, 2023 at 12:02:05AM +0800, Huang Shijie wrote: > diff --git a/drivers/base/arch_numa.c b/drivers/base/arch_numa.c > index eaa31e567d1e..90519d981471 100644 > --- a/drivers/base/arch_numa.c > +++ b/drivers/base/arch_numa.c > @@ -144,7 +144,7 @@ void __init early_map_cpu_to_node(unsigned int cpu, int nid) > unsigned long __per_cpu_offset[NR_CPUS] __read_mostly; > EXPORT_SYMBOL(__per_cpu_offset); > > -static int __init early_cpu_to_node(int cpu) > +int early_cpu_to_node(int cpu) > { > return cpu_to_node_map[cpu]; > } I don't think we need this change, let's make the arm64 init_irq_stacks() an __init function instead. > diff --git a/include/asm-generic/numa.h b/include/asm-generic/numa.h > index 1a3ad6d29833..16073111bffc 100644 > --- a/include/asm-generic/numa.h > +++ b/include/asm-generic/numa.h > @@ -35,6 +35,7 @@ int __init numa_add_memblk(int nodeid, u64 start, u64 end); > void __init numa_set_distance(int from, int to, int distance); > void __init numa_free_distance(void); > void __init early_map_cpu_to_node(unsigned int cpu, int nid); > +int early_cpu_to_node(int cpu); And add __init here. With these changes: Reviewed-by: Catalin Marinas Happy to take this patch through the arm64 tree if I get an ack from Greg or Rafael on the drivers/* change. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52051C61D97 for ; Thu, 23 Nov 2023 16:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4fub62DL3yqjFUzCBaWfP0dAnWs7v4zIc65cCxzhgvs=; b=V4dDZQzyd7/yV8 JePFgjnvntZGrvPoFM4P05kPPTgnJPk2ItgFv7ad6Io+assiRrB+PfAWwxmsSeIpdauVusOhTWPbs wGB9vg3YAtZ3rejPTiRASlJul3GazjEO4qAdWjrQ60+yB1qxBI7CVUB1t3agYdBPYbK6/k6cLjElQ eIP++4bkRDryXrJ1cNGgvlfYPZQFgU02LC/ovyAmcI6KL+h+jL4tOGKIQZRB23HzJzaOQW/KA7IoR XlYRwbTGyQtPfkedGpiFXrqotwUw4povje8Dqkl+ZiKUx2IdSzqI38IcySL8t3XNSzWfk/rtCdgkl ioR8NQylGuD9uczdFqRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6CzM-005LlA-2t; Thu, 23 Nov 2023 16:55:40 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6CzK-005Lkk-0b for linux-arm-kernel@lists.infradead.org; Thu, 23 Nov 2023 16:55:39 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id BE160B82E2D; Thu, 23 Nov 2023 16:55:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C38D2C433CB; Thu, 23 Nov 2023 16:55:33 +0000 (UTC) Date: Thu, 23 Nov 2023 16:55:31 +0000 From: Catalin Marinas To: Huang Shijie Cc: will@kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org, arnd@arndb.de, mark.rutland@arm.com, broonie@kernel.org, keescook@chromium.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, patches@amperecomputing.com Subject: Re: [PATCH v3] arm64: irq: set the correct node for VMAP stack Message-ID: References: <20231118160205.3923-1-shijie@os.amperecomputing.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231118160205.3923-1-shijie@os.amperecomputing.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231123_085538_368362_E487079C X-CRM114-Status: GOOD ( 12.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Nov 19, 2023 at 12:02:05AM +0800, Huang Shijie wrote: > diff --git a/drivers/base/arch_numa.c b/drivers/base/arch_numa.c > index eaa31e567d1e..90519d981471 100644 > --- a/drivers/base/arch_numa.c > +++ b/drivers/base/arch_numa.c > @@ -144,7 +144,7 @@ void __init early_map_cpu_to_node(unsigned int cpu, int nid) > unsigned long __per_cpu_offset[NR_CPUS] __read_mostly; > EXPORT_SYMBOL(__per_cpu_offset); > > -static int __init early_cpu_to_node(int cpu) > +int early_cpu_to_node(int cpu) > { > return cpu_to_node_map[cpu]; > } I don't think we need this change, let's make the arm64 init_irq_stacks() an __init function instead. > diff --git a/include/asm-generic/numa.h b/include/asm-generic/numa.h > index 1a3ad6d29833..16073111bffc 100644 > --- a/include/asm-generic/numa.h > +++ b/include/asm-generic/numa.h > @@ -35,6 +35,7 @@ int __init numa_add_memblk(int nodeid, u64 start, u64 end); > void __init numa_set_distance(int from, int to, int distance); > void __init numa_free_distance(void); > void __init early_map_cpu_to_node(unsigned int cpu, int nid); > +int early_cpu_to_node(int cpu); And add __init here. With these changes: Reviewed-by: Catalin Marinas Happy to take this patch through the arm64 tree if I get an ack from Greg or Rafael on the drivers/* change. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel