From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: chandanbabu@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: clean up dqblk extraction
Date: Wed, 22 Nov 2023 08:21:16 +1100 [thread overview]
Message-ID: <ZV0fTCuv2ZNxtmvK@dread.disaster.area> (raw)
In-Reply-To: <170050509891.475996.3583155500177528277.stgit@frogsfrogsfrogs>
On Mon, Nov 20, 2023 at 10:31:38AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Since the introduction of xfs_dqblk in V5, xfs really ought to find the
> dqblk pointer from the dquot buffer, then compute the xfs_disk_dquot
> pointer from the dqblk pointer. Fix the open-coded xfs_buf_offset calls
> and do the type checking in the correct order.
>
> Note that this has made no practical difference since the start of the
> xfs_disk_dquot is coincident with the start of the xfs_dqblk.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2023-11-21 21:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 18:31 [PATCHSET 0/2] xfs: dquot recovery validation strengthening Darrick J. Wong
2023-11-20 18:31 ` [PATCH 1/2] xfs: clean up dqblk extraction Darrick J. Wong
2023-11-21 4:34 ` Christoph Hellwig
2023-11-21 21:21 ` Dave Chinner [this message]
2023-11-20 18:31 ` [PATCH 2/2] xfs: dquot recovery does not validate the recovered dquot Darrick J. Wong
2023-11-21 4:34 ` Christoph Hellwig
2023-11-21 21:25 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZV0fTCuv2ZNxtmvK@dread.disaster.area \
--to=david@fromorbit.com \
--cc=chandanbabu@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.