From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Josef Bacik <josef@toxicpanda.com>,
Amir Goldstein <amir73il@gmail.com>, Jens Axboe <axboe@kernel.dk>,
Christian Brauner <brauner@kernel.org>,
David Howells <dhowells@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: allow calling kiocb_end_write() unmatched with kiocb_start_write()
Date: Tue, 21 Nov 2023 22:50:29 -0800 [thread overview]
Message-ID: <ZV2kteeZ972k1p1W@infradead.org> (raw)
In-Reply-To: <ZV0hWVWeI6QOVfYM@dread.disaster.area>
On Wed, Nov 22, 2023 at 08:30:01AM +1100, Dave Chinner wrote:
> I like this a lot better than an internal flag that allows
> unbalanced start/end calls to proliferate. I find it much easier to
> read the code, determine the correct cleanup is being done and
> maintain the code in future when calls need to be properly
> paired....
Agreed.
next prev parent reply other threads:[~2023-11-22 6:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 13:25 [PATCH] fs: allow calling kiocb_end_write() unmatched with kiocb_start_write() Amir Goldstein
2023-11-21 21:00 ` Josef Bacik
2023-11-21 21:30 ` Dave Chinner
2023-11-22 5:38 ` Amir Goldstein
2023-11-22 6:50 ` Christoph Hellwig [this message]
2023-11-22 10:20 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZV2kteeZ972k1p1W@infradead.org \
--to=hch@infradead.org \
--cc=amir73il@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=david@fromorbit.com \
--cc=dhowells@redhat.com \
--cc=jack@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.