From: Christoph Hellwig <hch@infradead.org>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: Christoph Hellwig <hch@infradead.org>,
davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, jkbs@redhat.com,
kunwu.chan@hotmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ipv6: Correct/silence an endian warning in ip6_multipath_l3_keys
Date: Wed, 22 Nov 2023 01:06:33 -0800 [thread overview]
Message-ID: <ZV3EmcsEqfFuvW4P@infradead.org> (raw)
In-Reply-To: <37452b03-9c24-42a7-bb4f-ed19f622f0ef@kylinos.cn>
On Wed, Nov 22, 2023 at 05:04:49PM +0800, Kunwu Chan wrote:
> Hi Christoph,
> Thanks for your reply.
> I also can't guarantee that it's the right thing to do. Just wanted to
> dispel this warning. If you have any better way, please let me know.
The most likely reason is that it needs an endianess conversion. I
don't know the answer either, but actually spending a few minutes
trying to understand the code should allow you to find it out quickly.
Removing a warning for it's own sake when you don't understand it is
never a good idea.
next prev parent reply other threads:[~2023-11-22 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 7:19 [PATCH v3] ipv6: Correct/silence an endian warning in ip6_multipath_l3_keys Kunwu Chan
2023-11-22 7:23 ` Christoph Hellwig
2023-11-22 9:04 ` Kunwu Chan
2023-11-22 9:06 ` Christoph Hellwig [this message]
2023-11-22 18:51 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZV3EmcsEqfFuvW4P@infradead.org \
--to=hch@infradead.org \
--cc=chentao@kylinos.cn \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jkbs@redhat.com \
--cc=kuba@kernel.org \
--cc=kunwu.chan@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.