From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9DA7C61D9B for ; Wed, 22 Nov 2023 17:36:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230353AbjKVRgx (ORCPT ); Wed, 22 Nov 2023 12:36:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230398AbjKVRgw (ORCPT ); Wed, 22 Nov 2023 12:36:52 -0500 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3D061B1 for ; Wed, 22 Nov 2023 09:36:48 -0800 (PST) Received: from [78.30.43.141] (port=34990 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r5r9Z-00DhMP-1H; Wed, 22 Nov 2023 18:36:46 +0100 Date: Wed, 22 Nov 2023 18:36:44 +0100 From: Pablo Neira Ayuso To: Thomas Haller Cc: NetFilter Subject: Re: [PATCH nft 1/1] tests: prettify JSON in test output and add helper Message-ID: References: <20231122111946.439474-1-thaller@redhat.com> <267d0bff359a01b3222506e272bb1c2b63c154c8.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <267d0bff359a01b3222506e272bb1c2b63c154c8.camel@redhat.com> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Nov 22, 2023 at 01:55:57PM +0100, Thomas Haller wrote: [...] > As always, you will find some result files in /tmp/nft- > test.latest.$USER/, which I usually read with > > $ grep --color=always ^ -aR /tmp/nft-test.latest.*/ | less -R > > there will be a new file there, named "ruleset-diff.json.pretty". > > It contains the content of "./tests/shell/helpers/json-diff-pretty.sh" > output. > > > For example: > > $ cp tests/shell/testcases/bitwise/dumps/0040mark_binop_2.json-nft tests/shell/testcases/bitwise/dumps/0040mark_binop_3.json-nft > $ ./tests/shell/run-tests.sh tests/shell/testcases/bitwise/0040mark_binop_3 > > > leaves a file > > /tmp/nft-test.latest.*/test-tests-shell-testcases-bitwise-0040mark_binop_3.1/ruleset-diff.json.pretty Thanks for explaining, this is now applied. And please, add copy and paste this info to the README file (unless I am overlooking anything, it is not yet there).