All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
	edumazet@google.com, jacob.e.keller@intel.com, jhs@mojatatu.com,
	johannes@sipsolutions.net, andriy.shevchenko@linux.intel.com,
	amritha.nambiar@intel.com, sdf@google.com, horms@kernel.org
Subject: Re: [patch net-next v3 5/9] genetlink: implement release callback and free sk_user_data there
Date: Wed, 22 Nov 2023 19:20:58 +0100	[thread overview]
Message-ID: <ZV5GikewsOpDqHwK@nanopsycho> (raw)
In-Reply-To: <20231122090820.3b139890@kernel.org>

Wed, Nov 22, 2023 at 06:08:20PM CET, kuba@kernel.org wrote:
>On Wed, 22 Nov 2023 10:29:44 +0100 Jiri Pirko wrote:
>> >If you're doing it centrally, please put the state as a new field in
>> >the netlink socket. sk_user_data is for the user.  
>> 
>> I planned to use sk_user_data. What do you mean it is for the user?
>> I see it is already used for similar usecase by connector for example:
>
>I'm pretty sure I complained when it was being added. Long story.
>AFAIU user as in if the socket is opened by a kernel module, the kernel
>module is the user. There's no need to use this field for the
>implementation since the implementation can simply extend its 
>own structure to add a properly typed field.

Okay, excuse me, as always I'm slow here. What structure are
you refering to?

Thanks!

  reply	other threads:[~2023-11-22 18:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-20  8:46 [patch net-next v3 0/9] devlink: introduce notifications filtering Jiri Pirko
2023-11-20  8:46 ` [patch net-next v3 1/9] devlink: use devl_is_registered() helper instead xa_get_mark() Jiri Pirko
2023-11-20  8:46 ` [patch net-next v3 2/9] devlink: introduce __devl_is_registered() helper and use it instead of xa_get_mark() Jiri Pirko
2023-11-20  8:46 ` [patch net-next v3 3/9] devlink: send notifications only if there are listeners Jiri Pirko
2023-11-20  8:46 ` [patch net-next v3 4/9] devlink: introduce a helper for netlink multicast send Jiri Pirko
2023-11-20  8:46 ` [patch net-next v3 5/9] genetlink: implement release callback and free sk_user_data there Jiri Pirko
2023-11-21  2:50   ` Jakub Kicinski
2023-11-21  7:36     ` Jiri Pirko
2023-11-21 13:12     ` Jiri Pirko
2023-11-21 17:55       ` Jakub Kicinski
2023-11-22  9:29         ` Jiri Pirko
2023-11-22 17:08           ` Jakub Kicinski
2023-11-22 18:20             ` Jiri Pirko [this message]
2023-11-22 19:50               ` Jakub Kicinski
2023-11-23  6:37                 ` Jiri Pirko
2023-11-23 10:32             ` Jiri Pirko
2023-11-23 16:24               ` Jakub Kicinski
2023-11-23 16:53                 ` Jiri Pirko
2023-11-20  8:46 ` [patch net-next v3 6/9] netlink: introduce typedef for filter function Jiri Pirko
2023-11-20  8:46 ` [patch net-next v3 7/9] genetlink: introduce helpers to do filtered multicast Jiri Pirko
2023-11-20  8:46 ` [patch net-next v3 8/9] devlink: add a command to set notification filter and use it for multicasts Jiri Pirko
2023-11-21  2:51   ` Jakub Kicinski
2023-11-21  7:35     ` Jiri Pirko
2023-11-20  8:46 ` [patch net-next v3 9/9] devlink: extend multicast filtering by port index Jiri Pirko
2023-11-21  2:29 ` [patch net-next v3 0/9] devlink: introduce notifications filtering Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZV5GikewsOpDqHwK@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=amritha.nambiar@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jhs@mojatatu.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.