From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB1AE33CD7 for ; Thu, 23 Nov 2023 14:31:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="isIs17Dt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02F5DC433C7; Thu, 23 Nov 2023 14:31:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700749889; bh=c7OkPUznAAchcebEgWWplu2JA5cYUW6AoggSDeYEnUo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=isIs17Dtqp+pc98n2d7ijWAn8hxjijg6LS2cnd/eWW9B8UNaPtGFGa6wDyi0dNoes 7rOXhM7yybPW2CXmIEPrz8ObL1t+vsePn7hxo9E28d/YyNKZ77xw1bfQr7FA6xp/9u kF6KtDK6Lrm9K8/HZ+ryF/d6Jpw8BiFyXFoOqN8r8C0PZutmntxd4tOneh7NHCWlQx VdLkH8qSot+BuMJW95lVx3/Pxm8AL3X3f0F7d9haY8QPu+5MPGM4Ry4UKYBP3O+dk4 ntKROYy9XQVsAxPC1bTx1Fa5wioCTYUkqRpakuLEXW72iXAnChWem++lHhBy+Fbr9B 7LOp9sts+vIxg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 7F73040094; Thu, 23 Nov 2023 11:31:26 -0300 (-03) Date: Thu, 23 Nov 2023 11:31:26 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: James Clark , linux-perf-users@vger.kernel.org, John Garry , Will Deacon , Mike Leach , Leo Yan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf cs-etm: Bump minimum OpenCSD version to ensure a bugfix is present Message-ID: References: <20230901133716.677499-1-james.clark@arm.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Em Sun, Sep 03, 2023 at 08:36:35PM -0700, Ian Rogers escreveu: > On Fri, Sep 1, 2023 at 6:37 AM James Clark wrote: > > > > Since commit d927ef5004ef ("perf cs-etm: Add exception level consistency > > check"), the exception that was added to Perf will be triggered unless > > the following bugfix from OpenCSD is present: > > > > - _Version 1.2.1_: > > - __Bugfix__: > > ETM4x / ETE - output of context elements to client can in some > > circumstances be delayed until after subsequent atoms have been > > processed leading to incorrect memory decode access via the client > > callbacks. Fixed to flush context elements immediately they are > > committed. > > > > Rather than remove the assert and silently fail, just increase the > > minimum version requirement to avoid hard to debug issues and > > regressions. > > > > Signed-off-by: James Clark > > Reviewed-by: Ian Rogers Thanks, applied to perf-tools-next. - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C203BC61DF7 for ; Thu, 23 Nov 2023 14:32:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VDARXkI9I58j1YRta4Fevcqy9NGMQGGz7DgPjr5lU8E=; b=UEcGBEZw4F2LFm 1TnvyOVGx5qml8986R89vCbULSqEjRbp3IrNDFzrysbF7XTOfC3AH/Kkp2IwfP/PDbdyUuQgRipOo pGFQuyEDAxia2szk/YxB7MS4Z20sDlUlqw8EzzoTvxZnjuoaGzJXJLPypThhwRBhQfug4ClcDCsV+ BaILkMXodXdPu3YgIQbeRDL1cpyRAe7SuqpqOxYN/skpWXR12Sw/hlet/Dgp88sCyqnt8bv7uQnjd +F4OW8RjA1S14cdxMtL4Idwx8XySRzhZRFqwfFUq/U61nDhvI8OvVAuf/DcbpN2V0rAj8Zbnl9kNu 4K1+NtgOKUpZARbtLpBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6Ajv-0051Q0-0d; Thu, 23 Nov 2023 14:31:35 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6Aju-0051Pt-0A for linux-arm-kernel@bombadil.infradead.org; Thu, 23 Nov 2023 14:31:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=g1ulDpW5ut5K/a9r9aQQhKA3qe8bjjYdjDTZRKC5aNg=; b=ZH2LLNEG6yiLCdaaHNfFsbyIK7 bRd8gm3MWT2Zr2jBLYqq4CVACG/7Q9dIlBrCspbb6zNDRh80lWaFb+avOTnJrrzTvypz/P9WZSjY9 vzBRLXryVlX6PeiRs34WFxa31humEsNuWY237L+NAXa98Td89NEEl/qqceKs06Ov2CVTk6HCDb5e3 +u77JuRRFwSQac/9lyYS2hR1OopFKLgeeBCzWY9t6uzFC9+Bc1LnMO5XUZtAInlg/AL9bWyCvPoaK evyaGQcXSXOvNbslcNxQvO9cw/2r0GoBovajJ0xYRmZTjZPm9OaNc9YJb+LSWf+eEmIo3kiJhJtKD CYYIrXnw==; Received: from [187.19.173.117] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1r6Ajp-00D3r8-2q for linux-arm-kernel@lists.infradead.org; Thu, 23 Nov 2023 14:31:31 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 7F73040094; Thu, 23 Nov 2023 11:31:26 -0300 (-03) Date: Thu, 23 Nov 2023 11:31:26 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: James Clark , linux-perf-users@vger.kernel.org, John Garry , Will Deacon , Mike Leach , Leo Yan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf cs-etm: Bump minimum OpenCSD version to ensure a bugfix is present Message-ID: References: <20230901133716.677499-1-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gU3VuLCBTZXAgMDMsIDIwMjMgYXQgMDg6MzY6MzVQTSAtMDcwMCwgSWFuIFJvZ2VycyBlc2Ny ZXZldToKPiBPbiBGcmksIFNlcCAxLCAyMDIzIGF0IDY6MzfigK9BTSBKYW1lcyBDbGFyayA8amFt ZXMuY2xhcmtAYXJtLmNvbT4gd3JvdGU6Cj4gPgo+ID4gU2luY2UgY29tbWl0IGQ5MjdlZjUwMDRl ZiAoInBlcmYgY3MtZXRtOiBBZGQgZXhjZXB0aW9uIGxldmVsIGNvbnNpc3RlbmN5Cj4gPiBjaGVj ayIpLCB0aGUgZXhjZXB0aW9uIHRoYXQgd2FzIGFkZGVkIHRvIFBlcmYgd2lsbCBiZSB0cmlnZ2Vy ZWQgdW5sZXNzCj4gPiB0aGUgZm9sbG93aW5nIGJ1Z2ZpeCBmcm9tIE9wZW5DU0QgaXMgcHJlc2Vu dDoKPiA+Cj4gPiAgLSBfVmVyc2lvbiAxLjIuMV86Cj4gPiAgIC0gX19CdWdmaXhfXzoKPiA+ICAg ICBFVE00eCAvIEVURSAtIG91dHB1dCBvZiBjb250ZXh0IGVsZW1lbnRzIHRvIGNsaWVudCBjYW4g aW4gc29tZQo+ID4gICAgIGNpcmN1bXN0YW5jZXMgYmUgZGVsYXllZCB1bnRpbCBhZnRlciBzdWJz ZXF1ZW50IGF0b21zIGhhdmUgYmVlbgo+ID4gICAgIHByb2Nlc3NlZCBsZWFkaW5nIHRvIGluY29y cmVjdCBtZW1vcnkgZGVjb2RlIGFjY2VzcyB2aWEgdGhlIGNsaWVudAo+ID4gICAgIGNhbGxiYWNr cy4gRml4ZWQgdG8gZmx1c2ggY29udGV4dCBlbGVtZW50cyBpbW1lZGlhdGVseSB0aGV5IGFyZQo+ ID4gICAgIGNvbW1pdHRlZC4KPiA+Cj4gPiBSYXRoZXIgdGhhbiByZW1vdmUgdGhlIGFzc2VydCBh bmQgc2lsZW50bHkgZmFpbCwganVzdCBpbmNyZWFzZSB0aGUKPiA+IG1pbmltdW0gdmVyc2lvbiBy ZXF1aXJlbWVudCB0byBhdm9pZCBoYXJkIHRvIGRlYnVnIGlzc3VlcyBhbmQKPiA+IHJlZ3Jlc3Np b25zLgo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IEphbWVzIENsYXJrIDxqYW1lcy5jbGFya0Bhcm0u Y29tPgo+IAo+IFJldmlld2VkLWJ5OiBJYW4gUm9nZXJzIDxpcm9nZXJzQGdvb2dsZS5jb20+CgpU aGFua3MsIGFwcGxpZWQgdG8gcGVyZi10b29scy1uZXh0LgoKLSBBcm5hbGRvCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=