Re: [Intel-xe] [PATCH v2 2/2] drm/xe: rename bypass_mtcfg to skip_mtcfg

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Sun, Oct 22, 2023 at 06:57:27PM +0300, Koby Elbaz wrote:
> Per device, set this flag to access the MTCFG register or to skip it.
> This is done to standardise Xe driver naming if an access to any HW
> should be avoided.
> 
> Signed-off-by: Koby Elbaz <kelbaz@habana.ai>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
> Changes in v2:
> - Updated the flag 'bypass_mtcfg' to 'skip_mtcfg'
> 
>  drivers/gpu/drm/xe/xe_device_types.h | 4 ++--
>  drivers/gpu/drm/xe/xe_mmio.c         | 2 +-
>  drivers/gpu/drm/xe/xe_pci.c          | 4 ++--
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
> index 29199671d9e8..834e4cffb27c 100644
> --- a/drivers/gpu/drm/xe/xe_device_types.h
> +++ b/drivers/gpu/drm/xe/xe_device_types.h
> @@ -255,8 +255,8 @@ struct xe_device {
>  		u8 has_range_tlb_invalidation:1;
>  		/** @enable_display: display enabled */
>  		u8 enable_display:1;
> -		/** @bypass_mtcfg: Bypass Multi-Tile configuration from MTCFG register */
> -		u8 bypass_mtcfg:1;
> +		/** @skip_mtcfg: skip Multi-Tile configuration from MTCFG register */
> +		u8 skip_mtcfg:1;
>  		/** @skip_pcode: skip access to PCODE uC */
>  		u8 skip_pcode:1;
>  		/** @supports_mmio_ext: supports MMIO extension/s */
> diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c
> index 0da4f75c07bf..d556a213a8a9 100644
> --- a/drivers/gpu/drm/xe/xe_mmio.c
> +++ b/drivers/gpu/drm/xe/xe_mmio.c
> @@ -329,7 +329,7 @@ static void xe_mmio_probe_tiles(struct xe_device *xe)
>  	if (tile_count == 1)
>  		goto add_mmio_ext;
>  
> -	if (!xe->info.bypass_mtcfg) {
> +	if (!xe->info.skip_mtcfg) {
>  		mtcfg = xe_mmio_read64_2x32(gt, XEHP_MTCFG_ADDR);
>  		tile_count = REG_FIELD_GET(TILE_COUNT, mtcfg) + 1;
>  		if (tile_count < xe->info.tile_count) {
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 05b0aa9f2ab7..7d352b501d5c 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -60,7 +60,7 @@ struct xe_device_desc {
>  	u8 has_heci_gscfi:1;
>  
>  	u8 has_llc:1;
> -	u8 bypass_mtcfg:1;
> +	u8 skip_mtcfg:1;
>  	u8 skip_pcode:1;
>  	u8 supports_mmio_ext:1;
>  };
> @@ -578,7 +578,7 @@ static int xe_info_init(struct xe_device *xe,
>  	xe->info.graphics_name = graphics_desc->name;
>  	xe->info.media_name = media_desc ? media_desc->name : "none";
>  	xe->info.has_llc = desc->has_llc;
> -	xe->info.bypass_mtcfg = desc->bypass_mtcfg;
> +	xe->info.skip_mtcfg = desc->skip_mtcfg;
>  	xe->info.skip_pcode = desc->skip_pcode;
>  	xe->info.supports_mmio_ext = desc->supports_mmio_ext;
>  	xe->info.tile_mmio_ext_size = graphics_desc->tile_mmio_ext_size;
> -- 
> 2.34.1
>