From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "larry.lai" <larry.lai@yunjingtech.com>,
lee@kernel.org, pavel@ucw.cz, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-leds@vger.kernel.org,
GaryWang@aaeon.com.tw, musa.lin@yunjingtech.com,
jack.chang@yunjingtech.com, noah.hung@yunjingtech.com
Subject: Re: [PATCH V7 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA
Date: Mon, 13 Nov 2023 18:35:43 +0200 [thread overview]
Message-ID: <ZVJQX5sfbwersjLo@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdbPWxQMz_1gG1He5QN65BActhyea_KBv2cyQ_VQxc6Feg@mail.gmail.com>
On Mon, Nov 13, 2023 at 03:15:58PM +0100, Linus Walleij wrote:
> Hi Larry, Andy,
>
> On Tue, Oct 31, 2023 at 2:51 AM larry.lai <larry.lai@yunjingtech.com> wrote:
>
> > The UP Squared board <http://www.upboard.com> implements certain
> > features (pin control) through an on-board FPGA.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
It may not be reported as it's brand new code.
> > Signed-off-by: Gary Wang <garywang@aaeon.com.tw>
> > Signed-off-by: larry.lai <larry.lai@yunjingtech.com>
(...)
> > +#include "core.h"
> > +#include "intel/pinctrl-intel.h"
> As mentioned this is using the intel core pin control driver infrastructure
> so I want Andy's ACK on this before I merge it.
I'm pretty much sure it's an abuse of that.
I guess I told this already in the previous rounds of review... I'll try to
find time to look at this, but it looks like it still needs some job before
being taken.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-13 16:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 1:51 [PATCH V7 0/3] Add support control UP board CPLD/FPGA pin control larry.lai
2023-10-31 1:51 ` [PATCH V7 1/3] mfd: Add support for UP board CPLD/FPGA larry.lai
2023-11-14 14:11 ` Andy Shevchenko
2023-11-24 9:11 ` GaryWang 汪之逸
2023-11-27 9:37 ` Lee Jones
2023-11-30 6:19 ` GaryWang 汪之逸
2023-12-01 8:19 ` larry
2023-10-31 1:51 ` [PATCH V7 2/3] pinctrl: Add support pin control " larry.lai
2023-11-01 10:42 ` Krzysztof Kozlowski
2023-11-13 14:15 ` Linus Walleij
2023-11-13 16:35 ` Andy Shevchenko [this message]
2023-11-14 14:18 ` Andy Shevchenko
2023-11-24 9:11 ` GaryWang 汪之逸
2023-11-30 6:19 ` GaryWang 汪之逸
2023-11-30 11:21 ` Lee Jones
2023-12-01 8:40 ` larry
2023-10-31 1:51 ` [PATCH V7 3/3] leds: Add support for UP board CPLD onboard LEDS larry.lai
2023-11-01 10:44 ` Krzysztof Kozlowski
2023-11-14 14:20 ` [PATCH V7 0/3] Add support control UP board CPLD/FPGA pin control Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVJQX5sfbwersjLo@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=GaryWang@aaeon.com.tw \
--cc=jack.chang@yunjingtech.com \
--cc=larry.lai@yunjingtech.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=musa.lin@yunjingtech.com \
--cc=noah.hung@yunjingtech.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.