Re: [PATCH wireless] wifi: mt76: mt7925: fix typo in mt7925_init_he_caps

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1797 bytes --]

> Lorenzo Bianconi <lorenzo@kernel.org> writes:
> 
> >> Lorenzo Bianconi <lorenzo@kernel.org> writes:
> >> 
> >> >> Lorenzo Bianconi <lorenzo@kernel.org> writes:
> >> >> 
> >> >> > Use iftype for interface type switch in mt7925_init_he_caps routine
> >> >> >
> >> >> > Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver
> >> >> > for mt7925 chips")
> >> >> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> >> >> 
> >> >> What issue does this fix? In other words, what are the user visible
> >> >> symptoms?
> >> >
> >> > Since we are using i (equal to 8 after the for loop above) instead of iftype
> >> > we are missing some HE capabilities exposed to userspace (we are hitting the
> >> > switch default branch). I agree this is something not so harmful and we can
> >> > apply this fix to Felix's tree instead, up to you.
> >> 
> >> No no, this is fine for the wireless tree :) I just want to document if
> >> this is fixing a real issue which users can see or just a theoretical
> >> fix you found during code review. It makes handling fixes a lot easier
> >> when we have this documented in the commit message.
> >> 
> >> No need to resend because of this, I can update the commit log if you
> >> tell me what to add.
> >
> > ack, thx. I will more 'verbose' next time :)
> 
> But what I should add to the commit message? Is this just a theoretical
> fix you found during code review? Or was there a bug report which
> prompted you to fix this?

I have just spot the bug during code review but it seems it is even reported in
coverity with id 1549845.

Regards,
Lorenzo

> 
> -- 
> https://patchwork.kernel.org/project/linux-wireless/list/
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]