From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Hans de Goede <hdegoede@redhat.com>,
Ferry Toth <ftoth@exalondelft.nl>
Subject: Re: [PATCH v1 2/3] gpiolib: Fix debug messaging in gpiod_find_and_request()
Date: Tue, 14 Nov 2023 17:29:59 +0200 [thread overview]
Message-ID: <ZVOSd62yCz4lFIP1@smile.fi.intel.com> (raw)
In-Reply-To: <ZTGBqEUzgGCcZP1B@google.com>
On Thu, Oct 19, 2023 at 12:21:12PM -0700, Dmitry Torokhov wrote:
> On Thu, Oct 19, 2023 at 08:34:56PM +0300, Andy Shevchenko wrote:
> > When consolidating GPIO lookups in ACPI code, the debug messaging
> > had been broken and hence lost a bit of sense. Restore debug
> > messaging in gpiod_find_and_request() when configuring the GPIO
> > line via gpiod_configure_flags().
>
> Could you give an example of the before/after messages to show exavtly
> what is being improved?
Before your patch:
[ 5.266823] gpio-96 (ACPI:OpRegion): no flags found for ACPI:OpRegion
[ 14.182994] gpio-40 (?): no flags found for gpios
After your patch:
[ 5.085048] gpio-96 (ACPI:OpRegion): no flags found for ACPI:OpRegion
[ 13.401402] gpio-40 (?): no flags found for (null)
After this patch:
[ 3.871185] gpio-96 (ACPI:OpRegion): no flags found for ACPI:OpRegion
[ 12.491998] gpio-40 (?): no flags found for gpios
...
Looking at this it's definitely a fix.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-11-14 15:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 17:34 [PATCH v1 0/3] gpiolib: acpi: More fixes to the consolidation rework Andy Shevchenko
2023-10-19 17:34 ` [PATCH v1 1/3] gpiolib: acpi: Add missing memset(0) to acpi_get_gpiod_from_data() Andy Shevchenko
2023-10-19 19:20 ` Dmitry Torokhov
2023-10-20 9:25 ` Bartosz Golaszewski
2023-10-19 17:34 ` [PATCH v1 2/3] gpiolib: Fix debug messaging in gpiod_find_and_request() Andy Shevchenko
2023-10-19 19:21 ` Dmitry Torokhov
2023-11-14 15:29 ` Andy Shevchenko [this message]
2023-11-14 21:18 ` Dmitry Torokhov
2023-11-15 1:37 ` andy.shevchenko
2023-11-15 14:57 ` Dmitry Torokhov
2024-03-20 15:05 ` Andy Shevchenko
2023-11-14 20:26 ` Linus Walleij
2023-10-19 17:34 ` [PATCH v1 3/3] gpiolib: Make debug messages in gpiod_find_by_fwnode() less confusing Andy Shevchenko
2023-11-14 20:29 ` Linus Walleij
2023-10-20 11:50 ` [PATCH v1 0/3] gpiolib: acpi: More fixes to the consolidation rework Ferry Toth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVOSd62yCz4lFIP1@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=dmitry.torokhov@gmail.com \
--cc=ftoth@exalondelft.nl \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.