Re: [Intel-gfx] [PATCH] drm/i915/display: keep struct intel_display members sorted

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Nov 14, 2023 at 05:55:28PM +0200, Jani Nikula wrote:
> Like the comment says,
> 
> 	/* Grouping using anonymous structs. Keep sorted. */
> 
> Stick to it.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  .../gpu/drm/i915/display/intel_display_core.h  | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_core.h b/drivers/gpu/drm/i915/display/intel_display_core.h
> index aa8be02c9e54..7e82b87e9cde 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_core.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_core.h
> @@ -348,15 +348,6 @@ struct intel_display {
>  		struct intel_global_obj obj;
>  	} dbuf;
>  
> -	struct {
> -		wait_queue_head_t waitqueue;
> -
> -		/* mutex to protect pmdemand programming sequence */
> -		struct mutex lock;
> -
> -		struct intel_global_obj obj;
> -	} pmdemand;
> -
>  	struct {
>  		/*
>  		 * dkl.phy_lock protects against concurrent access of the
> @@ -444,6 +435,15 @@ struct intel_display {
>  		bool false_color;
>  	} ips;
>  
> +	struct {
> +		wait_queue_head_t waitqueue;
> +
> +		/* mutex to protect pmdemand programming sequence */
> +		struct mutex lock;
> +
> +		struct intel_global_obj obj;
> +	} pmdemand;
> +
>  	struct {
>  		struct i915_power_domains domains;
>  
> -- 
> 2.39.2
>