From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Jouni Högander" <jouni.hogander@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH v2 9/9] drm/i915/display: use intel_bo_to_drm_bo in intel_fbdev
Date: Tue, 14 Nov 2023 13:49:17 -0500 [thread overview]
Message-ID: <ZVPBLTzyLXot37F7@intel.com> (raw)
In-Reply-To: <20231114130443.2503708-10-jouni.hogander@intel.com>
On Tue, Nov 14, 2023 at 03:04:43PM +0200, Jouni Högander wrote:
> We are preparing for Xe driver. I915 and Xe object implementation are
> differing. Do not use i915_gem_object->base directly. Instead use
> intel_bo_to_drm_bo.
>
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
also here, let's go directly to drm-intel-next (of course, resending
both patches (i915-only) to intel-gfx mailing list)
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fbdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index 252f254345a2..05f614f992d6 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -332,12 +332,12 @@ static bool intel_fbdev_init_bios(struct drm_device *dev,
> continue;
> }
>
> - if (obj->base.size > max_size) {
> + if (intel_bo_to_drm_bo(obj)->size > max_size) {
> drm_dbg_kms(&i915->drm,
> "found possible fb from [PLANE:%d:%s]\n",
> plane->base.base.id, plane->base.name);
> fb = to_intel_framebuffer(plane_state->uapi.fb);
> - max_size = obj->base.size;
> + max_size = intel_bo_to_drm_bo(obj)->size;
> }
> }
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-11-14 18:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 13:04 [Intel-xe] [PATCH v2 0/9] Intel_fbdev.c refactoring Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 1/9] Revert "FIXME: drm/i915/display: Allow fbdev to allocate stolen memory" Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 2/9] fixup! FIXME: drm/i915/display: Remaining changes to make xe compile Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 3/9] drm/i915/display: split i915 specific code from intel_fbdev Jouni Högander
2023-11-14 18:47 ` Rodrigo Vivi
2023-11-15 6:06 ` Hogander, Jouni
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 4/9] fixup! drm/xe/display: Implement display support Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 5/9] " Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 6/9] " Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 7/9] " Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 8/9] " Jouni Högander
2023-11-14 13:04 ` [Intel-xe] [PATCH v2 9/9] drm/i915/display: use intel_bo_to_drm_bo in intel_fbdev Jouni Högander
2023-11-14 18:49 ` Rodrigo Vivi [this message]
2023-11-14 14:29 ` [Intel-xe] ✓ CI.Patch_applied: success for Intel_fbdev.c refactoring (rev2) Patchwork
2023-11-14 14:30 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-11-14 14:31 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-11-14 14:38 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-11-14 14:39 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-11-14 14:40 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-11-14 15:15 ` [Intel-xe] ✗ CI.BAT: failure " Patchwork
2023-11-14 18:52 ` [Intel-xe] [PATCH v2 0/9] Intel_fbdev.c refactoring Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVPBLTzyLXot37F7@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.