From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo A. R. Silva Date: Tue, 14 Nov 2023 13:53:08 -0600 Subject: [PATCH v2][next] hwmon: (aspeed-pwm-tacho) Fix -Wstringop-overflow warning in aspeed_create_fan_tach_channel() Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Based on the documentation below, the maximum number of Fan tach channels is 16: Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt:45: 45 - aspeed,fan-tach-ch : should specify the Fan tach input channel. 46 integer value in the range 0 through 15, with 0 indicating 47 Fan tach channel 0 and 15 indicating Fan tach channel 15. 48 At least one Fan tach input channel is required. However, the compiler doesn't know that, and legitimaly warns about a potential overwrite in array `u8 fan_tach_ch_source[16]` in `struct aspeed_pwm_tacho_data`, in case `index` takes a value outside the boundaries of the array: drivers/hwmon/aspeed-pwm-tacho.c: 179 struct aspeed_pwm_tacho_data { ... 184 bool fan_tach_present[16]; ... 193 u8 fan_tach_ch_source[16]; 196 }; In function ?aspeed_create_fan_tach_channel?, inlined from ?aspeed_create_fan? at drivers/hwmon/aspeed-pwm-tacho.c:877:2, inlined from ?aspeed_pwm_tacho_probe? at drivers/hwmon/aspeed-pwm-tacho.c:936:9: drivers/hwmon/aspeed-pwm-tacho.c:751:49: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=] 751 | priv->fan_tach_ch_source[index] = pwm_source; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ drivers/hwmon/aspeed-pwm-tacho.c: In function ?aspeed_pwm_tacho_probe?: drivers/hwmon/aspeed-pwm-tacho.c:193:12: note: at offset [48, 255] into destination object ?fan_tach_ch_source? of size 16 193 | u8 fan_tach_ch_source[16]; | ^~~~~~~~~~~~~~~~~~ Fix this by sanity checking `index` before using it to index arrays of size 16 elements in `struct aspeed_pwm_tacho_data`. Also, pass `dev` as argument to function `aspeed_create_fan_tach_channel()`, and add an error message in case `index` is out-of-bounds, in which case return `-EINVAL`. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Pass `dev` to function aspeed_create_fan_tach_channel() and return -EINVAL in case of error. (Guenter) - Update changelog text. v1: - Link: https://lore.kernel.org/linux-hardening/ZVJ7JBFoULzY3VGx at work/ drivers/hwmon/aspeed-pwm-tacho.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c index 997df4b40509..9a209e064e46 100644 --- a/drivers/hwmon/aspeed-pwm-tacho.c +++ b/drivers/hwmon/aspeed-pwm-tacho.c @@ -166,6 +166,8 @@ #define MAX_CDEV_NAME_LEN 16 +#define MAX_ASPEED_FAN_TACH_CHANNELS 16 + struct aspeed_cooling_device { char name[16]; struct aspeed_pwm_tacho_data *priv; @@ -181,7 +183,7 @@ struct aspeed_pwm_tacho_data { struct reset_control *rst; unsigned long clk_freq; bool pwm_present[8]; - bool fan_tach_present[16]; + bool fan_tach_present[MAX_ASPEED_FAN_TACH_CHANNELS]; u8 type_pwm_clock_unit[3]; u8 type_pwm_clock_division_h[3]; u8 type_pwm_clock_division_l[3]; @@ -190,7 +192,7 @@ struct aspeed_pwm_tacho_data { u16 type_fan_tach_unit[3]; u8 pwm_port_type[8]; u8 pwm_port_fan_ctrl[8]; - u8 fan_tach_ch_source[16]; + u8 fan_tach_ch_source[MAX_ASPEED_FAN_TACH_CHANNELS]; struct aspeed_cooling_device *cdev[8]; const struct attribute_group *groups[3]; }; @@ -737,7 +739,8 @@ static void aspeed_create_pwm_port(struct aspeed_pwm_tacho_data *priv, aspeed_set_pwm_port_fan_ctrl(priv, pwm_port, INIT_FAN_CTRL); } -static void aspeed_create_fan_tach_channel(struct aspeed_pwm_tacho_data *priv, +static int aspeed_create_fan_tach_channel(struct device *dev, + struct aspeed_pwm_tacho_data *priv, u8 *fan_tach_ch, int count, u8 pwm_source) @@ -746,11 +749,17 @@ static void aspeed_create_fan_tach_channel(struct aspeed_pwm_tacho_data *priv, for (val = 0; val < count; val++) { index = fan_tach_ch[val]; + if (index >= MAX_ASPEED_FAN_TACH_CHANNELS) { + dev_err(dev, "Invalid Fan Tach input channel %u\n.", index); + return -EINVAL; + } aspeed_set_fan_tach_ch_enable(priv->regmap, index, true); priv->fan_tach_present[index] = true; priv->fan_tach_ch_source[index] = pwm_source; aspeed_set_fan_tach_ch_source(priv->regmap, index, pwm_source); } + + return 0; } static int @@ -874,7 +883,10 @@ static int aspeed_create_fan(struct device *dev, fan_tach_ch, count); if (ret) return ret; - aspeed_create_fan_tach_channel(priv, fan_tach_ch, count, pwm_port); + + ret = aspeed_create_fan_tach_channel(dev, priv, fan_tach_ch, count, pwm_port); + if (ret) + return ret; return 0; } -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8E4A26AD3; Tue, 14 Nov 2023 19:53:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Xu1CUwPs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 473DBC433C8; Tue, 14 Nov 2023 19:53:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699991592; bh=p5bXNYWZQPXVZtSAziETIAWqwitA5MwvAafu84FIsRc=; h=Date:From:To:Cc:Subject:From; b=Xu1CUwPsb8NHywQsuf0ZjveiUXv6X56buMrIIKqhntvic2H0v69ZAGSIpnJd4JGXq x62nDwx5EpPDgApZdmHcRyahh3cgVMVMcqSQuN0tHGMd5q9TjcJIwdd/AJWnvOybct BxyPFjHQ59HKLzh3aSNwATPGQCZXSmpoR6nVlFQUmAr7+xOGmRx3sX2RfXekyk5/gt +j28UfzElp+1DtYEdQl6NrFRsLL/3A9eJGxe64yy2d+x6FMpIrgIhI3mVMPK7Dt7jN wbXRG4wrJ9T76vOS1vvmbqI5iODtF/BUyde4KI/XcWhpaW/SpEkp2mTjDlnDjaMqCo VYw7dCdZvPMYQ== Date: Tue, 14 Nov 2023 13:53:08 -0600 From: "Gustavo A. R. Silva" To: Jean Delvare , Guenter Roeck , Joel Stanley , Andrew Jeffery Cc: linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH v2][next] hwmon: (aspeed-pwm-tacho) Fix -Wstringop-overflow warning in aspeed_create_fan_tach_channel() Message-ID: Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Based on the documentation below, the maximum number of Fan tach channels is 16: Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt:45: 45 - aspeed,fan-tach-ch : should specify the Fan tach input channel. 46 integer value in the range 0 through 15, with 0 indicating 47 Fan tach channel 0 and 15 indicating Fan tach channel 15. 48 At least one Fan tach input channel is required. However, the compiler doesn't know that, and legitimaly warns about a potential overwrite in array `u8 fan_tach_ch_source[16]` in `struct aspeed_pwm_tacho_data`, in case `index` takes a value outside the boundaries of the array: drivers/hwmon/aspeed-pwm-tacho.c: 179 struct aspeed_pwm_tacho_data { ... 184 bool fan_tach_present[16]; ... 193 u8 fan_tach_ch_source[16]; 196 }; In function ‘aspeed_create_fan_tach_channel’, inlined from ‘aspeed_create_fan’ at drivers/hwmon/aspeed-pwm-tacho.c:877:2, inlined from ‘aspeed_pwm_tacho_probe’ at drivers/hwmon/aspeed-pwm-tacho.c:936:9: drivers/hwmon/aspeed-pwm-tacho.c:751:49: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=] 751 | priv->fan_tach_ch_source[index] = pwm_source; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~ drivers/hwmon/aspeed-pwm-tacho.c: In function ‘aspeed_pwm_tacho_probe’: drivers/hwmon/aspeed-pwm-tacho.c:193:12: note: at offset [48, 255] into destination object ‘fan_tach_ch_source’ of size 16 193 | u8 fan_tach_ch_source[16]; | ^~~~~~~~~~~~~~~~~~ Fix this by sanity checking `index` before using it to index arrays of size 16 elements in `struct aspeed_pwm_tacho_data`. Also, pass `dev` as argument to function `aspeed_create_fan_tach_channel()`, and add an error message in case `index` is out-of-bounds, in which case return `-EINVAL`. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Pass `dev` to function aspeed_create_fan_tach_channel() and return -EINVAL in case of error. (Guenter) - Update changelog text. v1: - Link: https://lore.kernel.org/linux-hardening/ZVJ7JBFoULzY3VGx@work/ drivers/hwmon/aspeed-pwm-tacho.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c index 997df4b40509..9a209e064e46 100644 --- a/drivers/hwmon/aspeed-pwm-tacho.c +++ b/drivers/hwmon/aspeed-pwm-tacho.c @@ -166,6 +166,8 @@ #define MAX_CDEV_NAME_LEN 16 +#define MAX_ASPEED_FAN_TACH_CHANNELS 16 + struct aspeed_cooling_device { char name[16]; struct aspeed_pwm_tacho_data *priv; @@ -181,7 +183,7 @@ struct aspeed_pwm_tacho_data { struct reset_control *rst; unsigned long clk_freq; bool pwm_present[8]; - bool fan_tach_present[16]; + bool fan_tach_present[MAX_ASPEED_FAN_TACH_CHANNELS]; u8 type_pwm_clock_unit[3]; u8 type_pwm_clock_division_h[3]; u8 type_pwm_clock_division_l[3]; @@ -190,7 +192,7 @@ struct aspeed_pwm_tacho_data { u16 type_fan_tach_unit[3]; u8 pwm_port_type[8]; u8 pwm_port_fan_ctrl[8]; - u8 fan_tach_ch_source[16]; + u8 fan_tach_ch_source[MAX_ASPEED_FAN_TACH_CHANNELS]; struct aspeed_cooling_device *cdev[8]; const struct attribute_group *groups[3]; }; @@ -737,7 +739,8 @@ static void aspeed_create_pwm_port(struct aspeed_pwm_tacho_data *priv, aspeed_set_pwm_port_fan_ctrl(priv, pwm_port, INIT_FAN_CTRL); } -static void aspeed_create_fan_tach_channel(struct aspeed_pwm_tacho_data *priv, +static int aspeed_create_fan_tach_channel(struct device *dev, + struct aspeed_pwm_tacho_data *priv, u8 *fan_tach_ch, int count, u8 pwm_source) @@ -746,11 +749,17 @@ static void aspeed_create_fan_tach_channel(struct aspeed_pwm_tacho_data *priv, for (val = 0; val < count; val++) { index = fan_tach_ch[val]; + if (index >= MAX_ASPEED_FAN_TACH_CHANNELS) { + dev_err(dev, "Invalid Fan Tach input channel %u\n.", index); + return -EINVAL; + } aspeed_set_fan_tach_ch_enable(priv->regmap, index, true); priv->fan_tach_present[index] = true; priv->fan_tach_ch_source[index] = pwm_source; aspeed_set_fan_tach_ch_source(priv->regmap, index, pwm_source); } + + return 0; } static int @@ -874,7 +883,10 @@ static int aspeed_create_fan(struct device *dev, fan_tach_ch, count); if (ret) return ret; - aspeed_create_fan_tach_channel(priv, fan_tach_ch, count, pwm_port); + + ret = aspeed_create_fan_tach_channel(dev, priv, fan_tach_ch, count, pwm_port); + if (ret) + return ret; return 0; } -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0954C4332F for ; Tue, 14 Nov 2023 19:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Y7voCtgph+3ofSWcVbTE6vNfKSxJ08gjbWlTWNk6YYA=; b=nyBC6n/2z5yGG9 9nTDjGG5mNmjSe2QfZt16wGmKUFPkQcl32rkgxeBHhGoPOTMRx53tWcKL5BLex/HxFRrtgBCbh1ad lHkZEAk7utpdFYOifELid4IE23KUrZKvn+S+R4jIZERUu/G4mkk8zazDoMihqgzeaw9R/QPztu5Bu DDVfI2r1/J1fqAMqB3Cwr9w54wREU3boMsLByAFc1BWCEEfwUK+YpsHFOWeij0zhEQglhwsprWc0t UHNnt6DdYW1uEf+yrdOPCRccsqOv0vFO3XQzWWbky+XMZuXIi/knF5gprEs8IFzVDQFBq+b5pFCT1 UIf9gtHvZLUIOnm2FWqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r2zTJ-00GeHC-1Y; Tue, 14 Nov 2023 19:53:17 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r2zTG-00GeGq-09 for linux-arm-kernel@lists.infradead.org; Tue, 14 Nov 2023 19:53:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9DBC161369; Tue, 14 Nov 2023 19:53:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 473DBC433C8; Tue, 14 Nov 2023 19:53:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699991592; bh=p5bXNYWZQPXVZtSAziETIAWqwitA5MwvAafu84FIsRc=; h=Date:From:To:Cc:Subject:From; b=Xu1CUwPsb8NHywQsuf0ZjveiUXv6X56buMrIIKqhntvic2H0v69ZAGSIpnJd4JGXq x62nDwx5EpPDgApZdmHcRyahh3cgVMVMcqSQuN0tHGMd5q9TjcJIwdd/AJWnvOybct BxyPFjHQ59HKLzh3aSNwATPGQCZXSmpoR6nVlFQUmAr7+xOGmRx3sX2RfXekyk5/gt +j28UfzElp+1DtYEdQl6NrFRsLL/3A9eJGxe64yy2d+x6FMpIrgIhI3mVMPK7Dt7jN wbXRG4wrJ9T76vOS1vvmbqI5iODtF/BUyde4KI/XcWhpaW/SpEkp2mTjDlnDjaMqCo VYw7dCdZvPMYQ== Date: Tue, 14 Nov 2023 13:53:08 -0600 From: "Gustavo A. R. Silva" To: Jean Delvare , Guenter Roeck , Joel Stanley , Andrew Jeffery Cc: linux-hwmon@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , linux-hardening@vger.kernel.org Subject: [PATCH v2][next] hwmon: (aspeed-pwm-tacho) Fix -Wstringop-overflow warning in aspeed_create_fan_tach_channel() Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231114_115314_195348_26BB9C18 X-CRM114-Status: GOOD ( 14.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org QmFzZWQgb24gdGhlIGRvY3VtZW50YXRpb24gYmVsb3csIHRoZSBtYXhpbXVtIG51bWJlciBvZiBG YW4gdGFjaApjaGFubmVscyBpcyAxNjoKCkRvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9od21vbi9hc3BlZWQtcHdtLXRhY2hvLnR4dDo0NToKIDQ1IC0gYXNwZWVkLGZhbi10YWNoLWNo IDogc2hvdWxkIHNwZWNpZnkgdGhlIEZhbiB0YWNoIGlucHV0IGNoYW5uZWwuCiA0NiAgICAgICAg ICAgICAgICAgaW50ZWdlciB2YWx1ZSBpbiB0aGUgcmFuZ2UgMCB0aHJvdWdoIDE1LCB3aXRoIDAg aW5kaWNhdGluZwogNDcgICAgICAgICAgICAgICAgIEZhbiB0YWNoIGNoYW5uZWwgMCBhbmQgMTUg aW5kaWNhdGluZyBGYW4gdGFjaCBjaGFubmVsIDE1LgogNDggICAgICAgICAgICAgICAgIEF0IGxl YXN0IG9uZSBGYW4gdGFjaCBpbnB1dCBjaGFubmVsIGlzIHJlcXVpcmVkLgoKSG93ZXZlciwgdGhl IGNvbXBpbGVyIGRvZXNuJ3Qga25vdyB0aGF0LCBhbmQgbGVnaXRpbWFseSB3YXJucyBhYm91dCBh IHBvdGVudGlhbApvdmVyd3JpdGUgaW4gYXJyYXkgYHU4IGZhbl90YWNoX2NoX3NvdXJjZVsxNl1g IGluIGBzdHJ1Y3QgYXNwZWVkX3B3bV90YWNob19kYXRhYCwKaW4gY2FzZSBgaW5kZXhgIHRha2Vz IGEgdmFsdWUgb3V0c2lkZSB0aGUgYm91bmRhcmllcyBvZiB0aGUgYXJyYXk6Cgpkcml2ZXJzL2h3 bW9uL2FzcGVlZC1wd20tdGFjaG8uYzoKMTc5IHN0cnVjdCBhc3BlZWRfcHdtX3RhY2hvX2RhdGEg ewouLi4KMTg0ICAgICAgICAgYm9vbCBmYW5fdGFjaF9wcmVzZW50WzE2XTsKLi4uCjE5MyAgICAg ICAgIHU4IGZhbl90YWNoX2NoX3NvdXJjZVsxNl07CjE5NiB9OwoKSW4gZnVuY3Rpb24g4oCYYXNw ZWVkX2NyZWF0ZV9mYW5fdGFjaF9jaGFubmVs4oCZLAogICAgaW5saW5lZCBmcm9tIOKAmGFzcGVl ZF9jcmVhdGVfZmFu4oCZIGF0IGRyaXZlcnMvaHdtb24vYXNwZWVkLXB3bS10YWNoby5jOjg3Nzoy LAogICAgaW5saW5lZCBmcm9tIOKAmGFzcGVlZF9wd21fdGFjaG9fcHJvYmXigJkgYXQgZHJpdmVy cy9od21vbi9hc3BlZWQtcHdtLXRhY2hvLmM6OTM2Ojk6CmRyaXZlcnMvaHdtb24vYXNwZWVkLXB3 bS10YWNoby5jOjc1MTo0OTogd2FybmluZzogd3JpdGluZyAxIGJ5dGUgaW50byBhIHJlZ2lvbiBv ZiBzaXplIDAgWy1Xc3RyaW5nb3Atb3ZlcmZsb3c9XQogIDc1MSB8ICAgICAgICAgICAgICAgICBw cml2LT5mYW5fdGFjaF9jaF9zb3VyY2VbaW5kZXhdID0gcHdtX3NvdXJjZTsKICAgICAgfCAgICAg ICAgICAgICAgICAgfn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5efn5+fn5+fn5+fn4K ZHJpdmVycy9od21vbi9hc3BlZWQtcHdtLXRhY2hvLmM6IEluIGZ1bmN0aW9uIOKAmGFzcGVlZF9w d21fdGFjaG9fcHJvYmXigJk6CmRyaXZlcnMvaHdtb24vYXNwZWVkLXB3bS10YWNoby5jOjE5Mzox Mjogbm90ZTogYXQgb2Zmc2V0IFs0OCwgMjU1XSBpbnRvIGRlc3RpbmF0aW9uIG9iamVjdCDigJhm YW5fdGFjaF9jaF9zb3VyY2XigJkgb2Ygc2l6ZSAxNgogIDE5MyB8ICAgICAgICAgdTggZmFuX3Rh Y2hfY2hfc291cmNlWzE2XTsKICAgICAgfCAgICAgICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+fgoK Rml4IHRoaXMgYnkgc2FuaXR5IGNoZWNraW5nIGBpbmRleGAgYmVmb3JlIHVzaW5nIGl0IHRvIGlu ZGV4IGFycmF5cyBvZgpzaXplIDE2IGVsZW1lbnRzIGluIGBzdHJ1Y3QgYXNwZWVkX3B3bV90YWNo b19kYXRhYC4gQWxzbywgcGFzcyBgZGV2YCBhcwphcmd1bWVudCB0byBmdW5jdGlvbiBgYXNwZWVk X2NyZWF0ZV9mYW5fdGFjaF9jaGFubmVsKClgLCBhbmQgYWRkIGFuIGVycm9yCm1lc3NhZ2UgaW4g Y2FzZSBgaW5kZXhgIGlzIG91dC1vZi1ib3VuZHMsIGluIHdoaWNoIGNhc2UgcmV0dXJuIGAtRUlO VkFMYC4KClNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8gQS4gUi4gU2lsdmEgPGd1c3Rhdm9hcnNAa2Vy bmVsLm9yZz4KLS0tCkNoYW5nZXMgaW4gdjI6CiAtIFBhc3MgYGRldmAgdG8gZnVuY3Rpb24gYXNw ZWVkX2NyZWF0ZV9mYW5fdGFjaF9jaGFubmVsKCkgYW5kIHJldHVybgogICAtRUlOVkFMIGluIGNh c2Ugb2YgZXJyb3IuIChHdWVudGVyKQogLSBVcGRhdGUgY2hhbmdlbG9nIHRleHQuCgp2MToKIC0g TGluazogaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGludXgtaGFyZGVuaW5nL1pWSjdKQkZvVUx6 WTNWR3hAd29yay8KCiBkcml2ZXJzL2h3bW9uL2FzcGVlZC1wd20tdGFjaG8uYyB8IDIwICsrKysr KysrKysrKysrKystLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgNCBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2h3bW9uL2FzcGVlZC1wd20tdGFjaG8uYyBi L2RyaXZlcnMvaHdtb24vYXNwZWVkLXB3bS10YWNoby5jCmluZGV4IDk5N2RmNGI0MDUwOS4uOWEy MDllMDY0ZTQ2IDEwMDY0NAotLS0gYS9kcml2ZXJzL2h3bW9uL2FzcGVlZC1wd20tdGFjaG8uYwor KysgYi9kcml2ZXJzL2h3bW9uL2FzcGVlZC1wd20tdGFjaG8uYwpAQCAtMTY2LDYgKzE2Niw4IEBA CiAKICNkZWZpbmUgTUFYX0NERVZfTkFNRV9MRU4gMTYKIAorI2RlZmluZSBNQVhfQVNQRUVEX0ZB Tl9UQUNIX0NIQU5ORUxTIDE2CisKIHN0cnVjdCBhc3BlZWRfY29vbGluZ19kZXZpY2UgewogCWNo YXIgbmFtZVsxNl07CiAJc3RydWN0IGFzcGVlZF9wd21fdGFjaG9fZGF0YSAqcHJpdjsKQEAgLTE4 MSw3ICsxODMsNyBAQCBzdHJ1Y3QgYXNwZWVkX3B3bV90YWNob19kYXRhIHsKIAlzdHJ1Y3QgcmVz ZXRfY29udHJvbCAqcnN0OwogCXVuc2lnbmVkIGxvbmcgY2xrX2ZyZXE7CiAJYm9vbCBwd21fcHJl c2VudFs4XTsKLQlib29sIGZhbl90YWNoX3ByZXNlbnRbMTZdOworCWJvb2wgZmFuX3RhY2hfcHJl c2VudFtNQVhfQVNQRUVEX0ZBTl9UQUNIX0NIQU5ORUxTXTsKIAl1OCB0eXBlX3B3bV9jbG9ja191 bml0WzNdOwogCXU4IHR5cGVfcHdtX2Nsb2NrX2RpdmlzaW9uX2hbM107CiAJdTggdHlwZV9wd21f Y2xvY2tfZGl2aXNpb25fbFszXTsKQEAgLTE5MCw3ICsxOTIsNyBAQCBzdHJ1Y3QgYXNwZWVkX3B3 bV90YWNob19kYXRhIHsKIAl1MTYgdHlwZV9mYW5fdGFjaF91bml0WzNdOwogCXU4IHB3bV9wb3J0 X3R5cGVbOF07CiAJdTggcHdtX3BvcnRfZmFuX2N0cmxbOF07Ci0JdTggZmFuX3RhY2hfY2hfc291 cmNlWzE2XTsKKwl1OCBmYW5fdGFjaF9jaF9zb3VyY2VbTUFYX0FTUEVFRF9GQU5fVEFDSF9DSEFO TkVMU107CiAJc3RydWN0IGFzcGVlZF9jb29saW5nX2RldmljZSAqY2Rldls4XTsKIAljb25zdCBz dHJ1Y3QgYXR0cmlidXRlX2dyb3VwICpncm91cHNbM107CiB9OwpAQCAtNzM3LDcgKzczOSw4IEBA IHN0YXRpYyB2b2lkIGFzcGVlZF9jcmVhdGVfcHdtX3BvcnQoc3RydWN0IGFzcGVlZF9wd21fdGFj aG9fZGF0YSAqcHJpdiwKIAlhc3BlZWRfc2V0X3B3bV9wb3J0X2Zhbl9jdHJsKHByaXYsIHB3bV9w b3J0LCBJTklUX0ZBTl9DVFJMKTsKIH0KIAotc3RhdGljIHZvaWQgYXNwZWVkX2NyZWF0ZV9mYW5f dGFjaF9jaGFubmVsKHN0cnVjdCBhc3BlZWRfcHdtX3RhY2hvX2RhdGEgKnByaXYsCitzdGF0aWMg aW50IGFzcGVlZF9jcmVhdGVfZmFuX3RhY2hfY2hhbm5lbChzdHJ1Y3QgZGV2aWNlICpkZXYsCisJ CQkJCSAgIHN0cnVjdCBhc3BlZWRfcHdtX3RhY2hvX2RhdGEgKnByaXYsCiAJCQkJCSAgIHU4ICpm YW5fdGFjaF9jaCwKIAkJCQkJICAgaW50IGNvdW50LAogCQkJCQkgICB1OCBwd21fc291cmNlKQpA QCAtNzQ2LDExICs3NDksMTcgQEAgc3RhdGljIHZvaWQgYXNwZWVkX2NyZWF0ZV9mYW5fdGFjaF9j aGFubmVsKHN0cnVjdCBhc3BlZWRfcHdtX3RhY2hvX2RhdGEgKnByaXYsCiAKIAlmb3IgKHZhbCA9 IDA7IHZhbCA8IGNvdW50OyB2YWwrKykgewogCQlpbmRleCA9IGZhbl90YWNoX2NoW3ZhbF07CisJ CWlmIChpbmRleCA+PSBNQVhfQVNQRUVEX0ZBTl9UQUNIX0NIQU5ORUxTKSB7CisJCQlkZXZfZXJy KGRldiwgIkludmFsaWQgRmFuIFRhY2ggaW5wdXQgY2hhbm5lbCAldVxuLiIsIGluZGV4KTsKKwkJ CXJldHVybiAtRUlOVkFMOworCQl9CiAJCWFzcGVlZF9zZXRfZmFuX3RhY2hfY2hfZW5hYmxlKHBy aXYtPnJlZ21hcCwgaW5kZXgsIHRydWUpOwogCQlwcml2LT5mYW5fdGFjaF9wcmVzZW50W2luZGV4 XSA9IHRydWU7CiAJCXByaXYtPmZhbl90YWNoX2NoX3NvdXJjZVtpbmRleF0gPSBwd21fc291cmNl OwogCQlhc3BlZWRfc2V0X2Zhbl90YWNoX2NoX3NvdXJjZShwcml2LT5yZWdtYXAsIGluZGV4LCBw d21fc291cmNlKTsKIAl9CisKKwlyZXR1cm4gMDsKIH0KIAogc3RhdGljIGludApAQCAtODc0LDcg Kzg4MywxMCBAQCBzdGF0aWMgaW50IGFzcGVlZF9jcmVhdGVfZmFuKHN0cnVjdCBkZXZpY2UgKmRl diwKIAkJCQkJZmFuX3RhY2hfY2gsIGNvdW50KTsKIAlpZiAocmV0KQogCQlyZXR1cm4gcmV0Owot CWFzcGVlZF9jcmVhdGVfZmFuX3RhY2hfY2hhbm5lbChwcml2LCBmYW5fdGFjaF9jaCwgY291bnQs IHB3bV9wb3J0KTsKKworCXJldCA9IGFzcGVlZF9jcmVhdGVfZmFuX3RhY2hfY2hhbm5lbChkZXYs IHByaXYsIGZhbl90YWNoX2NoLCBjb3VudCwgcHdtX3BvcnQpOworCWlmIChyZXQpCisJCXJldHVy biByZXQ7CiAKIAlyZXR1cm4gMDsKIH0KLS0gCjIuMzQuMQoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK