From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C2C6522D for ; Wed, 15 Nov 2023 08:08:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l8acyOhc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15325C433C7; Wed, 15 Nov 2023 08:08:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700035709; bh=FrpH99pmwPh2F9FlzZlkzcWpBUQxotTE5nvhX+03e28=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l8acyOhcKcJVYn2zmm5mfTdkmaM4/PFGG/coN2r2+xcaqdrKMtxCDNnsKmhw10ZrZ R56BstdttA7H1SFLYPpSw2G07DIc2rFfVd/fAu3gMnUlDr+Y1DnEs21uFapMElYRVv VrKXAPeOx8+3iuHKaa/hPruqVejo0c1xZzSLaA/vaDo9Wttwe6IPIFZD+1Vjq5EqUu EE2w4FwtfWShvYXu/o/rfmFUG2V3dElv1XvYKP+IAz0VrZCkrCpXXbTBHVlKBccqwN T3+0z00arlYyJQ7x92TKYbnobj66fx3OzE77LSzNVBn2kOY9GMhwuetlECmjg40fHV LE70K5H9G8CCA== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1r3Awk-0001ZJ-0N; Wed, 15 Nov 2023 09:08:26 +0100 Date: Wed, 15 Nov 2023 09:08:26 +0100 From: Johan Hovold To: Dmitry Baryshkov Cc: Rob Clark , Sean Paul , Abhinav Kumar , Marijn Suijten , Stephen Boyd , David Airlie , Daniel Vetter , Bjorn Andersson , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Abel Vesa Subject: Re: [PATCH v2 1/2] drm/msm/dp: don't touch DP subconnector property in eDP case Message-ID: References: <20231025092711.851168-1-dmitry.baryshkov@linaro.org> <20231025092711.851168-2-dmitry.baryshkov@linaro.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231025092711.851168-2-dmitry.baryshkov@linaro.org> On Wed, Oct 25, 2023 at 12:23:09PM +0300, Dmitry Baryshkov wrote: > From: Abel Vesa > > In case of the eDP connection there is no subconnetor and as such no > subconnector property. Put drm_dp_set_subconnector_property() calls > under the !is_edp condition. > > Fixes: bfcc3d8f94f4 ("drm/msm/dp: support setting the DP subconnector type") > Signed-off-by: Abel Vesa > Signed-off-by: Dmitry Baryshkov Reviewed-by: Johan Hovold Tested-by: Johan Hovold From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE1F7C07548 for ; Wed, 15 Nov 2023 08:08:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A06AD10E1BD; Wed, 15 Nov 2023 08:08:32 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id 77C5710E1BD; Wed, 15 Nov 2023 08:08:31 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id B6182B81864; Wed, 15 Nov 2023 08:08:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15325C433C7; Wed, 15 Nov 2023 08:08:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700035709; bh=FrpH99pmwPh2F9FlzZlkzcWpBUQxotTE5nvhX+03e28=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l8acyOhcKcJVYn2zmm5mfTdkmaM4/PFGG/coN2r2+xcaqdrKMtxCDNnsKmhw10ZrZ R56BstdttA7H1SFLYPpSw2G07DIc2rFfVd/fAu3gMnUlDr+Y1DnEs21uFapMElYRVv VrKXAPeOx8+3iuHKaa/hPruqVejo0c1xZzSLaA/vaDo9Wttwe6IPIFZD+1Vjq5EqUu EE2w4FwtfWShvYXu/o/rfmFUG2V3dElv1XvYKP+IAz0VrZCkrCpXXbTBHVlKBccqwN T3+0z00arlYyJQ7x92TKYbnobj66fx3OzE77LSzNVBn2kOY9GMhwuetlECmjg40fHV LE70K5H9G8CCA== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1r3Awk-0001ZJ-0N; Wed, 15 Nov 2023 09:08:26 +0100 Date: Wed, 15 Nov 2023 09:08:26 +0100 From: Johan Hovold To: Dmitry Baryshkov Subject: Re: [PATCH v2 1/2] drm/msm/dp: don't touch DP subconnector property in eDP case Message-ID: References: <20231025092711.851168-1-dmitry.baryshkov@linaro.org> <20231025092711.851168-2-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231025092711.851168-2-dmitry.baryshkov@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Bjorn Andersson , Abhinav Kumar , dri-devel@lists.freedesktop.org, Stephen Boyd , linux-arm-msm@vger.kernel.org, Marijn Suijten , Abel Vesa , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Oct 25, 2023 at 12:23:09PM +0300, Dmitry Baryshkov wrote: > From: Abel Vesa > > In case of the eDP connection there is no subconnetor and as such no > subconnector property. Put drm_dp_set_subconnector_property() calls > under the !is_edp condition. > > Fixes: bfcc3d8f94f4 ("drm/msm/dp: support setting the DP subconnector type") > Signed-off-by: Abel Vesa > Signed-off-by: Dmitry Baryshkov Reviewed-by: Johan Hovold Tested-by: Johan Hovold