From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A36C07548 for ; Wed, 15 Nov 2023 10:35:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234688AbjKOKfm (ORCPT ); Wed, 15 Nov 2023 05:35:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234868AbjKOKfl (ORCPT ); Wed, 15 Nov 2023 05:35:41 -0500 Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1863EC2 for ; Wed, 15 Nov 2023 02:35:38 -0800 (PST) Received: from [78.30.43.141] (port=52006 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r3DF8-00BOnF-F4; Wed, 15 Nov 2023 11:35:36 +0100 Date: Wed, 15 Nov 2023 11:35:33 +0100 From: Pablo Neira Ayuso To: Florian Westphal Cc: Thomas Haller , NetFilter Subject: Re: [PATCH nft v3 2/6] tests/shell: check and generate JSON dump files Message-ID: References: <20231114153150.406334-1-thaller@redhat.com> <20231114160903.409552-1-thaller@redhat.com> <20231115082427.GC14621@breakpoint.cc> <20231115100101.GA23742@breakpoint.cc> <20231115101020.GB23742@breakpoint.cc> <20231115103112.GC23742@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231115103112.GC23742@breakpoint.cc> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Nov 15, 2023 at 11:31:12AM +0100, Florian Westphal wrote: > Pablo Neira Ayuso wrote: > > I can skip it by now, that is easy, I was just trying not to reduce > > coverage. > > Sure, I understand that, but OTOH I think there are limitations > as to what we should provide for, in this case the work/benefit ratio > is quite bad... It can be done later, that is what the commit description said.