From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Netfilter Development <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH libnetfilter_queue v2 1/1] src: Add nfq_nlmsg_put2() - user specifies header flags
Date: Wed, 15 Nov 2023 11:57:23 +0100 [thread overview]
Message-ID: <ZVSkE1fzi68CN+uo@calendula> (raw)
In-Reply-To: <ZVSjJFXtfhX0WbP3@slk15.local.net>
On Wed, Nov 15, 2023 at 09:53:24PM +1100, Duncan Roe wrote:
> On Wed, Nov 15, 2023 at 11:25:27AM +0100, Pablo Neira Ayuso wrote:
> > On Wed, Nov 15, 2023 at 09:09:50PM +1100, Duncan Roe wrote:
> > > +EXPORT_SYMBOL
> > > +struct nlmsghdr *nfq_nlmsg_put2(char *buf, int type, uint32_t queue_num,
> > > + uint16_t flags)
> > > {
> > > struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf);
> > > nlh->nlmsg_type = (NFNL_SUBSYS_QUEUE << 8) | type;
> > > - nlh->nlmsg_flags = NLM_F_REQUEST
> > > + nlh->nlmsg_flags = flags;
> >
> > Leave this as is.
> >
> > NLM_F_REQUEST means this message goes to the kernel, this flag is a
> > must have.
>
> How about
>
> nlh->nlmsg_flags = NLM_F_REQUEST | flags;
Yes, that is fine.
next prev parent reply other threads:[~2023-11-15 10:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 22:12 [PATCH libnetfilter_queue 0/1] libnfnetlink dependency elimination Duncan Roe
2023-11-12 22:12 ` [PATCH libnetfilter_queue 1/1] src: Add nfq_nlmsg_put2() - header flags include NLM_F_ACK Duncan Roe
2023-11-14 15:26 ` Pablo Neira Ayuso
2023-11-15 10:09 ` [PATCH libnetfilter_queue v2 1/1] src: Add nfq_nlmsg_put2() - user specifies header flags Duncan Roe
2023-11-15 10:25 ` Pablo Neira Ayuso
2023-11-15 10:53 ` Duncan Roe
2023-11-15 10:57 ` Pablo Neira Ayuso [this message]
2023-11-15 11:30 ` [PATCH libnetfilter_queue v3 " Duncan Roe
2023-11-15 11:41 ` Pablo Neira Ayuso
2023-11-15 12:13 ` Duncan Roe
2023-11-18 4:11 ` Duncan Roe
2023-11-18 20:25 ` Pablo Neira Ayuso
2023-11-20 21:25 ` Duncan Roe
2023-11-23 22:23 ` [PATCH libnetfilter_queue v4 " Duncan Roe
2023-11-24 8:29 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVSkE1fzi68CN+uo@calendula \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.