All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bill O'Donnell <bodonnel@redhat.com>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/263: increase data section size to 1024M
Date: Wed, 15 Nov 2023 10:09:27 -0600	[thread overview]
Message-ID: <ZVTtN5SE3qgeaMJa@redhat.com> (raw)
In-Reply-To: <20231115055659.2027-1-xuyang2018.jy@fujitsu.com>

On Wed, Nov 15, 2023 at 12:56:59AM -0500, Yang Xu wrote:
> On machine with using raid, this case will trigger
> the following error:
> ==== NO CRC ====
> +mkfs.xfs: small data volume, ignoring data volume stripe unit 512 and stripe width 512
> == Options: rw ==
> == Options: usrquota,rw ==
> 
> mkfs.xfs generates this error since xfsprogs commit 42371fb36
> ("mkfs: ignore data blockdev stripe geometry for small filesystems").
> It disables automatic detection of stripe unit and width if the
> data device is less than 1GB.
> 
> To slove false poistive, just increase data section size to 1G.
     ^^^^^^^^^^^^^^^^^^^^
     solve false positive
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>

Reviewed-by: Bill O'Donnell <bodonnel@redhat.com>

> ---
>  tests/xfs/263 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/xfs/263 b/tests/xfs/263
> index fadd6280..48581bac 100755
> --- a/tests/xfs/263
> +++ b/tests/xfs/263
> @@ -73,11 +73,11 @@ function test_all_state()
>  
>  echo "==== NO CRC ===="
>  # Control size to control inode numbers
> -_scratch_mkfs_xfs "-m crc=0 -n ftype=0 -d size=512m" >> $seqres.full
> +_scratch_mkfs_xfs "-m crc=0 -n ftype=0 -d size=1024m" >> $seqres.full
>  test_all_state
>  
>  echo "==== CRC ===="
> -_scratch_mkfs_xfs "-m crc=1 -d size=512m" >>$seqres.full
> +_scratch_mkfs_xfs "-m crc=1 -d size=1024m" >>$seqres.full
>  test_all_state
>  
>  status=0
> -- 
> 2.39.1
> 
> 


      parent reply	other threads:[~2023-11-15 16:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-15  5:56 [PATCH] xfs/263: increase data section size to 1024M Yang Xu
2023-11-15 16:05 ` Darrick J. Wong
2023-11-16  1:37   ` Yang Xu (Fujitsu)
2023-11-16  2:33   ` Zorro Lang
2023-11-16  7:05     ` Yang Xu (Fujitsu)
2023-11-16 18:53       ` Eric Sandeen
2023-11-15 16:09 ` Bill O'Donnell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZVTtN5SE3qgeaMJa@redhat.com \
    --to=bodonnel@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=xuyang2018.jy@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.