From: Mike Snitzer <snitzer@kernel.org>
To: Aaditya Raj Barnwal <abarnwal@qti.qualcomm.com>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
"Aaditya Raj Barnwal (QUIC)" <quic_abarnwal@quicinc.com>,
"agk@redhat.com" <agk@redhat.com>,
"dm-devel@lists.linux.dev" <dm-devel@lists.linux.dev>,
"Ravi Kumar Siddojigari (QUIC)" <quic_rsiddoji@quicinc.com>
Subject: Re: Patch : drivers/md/dm-verity-target.c
Date: Wed, 15 Nov 2023 12:29:50 -0500 [thread overview]
Message-ID: <ZVUADgxZPOtcSYTE@redhat.com> (raw)
In-Reply-To: <SJ0PR02MB8593C7351FBA28D4B213E105F6B1A@SJ0PR02MB8593.namprd02.prod.outlook.com>
On Wed, Nov 15 2023 at 2:01P -0500,
Aaditya Raj Barnwal <abarnwal@qti.qualcomm.com> wrote:
> Sorry if that statement confused you , It was debugging print
> that was added to check if the tight while loop has ended or not
>
> Code : dm-init.c
> dm_init_init()
>
> wait_for_device_probe();
> for (i = 0; i < ARRAY_SIZE(waitfor); i++) {
> if (waitfor[i]) {
> dev_t dev;
>
> DMERR("waiting for device %s ...", waitfor[i]);
> while ((dev= name_to_dev_t(waitfor[i]) !=0))
> fsleep(5000);
> }
>
> DMERR("exiting after %s ",waitfor[i]); <<<<<<<<<<<here it was added
> }
>
> if (waitfor[0])
> DMINFO("all devices available");
>
> list_for_each_entry(dev, &devices, list) {
> if (dm_early_create(&dev->dmi, dev->table,
> dev->target_args_array))
> break;
> }
>
Mikulas wasn't confused. He was pointing out that you have made
changes to your kernel without sharing what they are.
But your issue is that you configured the dm-mod.waitfor device
incorrectly. You must wait for the underlying physical device(s) that
the virtual DM device depends on.
Mike
next prev parent reply other threads:[~2023-11-15 17:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 9:30 Patch : drivers/md/dm-verity-target.c Aaditya Raj Barnwal (QUIC)
2023-11-06 10:04 ` Mikulas Patocka
[not found] ` <PH0PR02MB859987618E8647439950A053F6AAA@PH0PR02MB8599.namprd02.prod.outlook.com>
2023-11-06 11:55 ` Mikulas Patocka
2023-11-14 7:23 ` Aaditya Raj Barnwal (QUIC)
[not found] ` <1e9615ee3bf84ab7a3023152e3b94284@quicinc.com>
2023-11-14 14:37 ` Mikulas Patocka
2023-11-14 14:52 ` Mikulas Patocka
2023-11-15 7:01 ` Aaditya Raj Barnwal
2023-11-15 17:29 ` Mike Snitzer [this message]
2023-11-15 17:59 ` Mikulas Patocka
2023-11-15 7:00 ` Aaditya Raj Barnwal (QUIC)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVUADgxZPOtcSYTE@redhat.com \
--to=snitzer@kernel.org \
--cc=abarnwal@qti.qualcomm.com \
--cc=agk@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=mpatocka@redhat.com \
--cc=quic_abarnwal@quicinc.com \
--cc=quic_rsiddoji@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.